Skip to content
代码片段 群组 项目
该项目从 https://gitlab.com/gitlab-org/gitlab.git 镜像。 拉取镜像更新于
  1. 4月 17, 2024
  2. 4月 16, 2024
  3. 4月 09, 2024
  4. 2月 16, 2024
    • Gregorius Marco's avatar
      Expand sidekiq queue_groups to default · 658da061
      Gregorius Marco 创作于
      When routing rules is not specified, all jobs go to `default` and
      `mailers` queue by default. We can safely override
      sidekiq queue_groups to default,mailers queues only so that Redis don't
      incur overhead of BRPOPing 600+ queues.
      
      Changelog: changed
      658da061
  5. 2月 07, 2024
  6. 11月 24, 2023
  7. 11月 22, 2023
  8. 10月 04, 2023
  9. 7月 17, 2023
  10. 6月 28, 2023
  11. 4月 29, 2023
  12. 4月 25, 2023
    • Kassio Borges's avatar
      Remove Settingslogic gem · c4d5c77c
      Kassio Borges 创作于
      - For better backward compatibility use string keys on
        GitlabSettings::Options
      - Remove all the Settingslogic references from code (not comments)
      - Ensure to use GitlabSettings::Options when pushing new options to
        Array values
      - Instead of inheriting from Hash, wrap a hash in
        GitlabSettings::Options and make it respond to all the requirements.
          * PROS: This provides more autonomy on what needs to be done
          * CONS: Some places were checking by Hash, we need to tackle these
          scenarios
      - Ensure to deep_merge return nested Options
      - Use the _raw_ version of options when passing to Fog::Storage
      - Ensure to load required active_support libraries
      - Show the option name in the GitlabSettings::MissingSetting error
      - Ensure to have an option `source` for the path of the `gitlab.yml`
      - Fix GitlabSettings::Options#deep_merge and
        GitlabSettings::Options#merge to return a new GitlabSettings::Options
        object with the options deep_merged/merged
      - Add GitlabSettings#reload! for backward compatibility
      - Make file/namespace initializer arguments
      - Avoid mutating Settings in sidekiq_cluster/cli tests
      - Fix configuration stubbing
      
      Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/286873
      c4d5c77c
  13. 4月 07, 2023
  14. 2月 21, 2023
    • Carla Drago's avatar
      Use spec_helper where required · ec937818
      Carla Drago 创作于
      There were an additional number of specs failing
      that passed once spec_helper was required instead
      of fast_spec_helper
      
      Changelog: fixed
      ec937818
  15. 1月 16, 2023
  16. 1月 13, 2023
  17. 12月 06, 2022
    • Sean McGivern's avatar
      Exit with failure code when sidekiq-cluster child process fails · 49136d0c
      Sean McGivern 创作于
      sidekiq-cluster handles process supervision for its child Sidekiq
      processes, and terminates itself and all child processes if any child
      Sidekiq process exits.
      
      Previously, it always exited with a 0 status code (i.e. success), no
      matter how the child process had terminated.
      
      Now it exits with 1 if any child process had a non-zero exit code. This
      allows a process supervisor one level up (like systemd) to detect
      failures and restart.
      
      Changelog: changed
      49136d0c
  18. 12月 02, 2022
  19. 11月 30, 2022
  20. 7月 22, 2022
  21. 6月 08, 2022
    • Markus Koller's avatar
      Fix attribute inheritance in workers · 26093c38
      Markus Koller 创作于
      Only `feature_category` was correctly inherited, in addition to
      `sidekiq_options` which comes from Sidekiq.
      
      For the other attributes, we need to switch to `get_class_attribute`
      in order to also lookup values on parents.
      
      Changelog: changed
      26093c38
  22. 5月 24, 2022
  23. 5月 09, 2022
    • Matthias Käppler's avatar
      Address several edge cases in ProcessSupervisor · 625e38e0
      Matthias Käppler 创作于
      Fixed:
      - Do not determine `alive` status from the pidset returned
        by caller, since this can lead to "bouncing" state.
      - Swap loop-check with sleep call, since sleep suspends
        the calling thread, which may lead to the callback
        being invoked if `alive` is invalidated by another
        thread.
      - Do not trap INT and TERM by default; this was swallowing
        these signals for the Puma master.
      
      Changelog: fixed
      625e38e0
  24. 5月 06, 2022
    • Matthias Kaeppler's avatar
      Separate Sidekiq metrics and health-checks server · 57ab5abd
      Matthias Kaeppler 创作于
      It has been a long-standing issue that for Sidekiq,
      serving metrics and health-checks was coupled into
      a single server.
      
      We had already separated settings keys for these two
      concerns previously, in anticipation of splitting
      these endpoints apart, which is a breaking change.
      
      We can now do this with 15.0.
      
      Changelog: changed
      57ab5abd
  25. 4月 25, 2022
    • Matthias Kaeppler's avatar
      Integrate Golang metrics server with Puma · 906d53f5
      Matthias Kaeppler 创作于
      This change:
      
      - Adds a rake task to install gitlab-metrics-exporter
        into a given directory.
      - Allows to run it in place of the existing Ruby based
        exporters; this is guarded by an environment variable.
      - Extends the existing end-to-end test to test both
        Ruby and Go implementations.
      906d53f5
  26. 3月 28, 2022
  27. 3月 25, 2022
    • Matthias Käppler's avatar
      Fix missing metrics for Sidekiq exporter server · 0e77c181
      Matthias Käppler 创作于
      We were accidentally deleting metrics the exporter
      server exported about itself. Actual sidekiq worker
      metrics were not affected.
      
      This happened because we would wipe the metrics dir
      whenever sidekiq_0 starts up, but this happens after
      the metrics server starts, so the worker was deleting
      those existing metrics.
      
      Changelog: fixed
      0e77c181
  28. 3月 15, 2022
  29. 2月 21, 2022
  30. 2月 15, 2022
  31. 1月 21, 2022
    • Peter Leitzen's avatar
      Extract stub_settings_source into spec support file · bcb852e9
      Peter Leitzen 创作于
      Rename `stubbing_settings_source` to `stub_settings_source` to keep
      consistency across other support files.
      
      Require this support file in spec where `stub_settings_source: true` is
      used.
      
      This avoids order dependent flaky specs like:
      
        bin/rspec \
          spec/commands/sidekiq_cluster/cli_spec.rb \
          spec/lib/gitlab/pagination/offset_header_builder_spec.rb
      
      Note, both specs about are run with `fast_spec_helper` so previously
      they would fail because RSpec trait `stubbing_settings_source` was not
      available.
      bcb852e9
  32. 1月 04, 2022
  33. 12月 16, 2021
  34. 12月 08, 2021
  35. 11月 17, 2021
  36. 11月 08, 2021
  37. 9月 01, 2021
    • Sean McGivern's avatar
      Error on newlines in sidekiq-cluster arguments · 91e7b17c
      Sean McGivern 创作于
      When using Helm charts, which are YAML files, it's relatively easy to
      accidentally include a newline in the Sidekiq arguments. This will
      typically be a trailing newline, which shouldn't be a problem, except
      that in our cloud-native deployment we launch Sidekiq using the command
      given by `sidekiq-cluster --dryrun` (to avoid having the wrapper
      process), so we effectively do:
      
          $(bin/sidekiq-cluster --dryrun $ARGS)
      
      Ruby's `Shellwords.escape` quotes newlines as `'\n'`:
      https://github.com/ruby/shellwords/blob/v0.1.0/lib/shellwords.rb#L161-L163
      
      When those are parsed back in the arguments array we get `foo'\n'` for
      an original argument of `foo\n`. Then, when we apply splitting, we get
      `foo'` and `'` as two separate arguments.
      
      The quoting here is quite complicated but the below demonstrates (in
      Bash) what's happening:
      
          $ ruby -e 'p ARGV; p ARGV.first.split' "foo'"$'\n'"'"
          ["foo'\n'"]
          ["foo'", "'"]
      
      If we did care about newlines in this argument array, the solution would
      be more involved. But we don't, because they are never valid, so we can
      just error when we encounter them.
      
      Changelog: fixed
      91e7b17c
  38. 7月 29, 2021
    • Sean McGivern's avatar
      Add --list-queues option to sidekiq-cluster · c591bf77
      Sean McGivern 创作于
      The --dryrun option shows the full command sidekiq-cluster will run.
      This new option just lists the matched queues (mostly useful in
      conjunction with --queue-selector), one per line.
      c591bf77
  39. 5月 27, 2021
  40. 4月 19, 2021
加载中