Remove Settingslogic gem
- For better backward compatibility use string keys on GitlabSettings::Options - Remove all the Settingslogic references from code (not comments) - Ensure to use GitlabSettings::Options when pushing new options to Array values - Instead of inheriting from Hash, wrap a hash in GitlabSettings::Options and make it respond to all the requirements. * PROS: This provides more autonomy on what needs to be done * CONS: Some places were checking by Hash, we need to tackle these scenarios - Ensure to deep_merge return nested Options - Use the _raw_ version of options when passing to Fog::Storage - Ensure to load required active_support libraries - Show the option name in the GitlabSettings::MissingSetting error - Ensure to have an option `source` for the path of the `gitlab.yml` - Fix GitlabSettings::Options#deep_merge and GitlabSettings::Options#merge to return a new GitlabSettings::Options object with the options deep_merged/merged - Add GitlabSettings#reload! for backward compatibility - Make file/namespace initializer arguments - Avoid mutating Settings in sidekiq_cluster/cli tests - Fix configuration stubbing Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/286873
显示
- Gemfile 0 个添加, 3 个删除Gemfile
- Gemfile.lock 0 个添加, 2 个删除Gemfile.lock
- config/initializers/1_settings.rb 192 个添加, 194 个删除config/initializers/1_settings.rb
- config/object_store_settings.rb 5 个添加, 17 个删除config/object_store_settings.rb
- config/settings.rb 176 个添加, 178 个删除config/settings.rb
- config/smime_signature_settings.rb 1 个添加, 1 个删除config/smime_signature_settings.rb
- lib/banzai/filter/asset_proxy_filter.rb 1 个添加, 1 个删除lib/banzai/filter/asset_proxy_filter.rb
- lib/gitlab/consul/internal.rb 1 个添加, 1 个删除lib/gitlab/consul/internal.rb
- lib/gitlab/omniauth_initializer.rb 1 个添加, 1 个删除lib/gitlab/omniauth_initializer.rb
- lib/gitlab/prometheus/internal.rb 2 个添加, 2 个删除lib/gitlab/prometheus/internal.rb
- lib/gitlab/sidekiq_config.rb 3 个添加, 4 个删除lib/gitlab/sidekiq_config.rb
- lib/gitlab/tracking.rb 1 个添加, 1 个删除lib/gitlab/tracking.rb
- lib/gitlab/tracking/destinations/snowplow_micro.rb 1 个添加, 1 个删除lib/gitlab/tracking/destinations/snowplow_micro.rb
- lib/gitlab/url_blocker.rb 1 个添加, 2 个删除lib/gitlab/url_blocker.rb
- lib/gitlab_settings.rb 17 个添加, 0 个删除lib/gitlab_settings.rb
- lib/gitlab_settings/options.rb 80 个添加, 0 个删除lib/gitlab_settings/options.rb
- lib/gitlab_settings/settings.rb 37 个添加, 0 个删除lib/gitlab_settings/settings.rb
- lib/object_storage/direct_upload.rb 1 个添加, 1 个删除lib/object_storage/direct_upload.rb
- metrics_server/metrics_server.rb 1 个添加, 1 个删除metrics_server/metrics_server.rb
- spec/commands/metrics_server/metrics_server_spec.rb 1 个添加, 1 个删除spec/commands/metrics_server/metrics_server_spec.rb
加载中
想要评论请 注册 或 登录