Skip to content
代码片段 群组 项目
提交 c4d5c77c 编辑于 作者: Kassio Borges's avatar Kassio Borges 提交者: Stan Hu
浏览文件

Remove Settingslogic gem

- For better backward compatibility use string keys on
  GitlabSettings::Options
- Remove all the Settingslogic references from code (not comments)
- Ensure to use GitlabSettings::Options when pushing new options to
  Array values
- Instead of inheriting from Hash, wrap a hash in
  GitlabSettings::Options and make it respond to all the requirements.
    * PROS: This provides more autonomy on what needs to be done
    * CONS: Some places were checking by Hash, we need to tackle these
    scenarios
- Ensure to deep_merge return nested Options
- Use the _raw_ version of options when passing to Fog::Storage
- Ensure to load required active_support libraries
- Show the option name in the GitlabSettings::MissingSetting error
- Ensure to have an option `source` for the path of the `gitlab.yml`
- Fix GitlabSettings::Options#deep_merge and
  GitlabSettings::Options#merge to return a new GitlabSettings::Options
  object with the options deep_merged/merged
- Add GitlabSettings#reload! for backward compatibility
- Make file/namespace initializer arguments
- Avoid mutating Settings in sidekiq_cluster/cli tests
- Fix configuration stubbing

Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/286873
上级 d44c4532
No related branches found
No related tags found
无相关合并请求
显示
522 个添加411 个删除
加载中
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册