This adds the Performance/Rubyzip cop

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>

This fixes a few issues related to unexpected .ipynb structure,
mainly source being a single string rather than a list. /

Changelog: fixed

Signed-off-by: Rémy Coutable <remy@rymai.me>

Changelog: added

This means we can remove our patches to use pipelining instead of multi
and to use an atomic Lua scheduler, because both have been upstreamed!

Changelog: other

Signed-off-by: Rémy Coutable <remy@rymai.me>

Gitaly updated Rugged to v1.2.0 in
https://gitlab.com/gitlab-org/gitaly/-/merge_requests/3966, so to save
some space and installation time let's use the same version.

Changelog: changed

Signed-off-by: Rémy Coutable <remy@rymai.me>

This will bring in the Style/OpenStructUse cop.
All existing offense are silenced for now.

Changes are wrapped by feature flag jupyter_clean_diff.

On the commit folder, when detecting a ipynb file, creates a new diff
of those files after converting them to markdown, using the [ipynbdiff
gem](https://gitlab.com/gitlab-org/incubation-engineering/mlops/rb-ipynbdiff)

There are performance and architectural concerns on whether the rails
app is the right place for this type of diffing, but since we currently
don't have a good solution we are discussing possible alternatives for
the future here: https://gitlab.com/gitlab-org/gitlab/-/issues/342143.

Changelog: added
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/71477
Epic: https://gitlab.com/groups/gitlab-org/-/epics/6589

Signed-off-by: Rémy Coutable <remy@rymai.me>

This reverts merge request !73093

Upgrades sidekiq-cron and adds an explicit require for
sidekiq/job_logger and sidekiq/job_retry. Previously, these were loaded
by sidekiq-cron's launcher which is now refactored to only load the
Sidekiq classes when needed.

In a project with JIRA activated, `ProcessCommitWorker` attempts to add
a comment to a JIRA issue if that issue is mentioned in a
commit. However, the JIRA integration would attempt to retrieve all tags
and branches and pick the first matching ref given a commit OID.

The problem with that approach is that after each push, the list of all
branches and tags are expired and could take a while to gather. Since
multiple `ProcessCommitWorker` jobs can be running at the same time,
this can lead to high I/O on Gitaly nodes since multiple
`ProcessCommitWorker` jobs can run at the same time.

We observe that we don't really need to build the entire ref list; we
can just ask Gitaly for a single matching ref for the given OID with the
newly-created `FindRefsByOID` RPC introduced in
https://gitlab.com/gitlab-org/gitaly/-/merge_requests/3947.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/343035

Changelog: performance

See https://gitlab.com/gitlab-org/gitlab-dangerfiles/-/releases/v2.3.1

Changelog: other

This adds an optional gem sd_notify, which, when available, allows puma
to notify systemd about having finished its startup. This allows puma to
be Type=notify instead of Type=simple in its service file.

We attempted to load the gitlab-fog-azure-rm only if it was really
needed for object storage, but there are a number of cases where we
don't dynamically load these gems when we need them. To avoid the
complexity of this dynamic allocation, we now require the gem, just as
we do with other object storage providers. Unfortunately this adds 5 MB
to the RAM usage of the process according to derailed_benchmarks, but
this fairly typical for a gem for object storage.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/334853

Changelog: fixed

This MR updates Rails from 6.1.3.2 to 6.1.4.1

Changes:
rails: https://my.diffend.io/gems/rails/6.1.3.2/6.1.4.1
actionpack: https://my.diffend.io/gems/actionpack/6.1.3.2/6.1.4.1
activerecord: https://my.diffend.io/gems/activerecord/6.1.3.2/6.1.4.1
activestorage: https://my.diffend.io/gems/activestorage/6.1.3.2/6.1.4.1

Release notes:
https://github.com/rails/rails/releases

Upgrade to the latest version of Sidekiq

Prior to this commit, files downloaded in Azure Blob Storage would not
have a Content-Disposition header sent, which would cause files to be
saved with an unfriendly
filename. https://gitlab.com/gitlab-org/gitlab-fog-azure-rm/-/merge_requests/25
added support for retrieving this response header by requesting this in
the Azure shared access signature (SAS) token. We now patch CarrierWave
to send these custom options to the File object.

We drop the dynamic parameter check in the CarrierWave patch since we
have a fog-google version that supports the options. Plus, this dynamic
parameter doesn't work with mocks since the mocks don't copy the exactly
method signature.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/341061

Changelog: fixed

Changelog: changed

which fixes several issues, including a `w` being in
a footnote, and exposing the XML interface

Changelog: fixed

This adds Rails/IncludeUrlHelper

See https://gitlab.com/gitlab-org/gitlab/-/issues/340567

Upgrading the gem from `0.9.0` to `0.10.0` which contains just one
change to address our patch.

In preparation for the Ruby 3 upgrade, we should update
json to match the minimum gem version as specified by
the default gem:

https://stdgems.org/json/#gem-version

Which for Ruby 3.0 is 2.5.1.

This will otherwise lead to errors, since rubygems
will encounter conflicting gemspecs during require.

See https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6286

This upgrade properly supports regional STS endpoints as well as the
ability to set the minimum and maximum multipart chunk size.

Diff:
https://github.com/fog/fog-aws/compare/v3.9.0..v3.12.0

Changelog: fixed

Can be used to increase max SAML message size

Changelog: added
EE: true