The `DocumentationLinks` cop now matches its HAML lint counterpart and
even checks for more offenses. We are therefore ready to let
`DocumentationLinks` take precedence to check HAML files in addition to
Ruby files.

Following the first few steps of "Verify upcoming release
of gitlab-styles" from [Checklist][1].

Specifically, ran:
```console
$ bundle install && \
  bundle exec bundler-checksum init && \
  bundle install --gemfile Gemfile.next && \
  cp Gemfile.lock Gemfile.next.lock && \
  BUNDLE_GEMFILE=Gemfile.next bundle lock && \
  BUNDLE_GEMFILE=Gemfile.next bundle exec bundler-checksum init && \
  bundle exec rubocop
...
41153 files inspected, 127 offenses detected, 124 offenses autocorrectable
```

[1]: https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/merge_request_templates/New%20Version%20of%20gitlab-styles.md#checklist

We've moved RuboCop TODO's to `.rubocop_todo/**/*.yml` over an year ago
and it's not been used ever since then.

Showing the progress (`.`) in CI does not provide any value and wastes
CPU and storage resources.

Dots are still shown in local environments (when `CI` is not `1`) or
when overridden by `--format <something else>` on the command line.

This is related to https://gitlab.com/gitlab-org/gitlab/-/issues/516113
where we discovered that many cops are not being applied to files in the
`ee/` directory.

This MR simply fixes that for `Cop/ActiveRecordDependent` so that we
don't continue adding violations and adds a `rubocop:disable` for all
the existing violations.

Moves the `Gitlab/DocUrl` cop to the
`Gitlab/DocumentationLinks/HardcodedUrl` namespace.

Implement RuboCop rule to prevent misuse of allow_access_with_scope
method. This ensures the method is only used at the class level, not
nested in namespaces. Because, if this method is called multiple times
on the same class, the scopes are all aggregated

Changelog: other

We'll enable this cop after fixing all the offenses.

We've stopped support for Ruby 3.1 some time ago.

- more helpful UX for the user.
- only deny if the namespace_id is provided and is not
  eligible. Otherwise do not observe access denied as
  this trials path can create trials also

Changelog: other
EE: true

This speeds up RuboCop file lookups because it has to match ~380 files
less.

It also removes BackfillIntegrationsTypeNew which was part of
.rubocop_revert_ignores.txt, caused RuboCop offenses but is not used
since 2023.

This speeds up RuboCop matching files because we have less patterns.

- db/schema.rb was removed in 2022
- plugins/ was removed in 2021
- db/ci_migrate was removed in 2021

We disabled it since we needed to support Ruby 3.0.
We now only need to support Ruby 3.1.

Generate TODOs and put this cop rule in grace period to ensure master
stability.

Changelog: other

- placing an ee only class under an ee/**/ee subdirectory
  is not the right placement and we should alert on it.
- see https://docs.gitlab.com/ee/development/ee_features.html#extend-ce-features-with-ee-backend-code
- see https://gitlab.com/gitlab-org/gitlab/-/issues/378167

- centralize on gitlab_subscriptions as a module vs
  subscriptions
- see https://gitlab.com/gitlab-org/gitlab/-/issues/461877

- solve for the case of only 1 eligible namespace.
- guard with feature flag to control rollout.
- see https://gitlab.com/gitlab-org/gitlab/-/issues/468050

This commit adds a new RuboCop rule `Gitlab/NoFindInWorkers` to prevent
the use of `.find` in workers. It also enabled "grace period" and generated TODOs.

Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Changelog: changed

We're using the housekeeper gem here to generate the `.rubocop_todo`
files and create an MR.

Run `bundle exec gitlab-housekeeper -d -k Keeps::GenerateRubocopTodos`
to test out the changes locally.

Fix rule names

Add missing rules keyword

Use absolute path for qa bundle path

Fix cng patterns path

- Moving to get closer to consolidating on gitlab_subscriptions
  when referring to subscriptions in the app.
- move controller, routes and affected tests to follow
  some convention and increase findability.
- see https://gitlab.com/gitlab-org/gitlab/-/issues/461873

Here we're moving the Include param that specifies the list of files
where a cop should run. The param was not working because it should
reside in the `.rubocop.yml` file and not in the rubocop todo file.

I have checked for other such instance and there are not any.

Instead of using a double negative @splattael suggested matching on
all params, ehn permitting when params is used safely.

With that we could simplify the node pattern while making the cop rule
faster and perhaps more secure. There's no special case made for methods
like page, per, puts, has_key, etc.

The downside is the number of rubocop exceptions when from 225 to 379.

Changelog: changed

Fix outstanding cop conflicts
Make feature_flag metadat name key required

The todo file was not including some files where constants
were declared in the compact form `class SomeModule::SomeClass`.
We could have missed to regenerate the todo file after some
changes in the cop's logic.

Added a spec example to ensure we are covering for the compact
version.

- See https://gitlab.com/gitlab-org/gitlab/-/issues/456132

Instead of running migrations in integer version order, we will run
migrations in milestone order, using the 'milestone' parameter added to
migrations.

Changelog: added

Signed-off-by: Rémy Coutable <remy@rymai.me>

This primarily affects MailDeliveryJob enqueues by ActionMailer.

Changelog: other

Signed-off-by: Nailia Iskhakova <niskhakova@gitlab.com>