Skip to content
代码片段 群组 项目
未验证 提交 eb1eeef7 编辑于 作者: Peter Leitzen's avatar Peter Leitzen 提交者: GitLab
浏览文件

Enable Tailwind/StringInterpolation cop rule

Generate TODOs and put this cop rule in grace period to ensure master
stability.
上级 0f5e3161
No related branches found
No related tags found
无相关合并请求
...@@ -1235,3 +1235,10 @@ Gitlab/NoFindInWorkers: ...@@ -1235,3 +1235,10 @@ Gitlab/NoFindInWorkers:
Include: Include:
- app/workers/**/* - app/workers/**/*
- ee/app/workers/**/* - ee/app/workers/**/*
Tailwind/StringInterpolation:
Enabled: true
Include:
- '{,ee/,jh/}app/helpers/**/*.rb'
- '{,ee/,jh/}app/components/**/*.{haml,rb}'
- '{,ee/,jh/}app/views/**/*.haml'
...@@ -29,7 +29,7 @@ def initialize( ...@@ -29,7 +29,7 @@ def initialize(
end end
def base_class def base_class
classes = ["gl-alert-#{@variant}"] classes = ["gl-alert-#{@variant}"] # rubocop:disable Tailwind/StringInterpolation -- Not a CSS utility class
classes.push('gl-alert-not-dismissible') unless @dismissible classes.push('gl-alert-not-dismissible') unless @dismissible
classes.push('gl-alert-no-icon') unless @show_icon classes.push('gl-alert-no-icon') unless @show_icon
classes.push('gl-alert-has-title') if @title classes.push('gl-alert-has-title') if @title
...@@ -48,7 +48,7 @@ def icon ...@@ -48,7 +48,7 @@ def icon
end end
def icon_classes def icon_classes
"gl-alert-icon#{' gl-alert-icon-no-title' if @title.nil?}" "gl-alert-icon#{' gl-alert-icon-no-title' if @title.nil?}" # rubocop:disable Tailwind/StringInterpolation -- Not a CSS utility class
end end
def dismissible_button_options def dismissible_button_options
......
...@@ -27,7 +27,7 @@ def initialize(item, alt: nil, class: "", size: 64, avatar_options: {}) ...@@ -27,7 +27,7 @@ def initialize(item, alt: nil, class: "", size: 64, avatar_options: {})
private private
def avatar_classes def avatar_classes
classes = ["gl-avatar", "gl-avatar-s#{@size}", @class] classes = ["gl-avatar", "gl-avatar-s#{@size}", @class] # rubocop:disable Tailwind/StringInterpolation -- Not a CSS utility class
if @item.is_a?(User) || @item.is_a?(AvatarEmail) if @item.is_a?(User) || @item.is_a?(AvatarEmail)
classes.push("gl-avatar-circle") classes.push("gl-avatar-circle")
else else
...@@ -36,7 +36,7 @@ def avatar_classes ...@@ -36,7 +36,7 @@ def avatar_classes
unless src unless src
classes.push("gl-avatar-identicon") classes.push("gl-avatar-identicon")
classes.push("gl-avatar-identicon-bg#{((@item.id || 0) % 7) + 1}") classes.push("gl-avatar-identicon-bg#{((@item.id || 0) % 7) + 1}") # rubocop:disable Tailwind/StringInterpolation -- Not a CSS utility class
end end
classes.join(' ') classes.join(' ')
......
...@@ -20,7 +20,9 @@ def initialize(color: :dark, inline: false, label: _("Loading"), size: :sm, **ht ...@@ -20,7 +20,9 @@ def initialize(color: :dark, inline: false, label: _("Loading"), size: :sm, **ht
private private
def spinner_class def spinner_class
# rubocop:disable Tailwind/StringInterpolation -- Not a CSS utility class
["gl-spinner", "gl-spinner-#{@size}", "gl-spinner-#{@color} !gl-align-text-bottom"] ["gl-spinner", "gl-spinner-#{@size}", "gl-spinner-#{@color} !gl-align-text-bottom"]
# rubocop:enable Tailwind/StringInterpolation
end end
def html_options def html_options
......
...@@ -414,7 +414,7 @@ def read_only_message ...@@ -414,7 +414,7 @@ def read_only_message
end end
def client_class_list def client_class_list
"gl-browser-#{browser_id} gl-platform-#{platform_id}" "gl-browser-#{browser_id} gl-platform-#{platform_id}" # rubocop:disable Tailwind/StringInterpolation -- Not a CSS utility class
end end
def client_js_flags def client_js_flags
......
...@@ -84,7 +84,7 @@ def gl_loading_icon(inline: false, color: 'dark', size: 'sm', css_class: nil, da ...@@ -84,7 +84,7 @@ def gl_loading_icon(inline: false, color: 'dark', size: 'sm', css_class: nil, da
end end
def external_snippet_icon(name) def external_snippet_icon(name)
content_tag(:span, "", class: "gl-snippet-icon gl-snippet-icon-#{name}") content_tag(:span, "", class: "gl-snippet-icon gl-snippet-icon-#{name}") # rubocop:disable Tailwind/StringInterpolation -- Not a CSS utility class
end end
def audit_icon(name, css_class: nil) def audit_icon(name, css_class: nil)
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册