I'm not sure why the link was set up this way! A relic of something
from years ago? Let's fix this weird, strange old link so we can
spider this page with a more modern link-checking program.

Repoint everything to its new location.

This allows our linters to properly ignore the content within them.

- todo files should not be added to. They are meant for
  eventually resolving, not as a forever list of exceptions.

Slash command classes are used by the GitLab for Slack app,
Slack Slash Commands, and Mattermost Slash Commands integrations. This
change updates Roulette to recommend a review from Import and Integrate
when files in this directory are changed.

* Run CI job per supported Ruby version.
* Use the much faster RubyVM::InstructionSequence.compile

Spawning Ruby processes is expensive and RubyVM::InstructionSequence.compile
provides the same functionality (minus warnings).

* Add Rakefile again and adjust specs
* CI: Run ruby_syntax job in preflight stage

Updates the script to use the new tier badging we just rolled out,
and updates the output file too.

These dictionary entries have evolved to include more than
just documentation (for example, defining sharding keys),
so changes should now require a database review.

When a file in the documentation is moved, the old
path was also passed to markdownlint and vale.
That causes the linting to fail, because the files
don't exist.

In order to fix that, the new option will only return
the new paths of the changed files and not the old paths.

- handle scenarios seen in updated spec tests in this MR

- similar to update, destroy, etc, this method should require
  database review

- auto generate custom roles abilities doc using rake task

Stan Hu 创作于 1 year ago ，Lin Jen-Shin 提交于 1 year ago

This commit fixes two types of Rubocop failures seen only with Ruby 3.2:

* Style/ArgumentsForwarding: As explained in
  https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/ArgumentsForwarding,
  in Ruby 3.2, anonymous args/kwargs forwarding has been added. This cop can
  be disabled by setting `UseAnonymousForwarding: false`.

* Lint/RedundantRequireStatement: As explained in
  https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/RedundantRequireStatement,
  `require 'set'` is no longer needed in Ruby 3.2. But since we still
  need to support Ruby 3.1 and earlier, disable this cop on `require 'set'`
  lines.

Relates to
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140815#note_1712305597

Starting Coverage twice can cause errors in Ruby 3.1 and Ruby 3.2

The error looks like this:

```
An error occurred while loading spec_helper.
Failure/Error: config.register
Tooling::Crystalball::CoverageLinesStrategy.new(execution_detector)
RuntimeError:
  coverage measurement is already setup
  ./tooling/lib/tooling/crystalball/coverage_lines_strategy.rb:19:in
`start'
  ./tooling/lib/tooling/crystalball/coverage_lines_strategy.rb:19:in
`after_register'
```

This only happens when all the following conditions meet:

* SIMPLECOV=true
* CRYSTALBALL=true
* Ruby 3.1 or Ruby 3.2

This means it hits mostly only in scheduled pipelines on the default
branch because we set CRYSTALBALL=true for that.

Refactor parameter list syntax for improved readability, replacing the
final comma with 'and'.

Changelog: changed

Signed-off-by: Lucas Zampieri <lzampier@redhat.com>

Allows pausing Sidekiq jobs when a ClickHouse migration is running

David Dieulivol 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

It makes it easier to look up the expected time
the spec should take.

Update the links in code and autogenerated docs

Move duration to a new rspec formatter

Improve timer output

Print expected duration in job log

This gem was mainly used to compile PO files to JSON.
This usage has been removed with:
- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115042

JiHu seems to have adopted this with:
- !1614

So we can safely remove the gem.

There are multiple `e2e:packag-and-test` pipelines, including
`follow-up-e2e:package-and-test-ee`. This MR updates the stable branch
tooling logic to search for an exact match to prevent false positives in
Danger.

Inspired by the ActiveRecord migration classes

Niklas 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

The git approach causes some problems with wrong change
detections. Switching the logic to use Tooling::FindChanges
will detect the file changes with the API.

Changelog: other

remove trailing white space

update tests

remove comment

Previously, we were using `forwardable` but it emitted a mysterious
warning:
  forwarding to private method Danger::Rubocop#helper

The reason is unknown because `helper` is a public method.

As a workaround we are switching to hand-made delegates.