This new ~/lib/utils/mousetrap file is similar to
~/lib/utils/axios_utils, in that it augments the raw package.

In particular, it makes it slightly easier to update Mousetrap's
`stopCallback` method.

They `Shortcut#addStopCallback` is an instance method rather than static
methods to encourage access via the (in theory) singleton Shortcuts
instance.

A problem this does not solve is the race between our overwriting of
`Mousetrap#stopCallback` and the `pause` plugin's overwriting of it:
https://github.com/ccampbell/mousetrap/blob/1.6.5/plugins/pause/mousetrap-pause.js#L10-L18.

If the `pause` plugin is loaded first, then our subsequent overwrites
will no longer be subject to the paused status of Mousetrap.

The bulk import path rename was done using this command:

    comby "import :[[name]] from 'mousetrap';" \
        "import :[name] from '~/lib/utils/mousetrap';" \
        {ee/,}{spec/frontend,app/assets/javascripts}/**/*.{js,vue} -i

See https://comby.dev/ for details about comby.

Finally, a redundant Mousetrap Jest mock has been removed, as the
package has provided a CommonJS module since v1.5.0:
https://github.com/ccampbell/mousetrap/releases/tag/1.5.0

These encapsulate the logic to call keysFor and Mousetrap.bind. This
will allow for simpler calls in Shortcuts and its subclasses.

They are instance methods rather than static methods to encourage access
via the (in theory) singleton Shortcuts instance.

The call refactoring was partially implemented using this command:

    comby "Mousetrap.bind(keysFor(:[[command]]), :[callback]);" \
        "[:[command], :[callback]]," \
        {ee/,}app/assets/javascripts/behaviors/shortcuts/*.js

See https://comby.dev/ for details about comby.

The actual calls to `this.bindCommand(s)` were then done by hand, along
with some minor code rearrangement in the Shortcuts constructor.

- Only instantiate Shortcuts once, since constructing it has side
  effects, and there's no teardown method.
- Spy on Mousetrap methods instead of mocking it entirely. It turns out
  that the stopCallback tests weren't passing for the right reason as
  a result. (There's a difference between the global Mousetrap instance
  and the one set up for Shortcuts#initMarkdownEditorShortcuts`.)
- Rename `shortcuts` variable to more explicit `shortcutElements`.

- The skipResetBindings constructor parameter was removed in
  4ee29e89, so all related code can be
  removed.
- The ShortcutsEpic.openSidebarDropdown static method's only parameter
  was removed in
  https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75302, so
  there's no point passing anything to it.
- The ShortcutsTestCase.openSidebarDropdown static method never expected
  any parameters since creation in
  https://gitlab.com/gitlab-org/gitlab/-/merge_requests/109527, so
  there's no point passing anything to it.

The `.js-more-help-button` element was removed nearly three years ago in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/34660, so this
event listener will never get called.

Move prerequisites for GitLab for Jira Cloud

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118458



Merged-by: Jon Glassman <jglassman@gitlab.com>
Approved-by: Jon Glassman <jglassman@gitlab.com>
Co-authored-by: Ashraf Khamis <akhamis@gitlab.com>

Move deprecation announcement to REST API v5 deprecation announcements

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118171



Merged-by: Manoj M J <mmj@gitlab.com>
Approved-by: Manoj M J <mmj@gitlab.com>
Reviewed-by: Manoj M J <mmj@gitlab.com>
Co-authored-by: Lorena Ciutacu <lciutacu@gitlab.com>
Co-authored-by: Christina Lohr <clohr@gitlab.com>

Fix roadmap_filters_spec

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118394



Merged-by: Miguel Rincon <mrincon@gitlab.com>
Approved-by: Lorenz van Herwaarden <lvanherwaarden@gitlab.com>
Approved-by: Miguel Rincon <mrincon@gitlab.com>
Reviewed-by: Lorenz van Herwaarden <lvanherwaarden@gitlab.com>
Co-authored-by: Samantha Ming <sming@gitlab.com>

Improve Vale's CIConfigFile rule to catch previous false negatives

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118426



Merged-by: Marcel Amirault <mamirault@gitlab.com>
Approved-by: Russell Dickenson <rdickenson@gitlab.com>
Approved-by: Marcel Amirault <mamirault@gitlab.com>
Co-authored-by: Jonston Chan <jonstonchan1@gmail.com>

Allow access to project-level package files API with CI job token

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/116059



Merged-by: David Fernandez <dfernandez@gitlab.com>
Approved-by: Radamanthus Batnag <rbatnag@gitlab.com>
Approved-by: David Fernandez <dfernandez@gitlab.com>
Reviewed-by: David Fernandez <dfernandez@gitlab.com>
Reviewed-by: Ruby Nealon <rnealon@gitlab.com>
Reviewed-by: Radamanthus Batnag <rbatnag@gitlab.com>
Co-authored-by: Jordan Doyle <jordan@doyle.la>

Update label styling

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118371



Merged-by: Vitaly Slobodin <vslobodin@gitlab.com>
Approved-by: Alex Pennells <apennells@gitlab.com>
Approved-by: Gina Doyle <gdoyle@gitlab.com>
Approved-by: Vitaly Slobodin <vslobodin@gitlab.com>
Co-authored-by: Annabel Dunstone Gray <annabel.dunstone@gmail.com>

Move the context switcher to a disclosure dropdown

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118217



Merged-by: Vitaly Slobodin <vslobodin@gitlab.com>
Approved-by: Artur Fedorov <afedorov@gitlab.com>
Approved-by: Austin Regnery <aregnery@gitlab.com>
Approved-by: Vitaly Slobodin <vslobodin@gitlab.com>
Reviewed-by: Paul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
Reviewed-by: Artur Fedorov <afedorov@gitlab.com>
Co-authored-by: Paul Gascou-Vaillancourt <paul.gascvail@gmail.com>

Paul Gascou-Vaillancourt 创作于 1 year ago ，Vitaly Slobodin 提交于 1 year ago

This drops the `GlCollapse`-based context switcher in favor of a
`GlDisclosureDropdown` solution. This aligns with most recent design
decisions to make the context switcher stand out more.

Improve Available audit events - Group events

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117744



Merged-by: Evan Read <eread@gitlab.com>
Approved-by: Evan Read <eread@gitlab.com>
Co-authored-by: Russell Dickenson <rdickenson@gitlab.com>
Co-authored-by: Claromes <claromes@hey.com>

Add support for the embedding database

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118156



Merged-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: Simon Tomlinson <stomlinson@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Reviewed-by: Thong Kuah <tkuah@gitlab.com>
Reviewed-by: Matt Kasa <mkasa@gitlab.com>
Reviewed-by: Terri Chu <tchu@gitlab.com>
Reviewed-by: Simon Tomlinson <stomlinson@gitlab.com>
Co-authored-by: Matt Kasa <mkasa@gitlab.com>

Fix Layout/ArgumentAlignment offenses in ee/lib/ee/api

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118313



Merged-by: Mark Chao <mchao@gitlab.com>
Approved-by: Michał Zając <mzajac@gitlab.com>
Approved-by: Mark Chao <mchao@gitlab.com>
Reviewed-by: Michał Zając <mzajac@gitlab.com>
Co-authored-by: Vitali Tatarintev <vtatarintev@gitlab.com>

Docs: Edit Secret Detection intro, clarify detection scope

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118380



Merged-by: Russell Dickenson <rdickenson@gitlab.com>
Approved-by: Russell Dickenson <rdickenson@gitlab.com>
Approved-by: Lorena Ciutacu <lciutacu@gitlab.com>
Co-authored-by: Connor Gilbert <cgilbert@gitlab.com>

Revert "Merge branch 'remove-invalid-codeonwers-rules' into 'master'"

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118455



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Stan Hu <stanhu@gmail.com>
Co-authored-by: Marcel Amirault <mamirault@gitlab.com>

This reverts merge request !118414

Fix hard-coded path in specs

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118451



Merged-by: Shinya Maeda <shinya@gitlab.com>
Approved-by: Shinya Maeda <shinya@gitlab.com>
Co-authored-by: Thong Kuah <tkuah@gitlab.com>

Update Gitaly version

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118292



Merged-by: release-tools approver bot <project278964_bot6@example.com>
Approved-by: release-tools approver bot <project278964_bot6@example.com>
Co-authored-by: GitLab Release Tools Bot <delivery-team+release-tools@gitlab.com>

Show the Trial Status widget in the super sidebar

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117927



Merged-by: Alexander Turinske <aturinske@gitlab.com>
Approved-by: Miranda Fluharty <mfluharty@gitlab.com>
Approved-by: Sam Kim <skim@gitlab.com>
Approved-by: Gina Doyle <gdoyle@gitlab.com>
Approved-by: Alexander Turinske <aturinske@gitlab.com>
Reviewed-by: Paul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
Co-authored-by: Paul Gascou-Vaillancourt <paul.gascvail@gmail.com>

This adds the ability for the Trial Status widget to show up in the
super sidebar.

Changelog: fixed

ci: Remove invalid CODEOWNERS rules and reduce duplication

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118414



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Stan Hu <stanhu@gmail.com>
Reviewed-by: Rémy Coutable <remy@rymai.me>
Co-authored-by: Rémy Coutable <remy@rymai.me>

Also:

- Moves geo database docs to ee/db/geo/docs/
- Adds support for embedding database docs in ee/db/embedding/docs/

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/404396

Use a friendlier error message when wiki repository is broken

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117270



Merged-by: John Mason <9717668-john-mason@users.noreply.gitlab.com>
Approved-by: Rudy Crespo <rcrespo@gitlab.com>
Approved-by: Aakriti Gupta <agupta@gitlab.com>
Approved-by: Anna Vovchenko <avovchenko@gitlab.com>
Approved-by: John Mason <9717668-john-mason@users.noreply.gitlab.com>
Reviewed-by: Kassio Borges <kborges@gitlab.com>
Reviewed-by: Aakriti Gupta <agupta@gitlab.com>
Co-authored-by: ngala <ngala@gitlab.com>
Co-authored-by: Kassio Borges <kassioborgesm@gmail.com>

Changelog: fixed

Whats new for 15.11

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118110



Merged-by: Mayra Cabrera <mcabrera@gitlab.com>
Approved-by: Justin Farris <jfarris@gitlab.com>
Approved-by: Mayra Cabrera <mcabrera@gitlab.com>
Co-authored-by: Melissa Ushakov <mushakov@gitlab.com>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Include e2e on GDK in scheduled pipelines

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117979



Merged-by: Rémy Coutable <remy@rymai.me>
Approved-by: Nao Hashizume <nhashizume@gitlab.com>
Approved-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Mark Lapierre <mlapierre@gitlab.com>
Reviewed-by: Nao Hashizume <nhashizume@gitlab.com>
Co-authored-by: Mark Lapierre <mlapierre@gitlab.com>

Include first multiline commit in MR description for default template

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118413



Merged-by: Rémy Coutable <remy@rymai.me>
Approved-by: Rémy Coutable <remy@rymai.me>
Co-authored-by: Stan Hu <stanhu@gmail.com>

Set approval rule as invalid if there are not enough approvers

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117557



Merged-by: Gary Holtz <gholtz@gitlab.com>
Approved-by: Dominic Bauer <dbauer@gitlab.com>
Approved-by: Gary Holtz <gholtz@gitlab.com>
Co-authored-by: Martin Čavoj <mcavoj@gitlab.com>

A rule is already marked as invalid if there are no approvers.
This change also marks it as invalid if there are some approvers,
but less than the number of required approvals.

Changelog: changed
EE: true