refactor: Extract Mousetrap util file
This new ~/lib/utils/mousetrap file is similar to ~/lib/utils/axios_utils, in that it augments the raw package. In particular, it makes it slightly easier to update Mousetrap's `stopCallback` method. They `Shortcut#addStopCallback` is an instance method rather than static methods to encourage access via the (in theory) singleton Shortcuts instance. A problem this does not solve is the race between our overwriting of `Mousetrap#stopCallback` and the `pause` plugin's overwriting of it: https://github.com/ccampbell/mousetrap/blob/1.6.5/plugins/pause/mousetrap-pause.js#L10-L18. If the `pause` plugin is loaded first, then our subsequent overwrites will no longer be subject to the paused status of Mousetrap. The bulk import path rename was done using this command: comby "import :[[name]] from 'mousetrap';" \ "import :[name] from '~/lib/utils/mousetrap';" \ {ee/,}{spec/frontend,app/assets/javascripts}/**/*.{js,vue} -i See https://comby.dev/ for details about comby. Finally, a redundant Mousetrap Jest mock has been removed, as the package has provided a CommonJS module since v1.5.0: https://github.com/ccampbell/mousetrap/releases/tag/1.5.0
显示
- .eslintrc.yml 5 个添加, 0 个删除.eslintrc.yml
- app/assets/javascripts/authentication/two_factor_auth/components/recovery_codes.vue 1 个添加, 1 个删除...hentication/two_factor_auth/components/recovery_codes.vue
- app/assets/javascripts/behaviors/shortcuts/shortcuts.js 15 个添加, 10 个删除app/assets/javascripts/behaviors/shortcuts/shortcuts.js
- app/assets/javascripts/behaviors/shortcuts/shortcuts_find_file.js 3 个添加, 6 个删除...ts/javascripts/behaviors/shortcuts/shortcuts_find_file.js
- app/assets/javascripts/behaviors/shortcuts/shortcuts_toggle.js 1 个添加, 1 个删除...ssets/javascripts/behaviors/shortcuts/shortcuts_toggle.js
- app/assets/javascripts/design_management/components/toolbar/design_navigation.vue 1 个添加, 2 个删除...esign_management/components/toolbar/design_navigation.vue
- app/assets/javascripts/design_management/pages/design/index.vue 1 个添加, 1 个删除...sets/javascripts/design_management/pages/design/index.vue
- app/assets/javascripts/diffs/components/app.vue 1 个添加, 1 个删除app/assets/javascripts/diffs/components/app.vue
- app/assets/javascripts/docs/docs_bundle.js 1 个添加, 1 个删除app/assets/javascripts/docs/docs_bundle.js
- app/assets/javascripts/jobs/components/job/sidebar/stages_dropdown.vue 1 个添加, 1 个删除...vascripts/jobs/components/job/sidebar/stages_dropdown.vue
- app/assets/javascripts/lib/utils/mousetrap.js 46 个添加, 0 个删除app/assets/javascripts/lib/utils/mousetrap.js
- app/assets/javascripts/monitoring/components/dashboard.vue 1 个添加, 1 个删除app/assets/javascripts/monitoring/components/dashboard.vue
- app/assets/javascripts/notes/components/discussion_navigator.vue 1 个添加, 2 个删除...ets/javascripts/notes/components/discussion_navigator.vue
- app/assets/javascripts/super_sidebar/components/super_sidebar.vue 1 个添加, 1 个删除...ts/javascripts/super_sidebar/components/super_sidebar.vue
- app/assets/javascripts/vue_shared/components/file_finder/index.vue 4 个添加, 6 个删除...s/javascripts/vue_shared/components/file_finder/index.vue
- app/assets/javascripts/zen_mode.js 1 个添加, 1 个删除app/assets/javascripts/zen_mode.js
- spec/frontend/__mocks__/mousetrap/index.js 0 个添加, 6 个删除spec/frontend/__mocks__/mousetrap/index.js
- spec/frontend/design_management/components/toolbar/design_navigation_spec.js 1 个添加, 2 个删除...n_management/components/toolbar/design_navigation_spec.js
- spec/frontend/diffs/components/app_spec.js 1 个添加, 1 个删除spec/frontend/diffs/components/app_spec.js
- spec/frontend/jobs/components/job/stages_dropdown_spec.js 1 个添加, 1 个删除spec/frontend/jobs/components/job/stages_dropdown_spec.js
加载中
想要评论请 注册 或 登录