They did things [0], I debugged things and wrote probably horrible ruby
code along the way.

[0]: https://github.com/rubygems/rubygems/pull/7678

Sidekiq and GitLab promise each job runs *at least once*. They
do not promise that each job runs exactly once.

Changelog: changed

This test is failing as per issue
https://gitlab.com/gitlab-org/quality/engineering-productivity/master-broken-incidents/-/issues/6939
Looks like a flaky test, hence quarantining for now

Changelog: fixed

Changelog: changed

Move them into a separate so it can be included by templates or
projects.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Contributes to
https://gitlab.com/gitlab-org/project-templates/express/-/issues/14

Changelog: other

One of the Sidekiq Web UI test attempts to test that the latency shown
in the queues page is 0.0. However, if there is some slowness on the
runner the latency could tick up to a second, causing the test to
fail.

Avoid this flakiness by stubbing `Time.now` so that we guarantee that
the latency will always remain at 0.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/460842

Signed-off-by: Rémy Coutable <remy@rymai.me>

Closes https://gitlab.com/gitlab-org/gitlab/-/issues/407398

Changelog: removed

Changelog: changed

RubyGems 3.5.6 dropped `Bundler::URI` in favor of a vendored `Gem::URI`:
https://github.com/rubygems/rubygems/pull/7386

As a result, if you attempt to run bundle exec bundler-checksum init
on a system with RubyGems 3.5.6, it will fail with an `undefined
method` error.

Changelog: fixed

This ensures that `data` is defined in the vendored
jquery.endless-scroll. This fixes a bug where endless scroll would not
work in development when using Vite instead of Webpack.

This should now pass since we've dropped DataMapper support.

This pulls in
https://github.com/attr-encrypted/attr_encrypted/pull/439. Removing
this support allows tests to pass with Ruby 3.2.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/409397

We vendored Sidekiq in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143563 to
fix Redis 6.0 compatibility. However, we should test our changes
against Redis 6.2 and 7.0 to ensure we didn't break anything.

We vendored Sidekiq in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142986.
However, in Cloud Native GitLab, `git` isn't present, and the Git data
isn't available, so we cannot rely on this.

This first commit vendors the sidekiq 7.1.6 gem for clearer
separation.

Changelog: fixed

Changelog: changed

Bundler v2.5.0 introduced a CHECKSUMS section in Gemfile.lock and
significantly refactored checksums into `Bundler::Checksum`.  The
refactoring dropped the `Bundler::RubyGemsGemInstaller#checksum_type`
method, causing pre-install checks to fail with `NoMethodError:
undefined method 'checksum_type'` as seen in
https://gitlab.com/gitlab-org/gitlab/-/jobs/5861840560.

This commit fixes the digest comparison to use the digest set
in `Bundler::Checksum`. This change needs to be backwards
compatible with Bundler v2.4.x until we require v2.5.x.

Changelog: fixed

If you had date v3.3.4 installed, Puma and Sidekiq would not start
due to this error message:

```
`check_for_activated_spec!': You have already activated date
 3.3.4, but your Gemfile requires date 3.3.3. Prepending `bundle
exec` to your command may solve this. (Gem::LoadError)
```

This occurred because the `require 'date'` inside
`vendor/gems/attr_encrypted/attr_encrypted.gemspec` caused
Ruby to load the latest version of `date`, but then this conflicts
with the version specified in `Gemfile.lock`.

To avoid this problem, drop the use of the date in the gemspec.

Changelog: other

Stan Hu 创作于 1 year ago ，Lin Jen-Shin 提交于 1 year ago

This commit fixes two types of Rubocop failures seen only with Ruby 3.2:

* Style/ArgumentsForwarding: As explained in
  https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/ArgumentsForwarding,
  in Ruby 3.2, anonymous args/kwargs forwarding has been added. This cop can
  be disabled by setting `UseAnonymousForwarding: false`.

* Lint/RedundantRequireStatement: As explained in
  https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/RedundantRequireStatement,
  `require 'set'` is no longer needed in Ruby 3.2. But since we still
  need to support Ruby 3.1 and earlier, disable this cop on `require 'set'`
  lines.

Relates to
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140815#note_1712305597

Bundler v2.5.0 added a `gem_remote_fetcher` argument in
`Bundler::Fetcher::Base` in
https://github.com/rubygems/rubygems/pull/7092. We need to add that
extra argument conditionally to make `bundler exec bundle checksum
init` work again.

This error was first seen by the Renovate bot in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140597.

Changelog: fixed

Add the job class name when it is re-enqueued.

Changelog: changed

In 2021 on GitLab.com, we increased this timeout from 2 to 5 seconds
to reduce the CPU utilization incurred by Sidekiq jobs waiting for a
Redis BRPOP command to return
(https://gitlab.com/gitlab-com/gl-infra/production/-/issues/4052,
https://github.com/sidekiq/sidekiq/issues/4855). Since the number of
queues has increased from 440 to over 650 in the last two years,
BRPOPs have gotten increasingly expensive if they are watching all
650+ queues.  Increasing this timeout significant reduces CPU
utilization, so let's make this the default.

Changed: performance

This commit solves: https://gitlab.com/gitlab-org/gitlab/-/issues/429033
It fixes an Issue where the Findings Dropdown did not correctly
overlap the file underneath on the Merge-Request Diff Page.

Changelog: fixed