New method verifies all the necessary fields are set for removed metrics

Fix Lint/AmbiguousOperatorPrecedence 8 offenses

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/151162



Merged-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: Andrew Evans <aevans@gitlab.com>
Co-authored-by: Archish <archishthakkar@gmail.com>

Changelog: other

Remove extra informaton about policy scoping in policy editor

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/152252



Merged-by: Alexander Turinske <aturinske@gitlab.com>
Approved-by: Alexander Turinske <aturinske@gitlab.com>
Reviewed-by: Artur Fedorov <afedorov@gitlab.com>
Co-authored-by: Alan (Maciej) Paruszewski <mparuszewski@gitlab.com>

Remove all code related to clusters/integrations

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153086



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Arpit Gogia <12347103-arpitgogia@users.noreply.gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Pam Artiaga <partiaga@gitlab.com>

This was used for Prometheus integration through the certificate-based
cluster: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/55244
The related UI has been remove completely:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/122043
So we can now remove this unused backend code.

Changelog: removed

Reset project counters after relation import

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153261



Merged-by: Alper Akgun <aakgun@gitlab.com>
Approved-by: Abhilash Kotte <akotte@gitlab.com>
Approved-by: Alper Akgun <aakgun@gitlab.com>
Co-authored-by: James Nutt <jnutt@gitlab.com>

Fix query in User#authorized_groups

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153205



Merged-by: Leonardo da Rosa <ldarosa@gitlab.com>
Approved-by: Juliet Wanjohi <jwanjohi@gitlab.com>
Approved-by: Vitali Tatarintev <vtatarintev@gitlab.com>
Approved-by: Smriti Garg <sgarg@gitlab.com>
Approved-by: Leonardo da Rosa <ldarosa@gitlab.com>
Reviewed-by: Heinrich Lee Yu <heinrich@gitlab.com>
Reviewed-by: Leonardo da Rosa <ldarosa@gitlab.com>
Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com>

Fix approval policy to include group level protected branch

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153240



Merged-by: Marcos Rocha <mrocha@gitlab.com>
Approved-by: Dominic Bauer <dbauer@gitlab.com>
Approved-by: Marcos Rocha <mrocha@gitlab.com>
Co-authored-by: Sashi Kumar <skumar@gitlab.com>

Sync re-ordering of work items to epics

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/151806



Merged-by: Kassio Borges <kborges@gitlab.com>
Approved-by: Felipe Artur <fcardozo@gitlab.com>
Approved-by: Kassio Borges <kborges@gitlab.com>
Reviewed-by: Kassio Borges <kborges@gitlab.com>
Reviewed-by: Nicolas Dular <ndular@gitlab.com>
Co-authored-by: Nicolas Dular <ndular@gitlab.com>

feature: Upload artifacts to an existing machine learning model version

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/152163



Merged-by: Rahul Chanila <rchanila@gitlab.com>
Approved-by: Rahul Chanila <rchanila@gitlab.com>
Reviewed-by: Alper Akgun <aakgun@gitlab.com>
Reviewed-by: Eduardo Bonet <ebonet@gitlab.com>
Reviewed-by: Rahul Chanila <rchanila@gitlab.com>
Co-authored-by: Alper Akgun <aakgun@gitlab.com>

Changelog: added

Fix flaky boards spec due to popover

Closes gitlab-org/quality/engineering-productivity/master-broken-incidents#6365

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153509



Merged-by: Alper Akgun <aakgun@gitlab.com>
Approved-by: Alper Akgun <aakgun@gitlab.com>
Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com>

Create RPM package class

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153265



Merged-by: George Koltsov <gkoltsov@gitlab.com>
Approved-by: Doug Stull <dstull@gitlab.com>
Approved-by: Alper Akgun <aakgun@gitlab.com>
Approved-by: Sam Figueroa <sfigueroa@gitlab.com>
Approved-by: George Koltsov <gkoltsov@gitlab.com>
Co-authored-by: moaz-khalifa <mkhalifa@gitlab.com>

Package details page: fix the download link

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153252



Merged-by: Dzmitry Meshcharakou <12459192-dmeshcharakou@users.noreply.gitlab.com>
Approved-by: Moaz Khalifa <mkhalifa@gitlab.com>
Approved-by: Dzmitry Meshcharakou <12459192-dmeshcharakou@users.noreply.gitlab.com>
Reviewed-by: David Fernandez <dfernandez@gitlab.com>
Reviewed-by: Dzmitry Meshcharakou <12459192-dmeshcharakou@users.noreply.gitlab.com>
Reviewed-by: Moaz Khalifa <mkhalifa@gitlab.com>
Co-authored-by: David Fernandez <dfernandez@gitlab.com>

When writing the gcs signed url metrics don't overwrite the existing
value if there is one. Now, we're going to merge the metrics into the
existing value.

Changelog: fixed

Finalize BackupAndRemoveNotesWithNullNoteableType

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153029



Merged-by: Alper Akgun <aakgun@gitlab.com>
Approved-by: Alper Akgun <aakgun@gitlab.com>
Co-authored-by: Mario Celi <mcelicalderon@gitlab.com>

Merge branch 'mark-old-advanced-search-migrations-as-obsolete-mark_obsolete-20230519142363--add-ci-catalog-to-project' into 'master' 

Mark 20230519142363 as obsolete

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/152983



Merged-by: Siddharth Dungarwal <sdungarwal@gitlab.com>
Approved-by: Madelein van Niekerk <mvanniekerk@gitlab.com>
Approved-by: Dmitry Gruzd <dgruzd@gitlab.com>
Co-authored-by: Terri Chu <tchu@gitlab.com>

This migration marks the 20230519142363 AddCiCatalogToProject Advanced search migration as obsolete.

This MR will still need changes to remove references to the migration in the code.
At the moment the `gitlab-housekeeper` is not always capable of removing all references so you must check the
diff and pipeline failures to confirm if there are any issues.
It is the responsibility of the assignee (picked from ~"group::global search") to push those changes to this branch.

You can read more about the process for marking Advanced search migrations as obsolete in
https://docs.gitlab.com/ee/development/search/advanced_search_migration_styleguide.html#deleting-advanced-search-migrations-in-a-major-version-upgrade.

As part of our process we want to ensure all Advanced search migrations have had at least one
[required stop](https://docs.gitlab.com/ee/development/database/required_stops.html)
to process the migration. Therefore we can mark any Advanced search migrations added before the
last required stop as obsolete.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::MarkOldAdvancedSearchMigrationsAsObsolete keep.

To provide feedback on your experience with `gitlab-housekeeper` please comment in
<https://gitlab.com/gitlab-org/gitlab/-/issues/442003>.

Changelog: other
EE: true

The popover interferes with the spec as it can steal cursor focus while
the test is trying to hover over some elements

Logs Volume improvements

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/152694



Merged-by: Lorenz van Herwaarden <lvanherwaarden@gitlab.com>
Approved-by: Sharmad Nachnolkar <snachnolkar@gitlab.com>
Approved-by: Lorenz van Herwaarden <lvanherwaarden@gitlab.com>
Reviewed-by: Lorenz van Herwaarden <lvanherwaarden@gitlab.com>
Co-authored-by: Daniele Rossetti <drossetti@gitlab.com>

Fix race condition in rack-attack oAuth token specs

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153316



Merged-by: Jennifer Li <jli@gitlab.com>
Approved-by: Jessie Young <jessieyoung@gitlab.com>
Reviewed-by: Jessie Young <jessieyoung@gitlab.com>
Co-authored-by: agius <andrew@atevans.com>

Dont download whole GCP objects in clean up task

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153229



Merged-by: drew stachon <730684-drew@users.noreply.gitlab.com>
Approved-by: drew stachon <730684-drew@users.noreply.gitlab.com>
Co-authored-by: Erick Bajao <fbajao@gitlab.com>

Merge branch 'mark-old-advanced-search-migrations-as-obsolete-mark_obsolete-20230428500000--add-suffix-project-in-wiki-rid' into 'master' 

Mark 20230428500000 as obsolete

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/152979



Merged-by: Terri Chu <tchu@gitlab.com>
Approved-by: Ravi Kumar <rkumar@gitlab.com>
Approved-by: John Mason <9717668-johnmason@users.noreply.gitlab.com>
Co-authored-by: Dmitry Gruzd <dgruzd@gitlab.com>

This migration marks the 20230428500000 AddSuffixProjectInWikiRid Advanced search migration as obsolete.

This MR will still need changes to remove references to the migration in the code.
At the moment the `gitlab-housekeeper` is not always capable of removing all references so you must check the
diff and pipeline failures to confirm if there are any issues.
It is the responsibility of the assignee (picked from ~"group::global search") to push those changes to this branch.

You can read more about the process for marking Advanced search migrations as obsolete in
https://docs.gitlab.com/ee/development/search/advanced_search_migration_styleguide.html#deleting-advanced-search-migrations-in-a-major-version-upgrade.

As part of our process we want to ensure all Advanced search migrations have had at least one
[required stop](https://docs.gitlab.com/ee/development/database/required_stops.html)
to process the migration. Therefore we can mark any Advanced search migrations added before the
last required stop as obsolete.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::MarkOldAdvancedSearchMigrationsAsObsolete keep.

To provide feedback on your experience with `gitlab-housekeeper` please comment in
<https://gitlab.com/gitlab-org/gitlab/-/issues/442003>.

Changelog: other
EE: true

Wiki edit page: Move delete button to action row

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153262



Merged-by: Himanshu Kapoor <info@fleon.org>
Approved-by: Annabel Dunstone Gray <annabel.dunstone@gmail.com>
Approved-by: Himanshu Kapoor <info@fleon.org>
Co-authored-by: Sascha Eggenberger <seggenberger@gitlab.com>

Remove unused custom_permissions data

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153201



Merged-by: Scott Hampton <shampton@gitlab.com>
Approved-by: Alex Buijs <abuijs@gitlab.com>
Approved-by: Pedro Pombeiro <noreply@pedro.pombei.ro>
Approved-by: Scott Hampton <shampton@gitlab.com>
Co-authored-by: Daniel Tian <dtian@gitlab.com>

Merge branch '439147-organizations-swap-mock-test-data-for-frontend-fixtures-to-improve-test-coverage-3' into 'master' 

Move organization mock data to fixtures

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153048



Merged-by: Himanshu Kapoor <info@fleon.org>
Approved-by: Jay Montal <jmontal@gitlab.com>
Approved-by: Himanshu Kapoor <info@fleon.org>
Co-authored-by: Peter Hegman <phegman@gitlab.com>

Organization users query and organization mutations

Only include the duo pro widget data if ultimate trial is absent

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153207



Merged-by: Nicolas Dular <ndular@gitlab.com>
Approved-by: Serhii Yarynovskyi <syarynovskyi@gitlab.com>
Approved-by: Nicolas Dular <ndular@gitlab.com>
Reviewed-by: Nicolas Dular <ndular@gitlab.com>
Co-authored-by: Doug Stull <dstull@gitlab.com>

Update Gitaly version

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153484



Merged-by: release-tools approver bot <project278964_bot6@example.com>
Approved-by: release-tools approver bot <project278964_bot6@example.com>
Co-authored-by: GitLab Release Tools Bot <delivery-team+release-tools@gitlab.com>

Enable syncing epic to work items by default

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/152627



Merged-by: Felipe Artur <fcardozo@gitlab.com>
Approved-by: Abhilash Kotte <akotte@gitlab.com>
Approved-by: Felipe Artur <fcardozo@gitlab.com>
Co-authored-by: Nicolas Dular <ndular@gitlab.com>

This removes the feature flags sync_epic_work_item_order,
sync_epic_to_work_item_dates and sync_epic_to_work_item.

Changelog: changed
EE: true

Correctly handle nil assignee arguments

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153404



Merged-by: Pavel Shutsin <pshutsin@gitlab.com>
Approved-by: Adam Hegyi <ahegyi@gitlab.com>
Approved-by: Pavel Shutsin <pshutsin@gitlab.com>
Co-authored-by: charlieablett <cablett@gitlab.com>

Skip pre-receive SD on deletes

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153022



Merged-by: Ethan Urie <eurie@gitlab.com>
Approved-by: Ethan Urie <eurie@gitlab.com>
Reviewed-by: rossfuhrman <rfuhrman@gitlab.com>
Reviewed-by: Ethan Urie <eurie@gitlab.com>
Reviewed-by: Vishwa Bhat <vbhat@gitlab.com>
Reviewed-by: James Liu <jliu@gitlab.com>
Co-authored-by: Ross Fuhrman <rfuhrman@gitlab.com>

We should skip pre-receive secret detection on delete actions, which is
indicated by a blank ref. This can time out for large repos.

Changelog: fixed
EE: true

Fix flaky Search::Zoekt::SchedulingService spec

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153311



Merged-by: Terri Chu <tchu@gitlab.com>
Approved-by: Siddharth Dungarwal <sdungarwal@gitlab.com>
Approved-by: Madelein van Niekerk <mvanniekerk@gitlab.com>

Fix instance templates pagination

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/152921



Merged-by: Scott Hampton <shampton@gitlab.com>
Approved-by: Alper Akgun <aakgun@gitlab.com>
Approved-by: Scott Hampton <shampton@gitlab.com>
Co-authored-by: Jacques <jerasmus@gitlab.com>