Merge branch '443667-finalize-and-validate-contraint' into 'master'

Finalize BackupAndRemoveNotesWithNullNoteableType

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153029



Merged-by: Alper Akgun <aakgun@gitlab.com>
Approved-by: Alper Akgun <aakgun@gitlab.com>
Co-authored-by: Mario Celi <mcelicalderon@gitlab.com>

db/docs/batched_background_migrations/backup_and_remove_notes_with_null_noteable_type.yml

@@ -6,4 +6,4 @@ introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/146023
 milestone: '16.10'
 queued_migration_version: 20240226143323
 finalize_after: '2024-03-15'
-finalized_by: # version of the migration that finalized this BBM
+finalized_by: 20240514210445

db/post_migrate/20240514210445_finalize_backup_and_remove_notes_with_null_noteable_type.rb

+# frozen_string_literal: true
+
+class FinalizeBackupAndRemoveNotesWithNullNoteableType < Gitlab::Database::Migration[2.2]
+  MIGRATION = 'BackupAndRemoveNotesWithNullNoteableType'
+
+  disable_ddl_transaction!
+  restrict_gitlab_migration gitlab_schema: :gitlab_main_cell
+  milestone '17.1'
+
+  def up
+    ensure_batched_background_migration_is_finished(
+      job_class_name: MIGRATION,
+      table_name: :notes,
+      column_name: :id,
+      job_arguments: []
+    )
+  end
+
+  def down
+    # no-op
+  end
+end

db/post_migrate/20240514214517_async_validate_notes_noteable_type_not_null_constraint.rb

+# frozen_string_literal: true
+
+class AsyncValidateNotesNoteableTypeNotNullConstraint < Gitlab::Database::Migration[2.2]
+  milestone '17.1'
+
+  CONSTRAINT_NAME = 'check_1244cbd7d0'
+
+  def up
+    prepare_async_check_constraint_validation :notes, name: CONSTRAINT_NAME
+  end
+
+  def down
+    unprepare_async_check_constraint_validation :notes, name: CONSTRAINT_NAME
+  end
+end

db/schema_migrations/20240514210445

+89358eb2216e9ab4a763faf903028d840017349bbd1b0a9e2dbe64b31ab7df0f
\ No newline at end of file

db/schema_migrations/20240514214517

+92736183b5831da66a0b5689ad026520e147c2be21dd2abc82fb1f4c8e7b12dd
\ No newline at end of file