Doug Stull 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

- added guidance and context suggestions.

This check detects the use of `remove_column` or
`cleanup_concurrent_column_rename` and adds a
comment to the changed lines, indicating the need
for ignoring the columns in the proper model

Changelog: changed

- Mention group
- Label support

charlie ablett 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

- Mention group
- Label support

This change removes `data-testid` warnings when tests have changed.

The warnings are meant to prevent breakage when production code changes
and the tests have not yet passed, not the other way around.

- sometimes roulette suggests a reviewer and by the time
  the author of the MR is ready to review, they are busy.
  This can be due to their limit on number of reviews they
  have assigned at once. We should add some verbiage to help
  guide MR authors to observe this.

- allows easy use of testid without having
  to remember syntax or recreate the setup
  of it.
- mirrors the frontend helper concept

Signed-off-by: Rémy Coutable <remy@rymai.me>

Fail the danger job if a merge request is missing the
~database-testing-automation and isn't on gitlab-org/gitlab
branch label.

Add a check to notify developers for possible
implication of finalizing heavy data migration

Signed-off-by: Rémy Coutable <remy@rymai.me>

This is a corrective action from a recent production incident that
happen because new validations were added that prevented saving of
existing records. This comment will nudge developers to think about the
impact that the new validations will have on existing data.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/419001

Chad Woolley 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

- Use correct group
- Rename category role to remote_development_be

- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120964

This prevents errors like:

[!] Invalid `Dangerfile` file: undefined method `present?' for
Danger gem might fix the issue. Your Danger version: 8.6.1, latest
Danger version: 9.3.0

For all new added migrations, the timestamp is checked against current
date and if it's older than three weeks, a warning is displayed in the
Danger message.

New CI tables that reference large tables should be
should be partitioned from the start.

- Skip database warnings
- Skip product intelligence review
- Skip data team warnings

Also remove these file from RuboCop TODOs

In order to add a suggestion you now need to:
1. Create a suggestion and specs
2. Add suggestion class to SUGGESTIONS constant
3. There is no step 3

When making an update or change to the GraphQL API,
the exiting, updated or new frontend components must remain -
backwards-compatible with the existing version of the GraphQL API.

MR authors and reviewers should be warned when they are changing
both frontend and backend GraphQL code.

Add a comment to MRs targeting stable branches
on canonical when the package-and-test job fails

The execution of package-and-test pipeline is required on merge request
targeting stable branches as a way to guarantee the changes introduced
are compliant from the Quality side. This is not necessary for
documentation changes or for merge request fixing flaky failures, so in
this case it's fine to skip the Danger message.

This commit updates the stable branch checks to skip the
package-and-test message on trivial merge requests with documentation
changes only or with fixes for flaky failures.

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2839

Danger checks include a QA one to verify if a QA selector was modified,
and in this case, encourage the execution of the package-and-test
pipeline. Stable branches automatically trigger the package-and-test
pipeilne to guarantee changes are compliant from the Quality side.

Because of the above, this commit removes the QA check from stable
branches.

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2839

Currently, the 'QA package-and-test' section in Danger appears to be
part of the Reviewer Roulette (or the previous Danger section). This
commit splits the QA into a dedicated Danger section.

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2839