Merge branch 'jmontal_remove_ff_timeout_status_check_responses' into 'master'

Remove timeout_status_check_responses feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/141152



Merged-by: Brett Walker <bwalker@gitlab.com>
Approved-by: Aaron Huntsman <ahuntsman@gitlab.com>
Approved-by: Brett Walker <bwalker@gitlab.com>
Co-authored-by: Jay Montal <jmontal@gitlab.com>

ee/app/workers/compliance_management/timeout_pending_status_check_responses_worker.rb

@@ -13,8 +13,6 @@ class TimeoutPendingStatusCheckResponsesWorker
     urgency :high
 
     def perform
-      return unless Feature.enabled?(:timeout_status_check_responses)
-
       ::MergeRequests::StatusCheckResponse.pending.each_batch do |batch|
         batch.timeout_eligible.update_all(status: 'failed')
       end

ee/config/feature_flags/development/timeout_status_check_responses.yml

----
-name: timeout_status_check_responses
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/133383
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/427356
-milestone: '16.6'
-type: development
-group: group::compliance
-default_enabled: true

ee/spec/workers/compliance_management/timeout_pending_status_check_responses_worker_spec.rb

@@ -17,36 +17,19 @@
       create(:recent_retried_pending_status_check_response)
     end
 
-    context 'when feature flag `timeout_status_check_responses` is enabled' do
-      it 'sets qualified `pending` status check responses to failed' do
-        worker.perform
+    it 'sets qualified `pending` status check responses to failed' do
+      worker.perform
 
-        expect(recent_pending_status_check_response.status).to eq('pending')
-        expect(recent_retried_pending_status_check_response.status).to eq('pending')
+      expect(recent_pending_status_check_response.status).to eq('pending')
+      expect(recent_retried_pending_status_check_response.status).to eq('pending')
 
-        expect(old_pending_status_check_response.status).to eq('failed')
-        expect(old_retried_pending_status_check_response.status).to eq('failed')
-      end
-
-      it 'does not update existing `passed` or `failed` status check responses' do
-        expect(old_passed_status_check_response.status).to eq('passed')
-        expect(old_failed_status_check_response.status).to eq('failed')
-      end
+      expect(old_pending_status_check_response.status).to eq('failed')
+      expect(old_retried_pending_status_check_response.status).to eq('failed')
     end
 
-    context 'when feature flag `timeout_status_check_responses` is disabled' do
-      before do
-        stub_feature_flags(timeout_status_check_responses: false)
-      end
-
-      it 'does not update status check responses' do
-        worker.perform
-
-        expect(recent_pending_status_check_response.status).to eq('pending')
-        expect(recent_retried_pending_status_check_response.status).to eq('pending')
-        expect(old_pending_status_check_response.status).to eq('pending')
-        expect(old_retried_pending_status_check_response.status).to eq('pending')
-      end
+    it 'does not update existing `passed` or `failed` status check responses' do
+      expect(old_passed_status_check_response.status).to eq('passed')
+      expect(old_failed_status_check_response.status).to eq('failed')
     end
 
     it_behaves_like 'an idempotent worker'