Skip to content
代码片段 群组 项目
提交 17424cdb 编辑于 作者: Jay Montal's avatar Jay Montal
浏览文件

Remove timeout_status_check_responses ff

Timeout status check responses have been released so ff is being removed

Changelog: changed
EE: true
上级 275e794f
No related branches found
No related tags found
无相关合并请求
......@@ -13,8 +13,6 @@ class TimeoutPendingStatusCheckResponsesWorker
urgency :high
def perform
return unless Feature.enabled?(:timeout_status_check_responses)
::MergeRequests::StatusCheckResponse.pending.each_batch do |batch|
batch.timeout_eligible.update_all(status: 'failed')
end
......
---
name: timeout_status_check_responses
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/133383
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/427356
milestone: '16.6'
type: development
group: group::compliance
default_enabled: true
......@@ -17,36 +17,19 @@
create(:recent_retried_pending_status_check_response)
end
context 'when feature flag `timeout_status_check_responses` is enabled' do
it 'sets qualified `pending` status check responses to failed' do
worker.perform
it 'sets qualified `pending` status check responses to failed' do
worker.perform
expect(recent_pending_status_check_response.status).to eq('pending')
expect(recent_retried_pending_status_check_response.status).to eq('pending')
expect(recent_pending_status_check_response.status).to eq('pending')
expect(recent_retried_pending_status_check_response.status).to eq('pending')
expect(old_pending_status_check_response.status).to eq('failed')
expect(old_retried_pending_status_check_response.status).to eq('failed')
end
it 'does not update existing `passed` or `failed` status check responses' do
expect(old_passed_status_check_response.status).to eq('passed')
expect(old_failed_status_check_response.status).to eq('failed')
end
expect(old_pending_status_check_response.status).to eq('failed')
expect(old_retried_pending_status_check_response.status).to eq('failed')
end
context 'when feature flag `timeout_status_check_responses` is disabled' do
before do
stub_feature_flags(timeout_status_check_responses: false)
end
it 'does not update status check responses' do
worker.perform
expect(recent_pending_status_check_response.status).to eq('pending')
expect(recent_retried_pending_status_check_response.status).to eq('pending')
expect(old_pending_status_check_response.status).to eq('pending')
expect(old_retried_pending_status_check_response.status).to eq('pending')
end
it 'does not update existing `passed` or `failed` status check responses' do
expect(old_passed_status_check_response.status).to eq('passed')
expect(old_failed_status_check_response.status).to eq('failed')
end
it_behaves_like 'an idempotent worker'
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册