Merge branch 'sf/chore/update-rubocop-message-for-qa-selectors' into 'master'

Update advice for QA selectors in rubocop output

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/141745



Merged-by: Kerri Miller <kerrizor@kerrizor.com>
Approved-by: Will Meek <wmeek@gitlab.com>
Approved-by: Kerri Miller <kerrizor@kerrizor.com>
Co-authored-by: Sam Figueroa <sfigueroa@gitlab.com>

rubocop/cop/qa/element_with_pattern.rb

@@ -30,7 +30,7 @@ def on_send(node)
           return if args.first.nil?
 
           args.first.each_node(:str) do |arg|
-            add_offense(arg, message: MESSAGE % "data-qa-selector=#{element_name.value}")
+            add_offense(arg, message: MESSAGE % "data-testid=#{element_name.value}")
           end
         end
 

spec/rubocop/cop/qa/element_with_pattern_spec.rb

@@ -16,9 +16,9 @@
       expect_offense(<<-RUBY)
       view 'app/views/shared/groups/_search_form.html.haml' do
         element :groups_filter, 'search_field_tag :filter'
-                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use a pattern for element, create a corresponding `data-qa-selector=groups_filter` instead.
+                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use a pattern for element, create a corresponding `data-testid=groups_filter` instead.
         element :groups_filter_placeholder, /Search by name/
-                                             ^^^^^^^^^^^^^^ Don't use a pattern for element, create a corresponding `data-qa-selector=groups_filter_placeholder` instead.
+                                             ^^^^^^^^^^^^^^ Don't use a pattern for element, create a corresponding `data-testid=groups_filter_placeholder` instead.
       end
       RUBY
     end