- 8月 11, 2022
-
-
由 Grace Chen 创作于
- 8月 06, 2022
-
-
由 Ismael Juma 创作于
Version related conflicts: * Jenkinsfile * gradle.properties * streams/quickstart/java/pom.xml * streams/quickstart/java/src/main/resources/archetype-resources/pom.xml * streams/quickstart/pom.xml * tests/kafkatest/__init__.py * tests/kafkatest/version.py * commit 'add7cd85': (66 commits) KAFKA-14136 Generate ConfigRecord for brokers even if the value is unchanged (#12483) HOTFIX / KAFKA-14130: Reduce RackAwarenesssTest to unit Test (#12476) MINOR: Remove ARM/PowerPC builds from Jenkinsfile (#12380) KAFKA-14111 Fix sensitive dynamic broker configs in KRaft (#12455) KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest (#12468) KAFKA-14129: KRaft must check manual assignments for createTopics are contiguous (#12467) KAFKA-13546: Do not fail connector validation if default topic creation group is explicitly specified (#11615) KAFKA-14122: Fix flaky test DynamicBrokerReconfigurationTest#testKeyStoreAlter (#12452) MINOR; Use right enum value for broker registration change (#12236) MINOR; Synchronize access to snapshots' TreeMap (#12464) MINOR; Bump trunk to 3.4.0-SNAPSHOT (#12463) MINOR: Stop logging 404s at ERROR level in Connect KAFKA-14095: Improve handling of sync offset failures in MirrorMaker (#12432) Minor: enable index for emit final sliding window (#12461) MINOR: convert some more junit tests to support KRaft (#12456) KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run (#12441) MINOR: Remove code of removed metric (#12453) MINOR: Update comment on verifyTaskGenerationAndOwnership method in DistributedHerder KAFKA-14012: Add warning to closeQuietly documentation about method references of null objects (#12321) MINOR: Fix static mock usage in ThreadMetricsTest (#12454) ...
-
- 8月 05, 2022
-
-
由 David Arthur 创作于
-
- 8月 04, 2022
-
-
由 Guozhang Wang 创作于
While working on KAFKA-13877, I feel it's an overkill to introduce the whole test class as an integration test, since all we need is to just test the assignor itself which could be a unit test. Running this suite with 9+ instances takes long time and is still vulnerable to all kinds of timing based flakiness. A better choice is to reduce it as a unit test, similar to HighAvailabilityStreamsPartitionAssignorTest that just test the behavior of the assignor itself, rather than creating many instances hence depend on various timing bombs to not explode. Since we mock everything, there's no flakiness anymore. Plus we greatly reduced the test runtime (on my local machine, the old integration takes about 35 secs to run the whole suite, while the new one take 20ms on average). Reviewers: Divij Vaidya <diviv@amazon.com>, Dalibor Plavcic
-
由 Jason Gustafson 创作于
Reviewers: Colin P. McCabe <cmccabe@apache.org>, Ismael Juma <ismael@juma.me.uk>
-
由 Ismael Juma 创作于
> $ git merge-base apache-github/3.3 apache-github/trunk > 23c92ce7 > $ git show 23c92ce7 > commit 23c92ce7 > Author: SC <pch838811@gmail.com> > Date: Mon Jul 11 11:36:56 2022 +0900 > > MINOR: Use String#format for niceMemoryUnits result (#12389) > > Reviewers: Luke Chen <showuon@gmail.com>, Divij Vaidya <diviv@amazon.com> * commit '23c92ce7': MINOR: Use String#format for niceMemoryUnits result (#12389) KAFKA-14055; Txn markers should not be removed by matching records in the offset map (#12390) KAFKA-13474: Allow reconfiguration of SSL certs for broker to controller connection (#12381) KAFKA-13996: log.cleaner.io.max.bytes.per.second can be changed dynamically (#12296) KAFKA-13983: Fail the creation with "/" in resource name in zk ACL (#12359) KAFKA-12943: update aggregating documentation (#12091) KAFKA-13846: Follow up PR to address review comments (#12297)
-
由 Aneesh Garg 创作于
Jira: https://confluentinc.atlassian.net/browse/KSECURITY-509 Upgrading netty to v4.1.79.Final
-
由 David Arthur 创作于
Enable some of the dynamic broker reconfiguration tests in KRaft mode
-
由 Guozhang Wang 创作于
In the current test, we check for tag distribution immediately after everyone is on the running state, however due to the fact of the follow-up rebalances, "everyone is now in running state" does not mean that the cluster is now stable. In fact, a follow-up rebalance may occur, upon which the local thread metadata would return empty which would cause the distribution verifier to fail. Reviewers: Divij Vaidya <diviv@amazon.com>, Luke Chen <showuon@gmail.com>
-
- 8月 03, 2022
-
-
由 Colin Patrick McCabe 创作于
KRaft should validate that manual assignments given to createTopics are contiguous. In other words, they must start with partition 0, and progress through 1, 2, 3, etc. ZK mode does this, but KRaft mode previously did not. Also fix a null pointer exception when the placement for partition 0 was not specified. Convert over AddPartitionsTest to use KRaft. This PR converts all of the test except for some of the placement logic tests, which will need to be redone for KRaft mode in a future change. Fix null pointer exception in KRaftMetadataCache#getPartitionInfo. Specifically, we should not assume that the partition will be found in the hash map. This is another case where we had "Some(x)" but it should be "Option(x)." Fix a potential null pointer exception in BrokerServer#state. Reviewers: dengziming <dengziming1993@gmail.com>, Jason Gustafson <jason@confluent.io>
-
由 venkatteki 创作于
KAFKA-13546: Do not fail connector validation if default topic creation group is explicitly specified (#11615) Reviewers: Chris Egerton <fearthecellos@gmail.com>
-
由 Divij Vaidya 创作于
Reviewers: Mickael Maison <mickael.maison@gmail.com>
-
- 8月 02, 2022
-
-
由 dengziming 创作于
The code used BrokerRegistrationFencingChange.FENCE when unfencing a broker and used BrokerRegistrationFencingChange.UNFENCE when fencing a broker, this is confusing. This commit flips the values of the two enums and changes their usage at all of the call sites. Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com>
-
Read and write access to the TreeMap in snapshots needs to be synchronized. Reviewers: David Arthur <mumrah@gmail.com>
-
Version bumps in trunk after the creation of the 3.3 branch. Reviewers: David Arthur <mumrah@gmail.com>
-
- 8月 01, 2022
-
-
由 nicolasguyomar 创作于
Catches valid 404 exceptions, triggered by any HTTP request to a nonexistent path on the Connect REST API, higher in the code to not to log an ERROR log which can be seen as a false alarm Reviewers: Chris Egerton <fearthecellos@gmail.com>
-
由 Mickael Maison 创作于
We should not treat UNKNOWN_MEMBER_ID as an unexpected error in the Admin client. In MirrorMaker, check the result of committing offsets and log an useful error message in case that failed with UNKNOWN_MEMBER_ID. Reviewers: Chris Egerton <fearthecellos@gmail.com>
-
- 7月 30, 2022
-
-
由 Hao Li 创作于
Enable index for sliding window emit final case as it's faster to fetch windows for particular key Reviewers: Guozhang Wang <wangguoz@gmail.com>
-
由 Colin Patrick McCabe 创作于
* MINOR: convert some more junit tests to support KRaft Introduce TestUtils#waitUntilLeaderIsElectedOrChangedWithAdmin, a ZK-free alternative to TestUtils#waitUntilLeaderIsElectedOrChanged. Convert PlaintextProducerSendTest, SslProducerSendTest, TransactionsWithMaxInFlightOneTest, AddPartitionsToTxnRequestServerTest and KafkaMetricsReporterTest to support KRaft Reviewers: dengziming <dengziming1993@gmail.com>, David Arthur <mumrah@gmail.com>
-
- 7月 29, 2022
-
-
由 Christo Lolov 创作于
When the migration of the Streams project to JUnit 5 started with PR #12285, we discovered that the migrated tests were not run by the PR builds. This PR ensures that Streams' tests that are written in JUnit 4 and JUnit 5 are run in the PR builds. Co-authored-by: Divij Vaidya <diviv@amazon.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Bruno Cadonna <cadonna@apache.org>
-
由 Bruno Cadonna 创作于
When we removed metric skipped-records in 3.0 we missed to remove some code related to that metric. Reviewer: Guozhang Wang <wangguoz@gmail.com>
-
由 Yash Mayya 创作于
Reviewers: Chris Egerton <fearthecellos@gmail.com>
-
由 vamossagar12 创作于
KAFKA-14012: Add warning to closeQuietly documentation about method references of null objects (#12321) Reviewers: Kvicii <42023367+Kvicii@users.noreply.github.com>, Chris Egerton <fearthecellos@gmail.com>
-
由 Bruno Cadonna 创作于
Before this PR the calls to the static methods on StreamsMetricsImpl were just calls and not a verification on the mock. This miss happened during the switch from EasyMock to Mockito. Reviewers: Guozhang Wang <wangguoz@gmail.com>
-
由 Bruno Cadonna 创作于
Bookkeeps tasks to be recycled, closed, and updated during handling of the assignment. The bookkeeping is needed for integrating the state updater. These change is hidden behind internal config STATE_UPDATER_ENABLED. If the config is false Streams should not use the state updater and behave as usual. Reviewers: Guozhang Wang <wangguoz@gmail.com>
-
- 7月 28, 2022
-
-
由 Chris Egerton 创作于
KAFKA-14089: Only check for committed seqnos after disabling exactly-once support in Connect integration test (#12429) Reviewers: Mickael Maison <mickael.maison@gmail.com> , Tom Bentley <tbentley@redhat.com>
-
由 vamossagar12 创作于
The HeaderConverter interface extends Closeable, but we weren't closing them anywhere before. This change causes header converters to be closed as part of task shutdown. Reviewers: Kvicii <42023367+Kvicii@users.noreply.github.com>, Chris Egerton <fearthecellos@gmail.com>
-
由 Guozhang Wang 创作于
1. Consolidate the task recycle procedure into a single function within the task. The current procedure now becomes: a) task.recycleStateAndConvert, at end of it the task is in closed while its stateManager is retained, and the manager type has been converted; 2) create the new task with old task's fields and the stateManager inside the creators. 2. Move the task execution related metadata into the corresponding TaskExecutionMetadata class, including the task idle related metadata (e.g. successfully processed tasks); reduce the number of params needed for TaskExecutor as well as Tasks. 3. Move the task execution related fields (embedded producer and consumer) and task creators out of Tasks and migrated into TaskManager. Now the Tasks is only a bookkeeping place without any task mutation logic. 4. When adding tests, I realized that we should not add task to state updater right after creation, since it was not initialized yet, while state updater would validate that the task's state is already restoring / running. So I updated that logic while adding unit tests. Reviewers: Bruno Cadonna <cadonna@apache.org>
-
由 Alex Sorokoumov 创作于
Reviewers: Adam Bellemare <adam.bellemare@gmail.com>, John Roesler <vvcephei@apache.org>
-
由 Colin Patrick McCabe 创作于
Convert ProducerCompressionTest, MirrorMakerIntegrationTest, EdgeCaseRequestTest to kraft. Make it explicit that ServerShutdownTest#testControllerShutdownDuringSend is ZK-only. Reviewers: David Arthur <mumrah@gmail.com>
-
- 7月 27, 2022
-
-
由 Daniel Fonai 创作于
Removes the requirement of presence of sub claim in JWT access tokens, when clients authenticate via OAuth. This does not interfere with OAuth specifications and is to ensure wider compatibility with OAuth providers. Unit test added. Reviewers: Kirk True <ktrue@confluent.io>, Viktor Somogyi-Vass <viktorsomogyi@gmail.com>, Manikumar Reddy <manikumar.reddy@gmail.com>
-
由 Hao Li 创作于
Reviewers: John Roesler <vvcephei@apache.org>
-
由 David Arthur 创作于
Makes all ControllerApis request handlers return a `CompletableFuture[Unit]`. Also adds an additional completion stage which ensures we capture errors thrown during response building. Reviewed-by: Colin P. McCabe <cmccabe@apache.org>
-
- 7月 26, 2022
-
-
由 Divij Vaidya 创作于
Reviewers: Mickael Maison <mickael.maison@gmail.com>
-
由 Christo Lolov 创作于
-
由 Ismael Juma 创作于
Highlights: * The default Scala Zinc version was updated from 1.3.5 to 1.6.1 * Multiple Checkstyle tasks may now run in parallel within a project * Support for Java 18 * Much more responsive continuous builds on Windows and macOS * Improved diagnostics for dependency resolution Some of our tests require java.util and java.lang modules to be open, so do it explicitly given the following Gradle bug fix: > When running on Java 9+, Gradle no longer opens the java.base/java.util > and java.base/java.lang JDK modules for all Test tasks. In some cases, > this would cause code to pass during testing but fail at runtime. Release notes: https://docs.gradle.org/7.5/release-notes.html Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, Luke Chen <showuon@gmail.com>
-
由 Bruno Cadonna 创作于
Reviewer: Guozhang Wang <wangguoz@gmail.com>
-
由 Jason Gustafson 创作于
After the fix for https://github.com/apache/kafka/pull/12150, if a follower receives a request from another replica, it will return UNKNOWN_LEADER_EPOCH even if the leader epoch matches. We need to do epoch leader/epoch validation first before we check whether we have a valid replica. Reviewers: David Jacot <djacot@confluent.io>
-
由 Christo Lolov 创作于
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chris Egerton <fearthecellos@gmail.com>
-