- 8月 19, 2022
-
-
由 Alex Sorokoumov 创作于
* KAFKA-13769: Add tests for ForeignJoinSubscriptionProcessorSupplier (#12437) Reviewers: Adam Bellemare <adam.bellemare@gmail.com>, John Roesler <vvcephei@apache.org> * KAFKA-13769 Fix version check in SubscriptionStoreReceiveProcessorSupplier
- 8月 12, 2022
-
-
由 Steven Zhang 创作于
This commit changes the version check from != to > as the process method works correctly on both version 1 and 2. != incorrectly throws on v1 records. Co-authored-by: Alex Sorokoumov <918393+Gerrrr@users.noreply.github.com>
- 8月 10, 2022
- 8月 08, 2022
- 7月 29, 2022
- 7月 27, 2022
- 7月 26, 2022
- 7月 16, 2022
-
-
由 Lucas Bradstreet 创作于
With 6f81bb18 merged, we can now use c4.xlarge instances with our system tests, which are much more reliable for spot than m3.xlarge.
-
- 7月 09, 2022
-
-
由 Lucas Bradstreet 创作于
When running with 4th generation instances supporting EBS only, we need to use a larger volume or else we run out of disk space during a system test run. This change also parameterizes the instance type as an env variable for easier testing. Reviewers: David Jacot <djacot@confluent.io>
-
- 7月 08, 2022
-
-
由 Matthias J. Sax 创作于
-
由 Matthias J. Sax 创作于
KIP-770 introduced a performance regression and needs some re-design. Needed to resolve some conflict while reverting. This reverts commits 1317f3f7 and 0924fd3f. Reviewers: Sagar Rao <sagarmeansocean@gmail.com>, Guozhang Wang <guozhang@confluent.io>
-
- 7月 07, 2022
-
-
由 Lucas Bradstreet 创作于
When running with 4th generation instances supporting EBS only, we need to use a larger volume or else we run out of disk space during a system test run. This change also parameterizes the instance type as an env variable for easier testing. Reviewers: David Jacot <djacot@confluent.io>
-
由 Lucas Bradstreet 创作于
When running with 4th generation instances supporting EBS only, we need to use a larger volume or else we run out of disk space during a system test run. This change also parameterizes the instance type as an env variable for easier testing. Reviewers: David Jacot <djacot@confluent.io>
-
由 Guozhang Wang 创作于
-
由 Guozhang Wang 创作于
When store changelog reader is called by a different thread than the stream thread, it can no longer use the main consumer to get committed offsets since consumer is not thread-safe. Instead, we would remove main consumer and leverage on the existing admin client to get committed offsets. Reviewers: Bruno Cadonna <cadonna@apache.org>
-
由 YU 创作于
When building a forwarded request, we need to override the dequeue time of the underlying request to match the same value as the envelope. Otherwise, the field is left unset, which causes inaccurate reporting. Reviewers; Jason Gustafson <jason@confluent.io>
-
- 7月 06, 2022
-
-
由 Bruno Cadonna 创作于
The call to Task#completeRestoration calls methods on the main consumer. The state updater thread should not access the main consumer since the main consumer is not thread-safe. Additionally, Task#completeRestoration changed the state of active tasks, but we decided to keep task life cycle management outside of the state updater. Task#completeRestoration should be called by the stream thread on restored active tasks returned by the state udpater. Reviewer: Guozhang Wang <guozhang@apache.org>
-
由 Divij Vaidya 创作于
KAFKA-13943; Make `LocalLogManager` implementation consistent with the `RaftClient` contract (#12224) Fixes two issues in the implementation of `LocalLogManager`: - As per the interface contract for `RaftClient.scheduleAtomicAppend()`, it should throw a `NotLeaderException` exception when the provided current leader epoch does not match the current epoch. However, the current `LocalLogManager`'s implementation of the API returns a LONG_MAX instead of throwing an exception. This change fixes the behaviour and makes it consistent with the interface contract. - As per the interface contract for `RaftClient.resign(epoch)`if the parameter epoch does not match the current epoch, this call will be ignored. But in the current `LocalLogManager` implementation the leader epoch might change when the thread is waiting to acquire a lock on `shared.tryAppend()` (note that tryAppend() is a synchronized method). In such a case, if a NotALeaderException is thrown (as per code change in above), then resign should be ignored. Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com>, Tom Bentley <tbentley@redhat.com>, Jason Gustafson <jason@confluent.io>
-
由 Chris Egerton 创作于
Implements embedded end-to-end integration tests for KIP-618, and brings together previously-decoupled logic from upstream PRs. Reviewers: Luke Chen <showuon@gmail.com>, Tom Bentley <tbentley@redhat.com>, Mickael Maison <mickael.maison@gmail.com>
-
由 dengziming 创作于
When brokers are co-resident with controllers using kraft, we incorrectly determine the supported API versions on the controller using `NodeApiVersions.create()`. The patch fixes the problem by using the versions from the sent `ApiVersions` request even when connecting to the local node. The patch also improves integration tests by adding support for co-resident mode. Reviewers: Justine Olshan <jolshan@confluent.io>, Jason Gustafson <jason@confluent.io>
-
- 7月 05, 2022
-
-
由 Viktor Somogyi-Vass 创作于
Reviewers: Manikumar Reddy
-
由 Chris Egerton 创作于
Reviewers: Mickael Maison <mickael.maison@gmail.com> , Tom Bentley <tbentley@redhat.com>
-
由 Thomas Cooper 创作于
Reviewers: Luke Chen <showuon@gmail.com>
-
由 Matthew de Detrich 创作于
Currently the tests fail because there is a missing predicate in the retrievableException which causes the test to fail, i.e. the current predicates containsString("Cannot get state store source-table because the stream thread is PARTITIONS_ASSIGNED, not RUNNING"), containsString("The state store, source-table, may have migrated to another instance"), containsString("Cannot get state store source-table because the stream thread is STARTING, not RUNNING") wasn't complete. Another one needed to be added, namely "The specified partition 1 for store source-table does not exist.". This is because its possible for assertThat(getStore(kafkaStreams2, storeQueryParam2).get(key), is(nullValue())); or assertThat(getStore(kafkaStreams1, storeQueryParam2).get(key), is(nullValue())); (depending on which branch) to be thrown, i.e. see org.apache.kafka.streams.errors.InvalidStateStorePartitionException: The specified partition 1 for store source-table does not exist. at org.apache.kafka.streams.state.internals.WrappingStoreProvider.stores(WrappingStoreProvider.java:63) at org.apache.kafka.streams.state.internals.CompositeReadOnlyKeyValueStore.get(CompositeReadOnlyKeyValueStore.java:53) at org.apache.kafka.streams.integration.StoreQueryIntegrationTest.lambda$shouldQuerySpecificActivePartitionStores$5(StoreQueryIntegrationTest.java:223) at org.apache.kafka.streams.integration.StoreQueryIntegrationTest.retryUntil(StoreQueryIntegrationTest.java:579) at org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQuerySpecificActivePartitionStores(StoreQueryIntegrationTest.java:186) This happens when the stream hasn't been initialized yet. I have run the test around 12k times using Intellij's JUnit testing framework without any flaky failures. The PR also does some minor refactoring regarding moving the list of predicates into their own functions. Co-authored-by: Bruno Cadonna <cadonna@apache.org> Reviewer: Bruno Cadonna <cadonna@apache.org>
-
- 7月 04, 2022
-
-
由 Guozhang Wang 创作于
1. As titled, fix the right constructor param ordering. 2. Also added a few more loglines. Reviewers: Matthias J. Sax <matthias@confluent.io>, Sagar Rao <sagarmeansocean@gmail.com>, Hao Li <1127478+lihaosky@users.noreply.github.com>
-
- 7月 03, 2022
-
-
由 Bruno Cadonna 创作于
Before this PR the calls to the static methods on StreamsMetricsImpl were just calls and not a verification on the mock. This miss happened during the switch from EasyMock to Mockito. Reviewers: Guozhang Wang <wangguoz@gmail.com>
-
- 7月 02, 2022
-
-
由 RivenSun 创作于
Reviewers: Kvicii <42023367+Kvicii@users.noreply.github.com>, Divij Vaidya <divijvaidya13@gmail.com>, Jason Gustafson <jason@confluent.io>
-
由 Nikolay 创作于
Removes unused methods from `BrokerEndPoint`: * `createBrokerEndPoint(Int, String)` * `readFrom(buffer: ByteBuffer)` * `connectionString(): String` * `writeTo(buffer: ByteBuffer)` * `sizeInBytes: Int` Reviewers: dengziming <dengziming1993@gmail.com>, Luke Chen <showuon@gmail.com>, Jason Gustafson <jason@confluent.io>
-
- 7月 01, 2022
-
-
由 Jason Gustafson 创作于
In `ControllerApis`, we are missing the logic to set the local processing end time after `handle` returns. As a consequence of this, the remote time ends up reported as the local time in the request level metrics. The patch adds the same logic we have in `KafkaApis` to set `apiLocalCompleteTimeNanos`. Reviewers: José Armando García Sancio <jsancio@gmail.com>
-
由 Niket 创作于
The NPE causes the kraft controller to be in an inconsistent state. Reviewers: Jason Gustafson <jason@confluent.io>
-
-
由 Prashanth Joseph Babu 创作于
Reviewers: Matthias J. Sax <matthias@confluent.io>
-
- 6月 30, 2022
-
-
由 Guozhang Wang 创作于
For most tests we would need an auto-ticking mock timer to work with draining-with-timeout functions. For tests that check for never checkpoint we need no auto-ticking timer to control exactly how much time elapsed. Reviewers: Bruno Cadonna <cadonna@apache.org>
-
由 Guozhang Wang 创作于
* Add a new API for session windows to range query session window by end time (KIP related). * Augment session window aggregator with emit strategy. * Minor: consolidated some dup classes. * Test: unit test on session window aggregator. Reviewers: Guozhang Wang <wangguoz@gmail.com>
-
- 6月 29, 2022
-
-
由 Luke Chen 创作于
When submitting the AlterIsr request, we register a future listener to handle the response. When receiving retriable error, we expected the AlterIsr request will get retried. And then, we'll re-submit the request again. However, before the future listener got called, we didn't clear the `unsentIsrUpdates`, which causes we failed to "enqueue" the request because we thought there's an in-flight request. We use "try/finally" to make sure the unsentIsrUpdates got cleared, but it happened "after" we retry the request Reviewers: David Jacot <djacot@confluent.io>, dengziming <dengziming1993@gmail.com>
-
由 CHUN-HAO TANG 创作于
https://issues.apache.org/jira/browse/KAFKA-13821 Reviewers: Jorge Esteban Quilcate Otoya <quilcate.jorge@gmail.com>, Bill Bejeck <bbejeck@apache.org>
-
- 6月 28, 2022
-
-
由 Tom Kaszuba 创作于
Reviewers: Matthias J. Sax <matthias@confluent.io>
-