Fix sed to support code-sync bundle install
比较变更
+ 5
− 2
\ No newline at end of file
Fix sed to support code-sync bundle install.
Changes from: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/121676/diffs
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/121676#note_1423258987
Q: question: Do we plan to move
vendor/gems/*
togems/*
at some point?
A: The purpose of
vendor/gems/
andgems/
:
gems/
is to our developed in-house gemsvendor/gems/
are to external gems that we pulled into repository for simplicity purposes, that are regularly stored in another repository So, there are gems developed by us, but also gems that are external: https://gitlab.com/gitlab-org/gitlab/-/blob/master/vendor/gems/attr_encrypted/attr_encrypted.gemspec. So, if the gem is developed by us, should be moved intogems/
only if it does not have external repo with which it is kept in sync.rubygems
if applicable, but heavy on the process, requires separate project
Non-UI
% git checkout main-jh
% git fetch -all
% git merge origin/master
% ./jh/bin/build_static_gemfile
% bundle
Error message outputs:
The path `/Users/cbd/codes/gitlab-jh-group/jihulab-gdk/gitlab/jh/gems/gitlab-rspec` does not exist.
% git checkout <current-branch>
% ./jh/bin/build_static_gemfile
% bundle
Successful message outputs:
Bundle complete! 319 Gemfile dependencies, 647 gems now installed.
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.