Fix sed to support code-sync bundle install
What does this MR do and why?
Fix sed to support code-sync bundle install.
- Failed pipeline in code-sync repo: https://jihulab.com/gitlab-cn/code-sync/-/pipelines/1310106
- Failed job in code-sync repo: https://jihulab.com/gitlab-cn/code-sync/-/jobs/8162387
Changes from: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/121676/diffs
Ref comments
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/121676#note_1423258987
Q: question: Do we plan to move
vendor/gems/*
togems/*
at some point?
A: The purpose of
vendor/gems/
andgems/
:
gems/
is to our developed in-house gemsvendor/gems/
are to external gems that we pulled into repository for simplicity purposes, that are regularly stored in another repository So, there are gems developed by us, but also gems that are external: https://gitlab.com/gitlab-org/gitlab/-/blob/master/vendor/gems/attr_encrypted/attr_encrypted.gemspec. So, if the gem is developed by us, should be moved intogems/
only if it does not have external repo with which it is kept in sync.rubygems
if applicable, but heavy on the process, requires separate project
Screenshots or screen recordings
Non-UI
How to set up and validate locally
Bug behavior
% git checkout main-jh
% git fetch -all
% git merge origin/master
% ./jh/bin/build_static_gemfile
% bundle
Error message outputs:
The path `/Users/cbd/codes/gitlab-jh-group/jihulab-gdk/gitlab/jh/gems/gitlab-rspec` does not exist.
After fixing
% git checkout <current-branch>
% ./jh/bin/build_static_gemfile
% bundle
Successful message outputs:
Bundle complete! 319 Gemfile dependencies, 647 gems now installed.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
由 Baodong 编辑于