Skip to content

Fix graceful rubocop from job 4852580

Baodong请求将fix/rubocop-graceful-job-4852580合并到main-jh

What does this MR do and why?

Fix graceful rubocop from job: https://jihulab.com/gitlab-cn/gitlab/-/jobs/4852580

jh/lib/gitlab/chatops/feishu_bot_handler.rb:24:23: C: [Correctable] Style/SingleArgumentDig: Use params[:type] instead of params.dig(:type).
        return unless params.dig(:type) == URL_VERIFICATION_TYPE
                      ^^^^^^^^^^^^^^^^^
jh/lib/gitlab/chatops/feishu_bot_handler.rb:26:33: C: [Correctable] Style/SingleArgumentDig: Use params[:challenge] instead of params.dig(:challenge).
        response = { challenge: params.dig(:challenge) }
                                ^^^^^^^^^^^^^^^^^^^^^^
jh/lib/gitlab/ones/query.rb:114:20: C: [Correctable] Style/SingleArgumentDig: Use client.message_query(task_uuid_params)['messages'] instead of client.message_query(task_uuid_params).dig('messages').
        comments = client.message_query(task_uuid_params).dig('messages').filter do |comment|
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
jh/spec/requests/api/captcha_spec.rb:55:20: C: [Correctable] Style/SingleArgumentDig: Use json_response['errors'] instead of json_response.dig('errors').
            expect(json_response.dig('errors')).to be_nil
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^
28982 files inspected, 4 offenses silenced

合并请求报告

加载中