Skip to content
代码片段 群组 项目

Fix graceful rubocop from job 4852580

已合并 Baodong requested to merge fix/rubocop-graceful-job-4852580 into main-jh
所有主题已解决!

What does this MR do and why?

Fix graceful rubocop from job: https://jihulab.com/gitlab-cn/gitlab/-/jobs/4852580

jh/lib/gitlab/chatops/feishu_bot_handler.rb:24:23: C: [Correctable] Style/SingleArgumentDig: Use params[:type] instead of params.dig(:type).
        return unless params.dig(:type) == URL_VERIFICATION_TYPE
                      ^^^^^^^^^^^^^^^^^
jh/lib/gitlab/chatops/feishu_bot_handler.rb:26:33: C: [Correctable] Style/SingleArgumentDig: Use params[:challenge] instead of params.dig(:challenge).
        response = { challenge: params.dig(:challenge) }
                                ^^^^^^^^^^^^^^^^^^^^^^
jh/lib/gitlab/ones/query.rb:114:20: C: [Correctable] Style/SingleArgumentDig: Use client.message_query(task_uuid_params)['messages'] instead of client.message_query(task_uuid_params).dig('messages').
        comments = client.message_query(task_uuid_params).dig('messages').filter do |comment|
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
jh/spec/requests/api/captcha_spec.rb:55:20: C: [Correctable] Style/SingleArgumentDig: Use json_response['errors'] instead of json_response.dig('errors').
            expect(json_response.dig('errors')).to be_nil
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^
28982 files inspected, 4 offenses silenced

合并请求报告

Loading
Loading

动态

过滤活动
  • 批准
  • 指派人和审核者
  • 评论(来自机器人)
  • 评论(来自用户)
  • 提交和分支
  • 编辑
  • 标记
  • 锁定状态
  • 提及
  • 合并请求状态
  • 跟踪
  • Baodong added 215 commits

    added 215 commits

    Compare with previous version

  • Fu Zhang approved this merge request

    approved this merge request

  • Martin Tan approved this merge request

    approved this merge request

  • 🤖 JiHu Bot 🤖 resolved all threads

    resolved all threads

  • Fu Zhang mentioned in commit bd0c7b6b

    mentioned in commit bd0c7b6b

  • merged

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • unassigned @icbd

  • 注册登录再回复
    加载中