Fix graceful rubocop from job 4852580
What does this MR do and why?
Fix graceful rubocop from job: https://jihulab.com/gitlab-cn/gitlab/-/jobs/4852580
jh/lib/gitlab/chatops/feishu_bot_handler.rb:24:23: C: [Correctable] Style/SingleArgumentDig: Use params[:type] instead of params.dig(:type).
return unless params.dig(:type) == URL_VERIFICATION_TYPE
^^^^^^^^^^^^^^^^^
jh/lib/gitlab/chatops/feishu_bot_handler.rb:26:33: C: [Correctable] Style/SingleArgumentDig: Use params[:challenge] instead of params.dig(:challenge).
response = { challenge: params.dig(:challenge) }
^^^^^^^^^^^^^^^^^^^^^^
jh/lib/gitlab/ones/query.rb:114:20: C: [Correctable] Style/SingleArgumentDig: Use client.message_query(task_uuid_params)['messages'] instead of client.message_query(task_uuid_params).dig('messages').
comments = client.message_query(task_uuid_params).dig('messages').filter do |comment|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
jh/spec/requests/api/captcha_spec.rb:55:20: C: [Correctable] Style/SingleArgumentDig: Use json_response['errors'] instead of json_response.dig('errors').
expect(json_response.dig('errors')).to be_nil
^^^^^^^^^^^^^^^^^^^^^^^^^^^
28982 files inspected, 4 offenses silenced
合并请求报告
动态
changed milestone to %15.5
added fix:pipeline label
requested review from @prajnamas
assigned to @icbd
@icbd,请添加类型标记:- typebug:已发布或上线的产品中所出现的缺陷。这种类型的 issue 需在 QA 验证过后才可以关闭,而下面其它类型的 issue 在相关的 merge request (MR) 合并后即可关闭。
- typefeature:对于用户可见的新功能或对现有功能的改进。
- typemaintenance:非用户可见的产品改进,如:解决之前的技术债。
- ~"type::qa":测试相关的工作。
- ~"type::report":用于标记 Triage 自动生成的里程碑回顾报表。
或者你也可以直接添加子类型标记(例如 featureenhancement),我们会自动补全上述标记。要详细了解标记,请查阅文档:极狐 Handbook。
- 由 Fu Zhang 已解决 于
added 215 commits
-
db8a2157...8857264f - 212 commits from branch
main-jh
- de326948 - Update feishu_bot_handler.rb
- 3e911e3d - Update captcha_spec.rb
- 757d22c6 - Update query.rb
展开或隐藏提交列表-
db8a2157...8857264f - 212 commits from branch
- 由 🤖 JiHu Bot 🤖 已解决 于
这是此合并请求第一次被批准,现在可以开始做安全审查了。
@mtan-gitlab-cn,你能帮忙做安全审查吗(使用"批准"功能)?
added security-reviewpending label
added security-reviewapproved label and removed security-reviewpending label
mentioned in commit bd0c7b6b
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added resolve-graceful-rubocop label
unassigned @icbd