Changelog: other

This reverts commit b9adfe7995fa94d20f32506efdc8e84f3936dfc8.

We are dropping the work_item_types.namespace_id
column, so we first need to ignore it in this release (17.3)
so it can be dropped from the DB in 17.4

This updates some graphql specs to pass a Query::Context object rather than
a hash to conform to changes made in the graphql gem.

Changelog: fixed

Changelog: performance

Only in rspec context

Changelog: changed

- include concerns that can be reused
- implement methods and classes for Discussion
- add specs
- add adding type to notes migration

Changelog: other

Co-authored-by: David Fernandez <dfernandez@gitlab.com>

Usually if there are system notes that reference an item that
cannot be accessed by the user we filter out that system note
altogether.

This was not happening for system notes about adding or removing
a child work item or a parent work item.

Fix vulns metric sql

This change makes the Jira Cloud App integration only editable when the
integration has been activated, as we disable the ability for this
integration to be enabled and disabled in the normal way.

This means that when a user sees a disabled Jira Cloud App integration
they understand that they need to link a relevant group within the
app configuration first before the can enable the integration.

It also clarifies this in our docs, and within the integration form.

This change is behind the `enable_jira_connect_configuration` feature
flag.

https://gitlab.com/gitlab-org/gitlab/-/issues/460663

Changelog: other

Adds filtering of the `users` GraphQL field to by human users
and active users, through new optional `active: BOOLEAN` and
`human: BOOLEAN` arguments.

When the arguments are not provided the field will return the same users
as it does currently.

`UsersFinder` has been updated to allow:

- Scoping humans `humans: true`
- Scoping non-humans `without_humans: true`
- Scoping non-active users `without_active: true`

`/users` REST API endpoint has been updated to support the new users
finder params.

This work is to allows returning only active human users within a
user mapping search.

https://gitlab.com/gitlab-org/gitlab/-/issues/471933

Changelog: added

Co-authored-by: Lorena Ciutacu <lciutacu@gitlab.com>

We are dropping the work_item_widget_definitions.namespace_id
column, so we first need to ignore it in this release (17.3)
so it can be dropped from the DB in 17.4

- Includes associated refactorings to extract out
  common logic from settings module

- added logic for moving issue between lists
- added update card logic
- fixed flaky specs

If you start the input by tagging (@somebody) someone, and then
relocate the cursor to before the @, you could type to insert text,
but couldn't delete or otherwise interact with it (backspace and left
arrow keys don't respond). When switching to plain-text, anything
typed before the @ disappeared. This commit fixes the issue.

When the feature flag `retain_resource_access_token_user_after_revoke`
is enabled for a Project, inactive (expired or revoked) tokens will
be displayed in a table underneath a table of active tokens.

This works towards the resolution of
https://gitlab.com/gitlab-org/gitlab/-/issues/462217

Changelog: other

Changelog: changed
EE: true

Closes: https://gitlab.com/gitlab-org/gitlab/-/issues/460211
Changelog: changed

Since it is not used in production and never was, we remove it.

Changelog: changed

Omit start year and somtimes due year depending on whether or not the
two dates share the same year and whether or not that year is the
current year.

Changelog: changed
EE: true

Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Changelog: changed

Changelog: changed

For each user accessing GitLab.com, the access is tracked if it is
coming from PIPL-covered countries (by checking HTTP_CF_IPCOUNTRY
request env). If the access is coming from a non PIPL-covered country
and a previous access from a PIPL-covered country was tracked for the
same user, the access count from PIPL-covered countries is reset for
the user. This tracking is only done once every 24 hours for each user.

Further, if the user is determined to be subject to PIPL, a background job is
queued to check if the user belongs to any paid namespace. This is done because
users belonging to paid namespaces are exempt from actions taken to ensure PIPL
compliance.

We're unnecessarily running the n+1 check for each row in a large RSpec
table in an expensive API request spec.

This refactor moves the n+1 check out of the API spec and into the
finder specs used by the API endpoint.

Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/451904

Add EventDefinition#matching_rules

To support running multiple rake tasks in parallel based on separate
list files, we want to make the cursor tracker redis key include the
filename of the list it is processing. This way we will have a way to
resume correctly if ever one of the rake tasks gets interrupted.

This commit adds a private method `process_details()` to print the
process status before terminating it. It is used to determine why
praefect is not ready for connectting.

We also added a longer timeout before dropping praefect connection.