Changelog: other

In IMAP, `delete_after_delivery` only marks the message as deleted,
but a separate `expunge_deleted` step is needed to permanently remove
the message.

In Microsoft Graph, `delete_after_delivery` soft deletes the messages,
but the message is automatically expunged after a retention period,
typically 14 days. An admin can manually expunge deleted messages via
the command-line.

`delete_after_delivery` has been set to `true` since 712d1768 since it
wasn't necessary to configure this for IMAP, but it is necessary for
Microsoft Graph since this auto-expunge behavior may not be
desired. We now make this option configurable with `true` by default.

This requires Omnibus support:
https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6605

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/386770

Changelog: added

Changelog: fixed
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/362068

Issue: https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1590
Changelog: added

Recently, JwtAuthenticatable supports multi-secret secret per inherited
class. This use case is not suitable for mailroom JWT flow, which
includes one secret per mailbox. JwtAuthenticatable hasn't supported iat
verification to control token age.

- change code to send the db option
- change mail_room configuration file

This commit only changes the configuration template file in preparation
for upgrading MailRoom to support the Microsoft Graph API with OAuth2
instead of IMAP.

References:

1. https://gitlab.com/gitlab-org/gitlab/-/issues/214900
2. https://github.com/tpitale/mail_room/pull/125

This is the first step toward having a separate incoming email
address for service desk. It allows to configure mail_room to
listen on multiple email addresses (but we don't add
`service_desk_email` address into config file yet).

- add config option for `log_path`
- add default config option to example yml

mail_room was configured to deliver mail to the `incoming_email`
queue while `EmailReceiveWorker` was reading the `email_receiver`
queue. Adds a migration that repeats the work of a previous
migration to ensure all mails that wound up in the old
queue get processed.

Closes #23689

Added a comment to remember developers to open merge request to omnibus
in future changes of the file.

We will trust redis configuration params loading to Gitlab::RedisConfig.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Improve and finish the fallback to the In-Reply-To and References header for the reply-by-email feature

A few things to note:
- The IncomingEmail feature is now enabled even without a
  correctly-formatted sub-address
- Message-ID for new thread mail are kept the same so that subsequent
  notifications to this thread are grouped in the thread by the email
  service that receives the notification
  (i.e. In-Reply-To of the answer == Message-ID of the first thread message)
- To maximize our chance to be able to retrieve the reply key, we look
  for it in the In-Reply-To header and the References header
- The pattern for the fallback reply message id is "reply-[key]@[gitlab_host]"
- Improve docs thanks to Axil

Fixes #12731