Prior this commit, Cop/StaticTranslationDefinition would flag the
following code:

    SomeClass = Struct.new do
      def text
        _('Some translated text')
      end
    end

This commit allow such style again so workarounds are not longer needed
like:

    Struct.new('SomeClass') do
      def text
        _('Some translated text')
      end
    end

See https://gitlab.com/gitlab-org/gitlab/-/issues/341911

This adds a new base class for edges that uses our custom `BaseField`
as the standard field class.

We do not need to customize authorization for edges, since nodes are
redacted by our connections before edges are constructed from them.

All our edges should inherit from this base class in order to use field
customizations.

Changelog: changed

Gitlab::Database::Connection was a kitchen sink type of class: it had
methods for obtaining database information (e.g. the database name),
running WAL related queries, querying the status of transactions, and
more.

This commit splits this class into separate types. For example,
reflection related methods are now located in
Gitlab::Database::Reflection. Transaction related methods are moved into
the Transactions module. The method to get a WAL diff has been moved
into the LoadBalancer class.

With this also changes the use of these methods. For example, instead of
this:

    Gitlab::Database.main.cached_column_exists?(:users, :id)

You now write this:

    Users.database.cached_column_exists?(:id)

Apart from being shorter in many cases, it also decouples the code using
these methods from the main database. This makes it easier to support
multiple databases over time.

- for idempotent workers that are utilizing load balancing
- add specs to cover all usecases

Changes the rubocop to complain about usage for new
migrations.

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/339281

This commit extends our existing cop to catch false positives
when the table_name is a string or a constant.

Mark dynamic feature flags and feature flags for usage data counters
only once per whole rubocop run instead of once per file.

This reduces the overall runtime of this cop drastically:

    time bundle exec rubocop -C false -f q --only Gitlab/MarkUsedFeatureFlags

* Before: ~8m53.589s
* After: ~3m56.036s

Add taggings, ci_builds_metadata, and events to the list.

https://gitlab.com/gitlab-org/gitlab/-/issues/339280

Add a new cop that disallows common methods that use subtransactions
within their implementation: safe_ensure_unique and create_or_find_by
variants.

Add a new rubocop rule that prevents direct use of subtransactions,
meaning any call to #transaction with the options `requires_new: true`.

The logic was breaking for a path that included ee in its name other
than the ee/ directory, e.g. employee/ or gitlab-ee/. This is fixed
with a better detection of a file within the ee directory.

Disable all existing selector usages within spec and ee/spec

Changelog: added

Prior to this change, ignore rules for a columns were defined in CE or
EE models. But if a model exists in CE and EE, the ignore rule has to
be in the CE model. If the model only exists in EE, then it has to be
added there. A new rubocop rule will check for the correct location of
the ignore rule.

This module contained various methods that were forwarded to
Gitlab::Database::Connection. This commit removes these wrappers in
favour of using Gitlab::Database.main instead. This is done to make it
explicit what database connection should be used.

See https://gitlab.com/gitlab-org/gitlab/-/issues/331776 and
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/65262 for more
information.

Remove the application code that populates the ci_build_trace_sections
and ci_build_trace_section_names. This data is not read by the
application currently and we can save on space/maintaince and solve
problems with background migration for self-managed users by dropping
the table is subsequent MRs.
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/66674

This table was originally created to collect metrics on jobs but was
never used and an expiration policy of was never enforced.
https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2505

There is the possibility that we will need to build out features that
need this data in the future, based on the future vision, but at this
time it is not being used, and we can re-add it while re-considering
the architecture at that time (likely in 2022).
https://gitlab.com/gitlab-org/gitlab/-/issues/32565

in prep for interpreter

instead of old ones

This ensures developers consider scalability and immediacy
trade-offs by either using or not using the DB primary.

Rubocop rule to prevent referencing ActiveRecord::Base.connection.

This commit adds a new custom cop allowing us to prevent
index creation on a given table. The first table forbidden
is ci_builds.