Also supported with hotkeys: ';' and 'shift+;'

Changelog: added

Fix running specs in Vue 3 with equality checks

Use 'file' query param instead of 'pin'

We move the warning in merge request that tell
users some files are not shown to the diff panel
instead of the main panel. This in effect means that
when the files panel is opened, the alert is not above
both the files and the diff, but instead under the diff
side and so take only half of the space. This change is so
that the message is more contextualized in the user reading
experience of the code.

Changelog: changed

Annabel Dunstone Gray 创作于 10 months ago ，Stanislav Lashmanov 提交于 10 months ago

Hide toggle review tooltip when clicked

Changelog: changed

- Handle hash changes that occur when the Diffs app is running
- Trigger the fetchFileByFile action, which loads a local
    version if possible

Changelog: fixed

- update for Vue 3

- update createComponent method to be easier to use

This MR completely removes the frontend implementation of the sast_reports_in_inline_diff feature flag.
It includes the elimination of all conditional logic that was used to toggle between the old and new versions of inline findings.
Furthermore, this change also encompasses the removal of the frontend code related to the older inline-findings implementation.

EE: true

Changelog: removed

Before we had websockets on the notes app we would have to
request all the discussions on a merge request before we could
render any submitted review notes.
With websockets we fetch individual notes after a review is submitted
so we no longer need to fetch all discussions.

Changelog: fixed

This commit is a piece of solving: https://gitlab.com/gitlab-org/gitlab/-/issues/419177
It refactors the fetching of the SAST Inline Finding from
REST to GraphQl.

EE: true

This fixes a bug where the file comment form would not
open when the user visits the diff page with a link to a specific
diff file.

This is used in some places of the Diffs app, but has never
been centralized as far as I know.

This commit refactors the inline-findings Drawer from the
inline-findings components to the inline-findings dropdown components.
It removes the code_quality_inline_drawer flag and ties the behaviour
to the sast_reports_in_inline_diff flag.

EE: true
Changelog: changed

We are moving away from VueX in favour of Vue
and ApolloClient. We want to ling against new
VueX imports to make sure to warn developers
not to introduce new stores.

Changelog: added

This commit adds inline SAST findings to the
MR Diff view.

EE: true

Diff discussions for images now properly display on the merge request Overview page

Changelog: fixed

This is the revert of

- a611280443ab263d75351f52aaf97fa6ffa6d03f (an abbreviation fix)
- 4690b20c078d688ec71c92bea936879d53b7b0fd (an abbreviation fix)
- 92e829747d8fd6ccbe4843a1d84b145adc9cbc43 (implement the feature flag)

In that order, to cleanly apply all the reverts.

Then, it RE-implements 4690b20c078d688ec71c92bea936879d53b7b0fd to
avoid an unnecessary variable name abbreviation in app.vue.

Remove cases where wrapper.destroy() is called inside if block in the
afterEach or afterAll, these cases are not triggering the linter rule,
but they should still be removed.

Adds a button to the diff file actions dropdown to allow
users to generate a test file for that diff file.

https://gitlab.com/gitlab-org/gitlab/-/issues/407778

As a top-level module in `~/lib` is fine, there's no need to nest it
under `~/lib/utils`.

We do technically lint for default exports, but currently opt out in
GitLab due of the sheer number of violations. Anyway, we might as well
use a named export since we're wrapping Mousetrap.

This new ~/lib/utils/mousetrap file is similar to
~/lib/utils/axios_utils, in that it augments the raw package.

In particular, it makes it slightly easier to update Mousetrap's
`stopCallback` method.

They `Shortcut#addStopCallback` is an instance method rather than static
methods to encourage access via the (in theory) singleton Shortcuts
instance.

A problem this does not solve is the race between our overwriting of
`Mousetrap#stopCallback` and the `pause` plugin's overwriting of it:
https://github.com/ccampbell/mousetrap/blob/1.6.5/plugins/pause/mousetrap-pause.js#L10-L18.

If the `pause` plugin is loaded first, then our subsequent overwrites
will no longer be subject to the paused status of Mousetrap.

The bulk import path rename was done using this command:

    comby "import :[[name]] from 'mousetrap';" \
        "import :[name] from '~/lib/utils/mousetrap';" \
        {ee/,}{spec/frontend,app/assets/javascripts}/**/*.{js,vue} -i

See https://comby.dev/ for details about comby.

Finally, a redundant Mousetrap Jest mock has been removed, as the
package has provided a CommonJS module since v1.5.0:
https://github.com/ccampbell/mousetrap/releases/tag/1.5.0

In `viewDiffsFileByFile` mode, the app will wait until the diffs
metadata is loaded - this basic amount of information is absolutely
crucial to being able to load one file - and then trigger the
`fetchFileByFile` action.

This is INSTEAD of the unscoped triggering of the
`fetchDiffFilesBatch` action, which doesn't need the metadata in
order to begin. `fetchDiffFilesBatch` is entirely skipped in
file-by-file mode.

When using the file-by-file sibling navigation buttons, we also
need to trigger the `fetchFileByFile` action, since simply updating
the current diff file hash in the store is not enough to show that
file (since it's not yet loaded, we have to fetch it).

Changelog: changed

This commit solves: https://gitlab.com/gitlab-org/gitlab/-/issues/393046
It adds a new drawer which can be opened from the CodeQuality
Inline findings displaying more details about the finding.

Changelog: changed
EE: true

Andrei Zubov 创作于 2 years ago ，Vitaly Slobodin 提交于 2 years ago

* update @gitlab/eslint-plugin to the 18.2.0
* enable vtu-no-explicit-wrapper-destroy rule for spec files

In preparation for single-file-only file-by-file review,
the UI must always refer to the FULL list of files for
identifying order, finding files by hash, total number of
files, and more. Since `diffFiles` could be empty, `diffFilesMeta`
is the authority on these meta-values.

Remove file tree worker

Remove async loading of virtual scrolling components

Converts 200s to HTTP_STATUS_OK constants
in frontend code to avoid magic numbers

The feature flag has been enabled by default for multiple
milestones and no issues were found/reported.

This removes the feature flag and keeps the new code.

Changelog: other