Promote to blocking: Govern Mattermost login user logs into Mattermos...

Merge branch 'overdue-finalize-background-migration--backfill-approval-group-rules-users-group-id' into 'master' 

Finalize migration BackfillApprovalGroupRulesUsersGroupId

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167250



Merged-by: Dylan Griffith <dyl.griffith@gmail.com>
Approved-by: Dylan Griffith <dyl.griffith@gmail.com>
Reviewed-by: Joe Woodward <jwoodward@gitlab.com>
Co-authored-by: gdk <gdk@example.com>

Second pass edit of project API documentation

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167398



Merged-by: Marcel Amirault <mamirault@gitlab.com>
Approved-by: Marcel Amirault <mamirault@gitlab.com>
Reviewed-by: Marcel Amirault <mamirault@gitlab.com>
Co-authored-by: Evan Read <eread@gitlab.com>

Co-authored-by: Marcel Amirault <mamirault@gitlab.com>

This migration was finished at `2024-07-19 09:08:39 UTC`, you can confirm
the status using our
[batched background migration chatops commands](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html#monitor-the-progress-and-status-of-a-batched-background-migration).
  To confirm it is finished you can run:

  ```
/chatops run batched_background_migrations status 1000621
```

The last time this background migration was triggered was in [db/post_migrate/20240716135356_queue_backfill_approval_group_rules_users_group_id.rb](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20240716135356_queue_backfill_approval_group_rules_users_group_id.rb)

  You can read more about the process for finalizing batched background migrations in
https://docs.gitlab.com/ee/development/database/batched_background_migrations.html .

  As part of our process we want to ensure all batched background migrations have had at least one
[required stop](https://docs.gitlab.com/ee/development/database/required_stops.html)
to process the migration. Therefore we can finalize any batched background migration that was added before the
last required stop.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::OverdueFinalizeBackgroundMigration keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: other

Fix Performance/RegexpMatch offenses

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/166706



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Reviewed-by: Thong Kuah <tkuah@gitlab.com>
Reviewed-by: Pavel Shutsin <pshutsin@gitlab.com>
Co-authored-by: Bola Buari <bola_ahmed2002@yahoo.com>

Update OCS documentation with vuln resolution details

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167513



Merged-by: Russell Dickenson <rdickenson@gitlab.com>
Approved-by: Russell Dickenson <rdickenson@gitlab.com>
Co-authored-by: smtan <smtan@gitlab.com>

Add missing feature category to routing specs

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167289



Merged-by: Luke Duncalfe <lduncalfe@gitlab.com>
Approved-by: Luke Duncalfe <lduncalfe@gitlab.com>
Co-authored-by: Andy Soiron <asoiron@gitlab.com>

E2E test: remove view_merge_requests_spec from quarantine

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167276



Merged-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: Tarun Khandelwal <tkhandelwal@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Co-authored-by: Jay McCure <jmccure@gitlab.com>

This reverts merge request !165905

Backfill PATs seven_days_notification_sent_at column

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/165592



Merged-by: Tiger Watson <twatson@gitlab.com>
Approved-by: Dominic Bauer <dbauer@gitlab.com>
Approved-by: Smriti Garg <sgarg@gitlab.com>
Approved-by: Tiger Watson <twatson@gitlab.com>
Reviewed-by: Tiger Watson <twatson@gitlab.com>
Reviewed-by: Dominic Bauer <dbauer@gitlab.com>
Co-authored-by: agius <andrew@atevans.com>

Includes a batched background migration to backfill the column using the
`expired_at` dates. Also creates a temporary index for the BBM.

Changes `PersonalAccessTokens::ExpiringWorker` to dual-write to both
`expire_notification_delivered` boolean column and the replacement
`seven_days_notification_sent_at` column.

Changelog: changed

Docs: Specify source of Advanced SAST ruleset

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167106



Merged-by: Russell Dickenson <rdickenson@gitlab.com>
Approved-by: Russell Dickenson <rdickenson@gitlab.com>
Reviewed-by: Connor Gilbert <cgilbert@gitlab.com>
Co-authored-by: Connor Gilbert <cgilbert@gitlab.com>

Add milestone numbers to DAST image names

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167504



Merged-by: Russell Dickenson <rdickenson@gitlab.com>
Approved-by: Russell Dickenson <rdickenson@gitlab.com>
Co-authored-by: Amy Qualls <aqualls@gitlab.com>

Reconstruct what milestone these images were added in.

Remove outdated caveats about "blocked" pipelines

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167281



Merged-by: Russell Dickenson <rdickenson@gitlab.com>
Approved-by: Alana Bellucci <abellucci@gitlab.com>
Approved-by: Russell Dickenson <rdickenson@gitlab.com>
Co-authored-by: Katrin Leinweber <kleinweber@gitlab.com>

Lint issue fix in Layout/LineEndStringConcatenationIndentation 9

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/164700



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Stan Hu <stanhu@gmail.com>
Co-authored-by: Archish <archishthakkar@gmail.com>

Add complementary tests for diffs to assert track metrics calls

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/164645



Merged-by: Lee Tickett <ltickett@gitlab.com>
Approved-by: Marina Mosti <mmosti@gitlab.com>
Approved-by: Olena Horal-Koretska <ohoralkoretska@gitlab.com>
Reviewed-by: Marina Mosti <mmosti@gitlab.com>
Co-authored-by: Wilson Pinto <wilsonpinto360@gmail.com>

Lint issue fix in Layout/LineEndStringConcatenationIndentation 11

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/164691



Merged-by: Dmitry Gruzd <dgruzd@gitlab.com>
Approved-by: Dmitry Gruzd <dgruzd@gitlab.com>
Co-authored-by: Archish <archishthakkar@gmail.com>

Updates to feature flag rollout template

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/159012



Merged-by: Dylan Griffith <dyl.griffith@gmail.com>
Approved-by: Dylan Griffith <dyl.griffith@gmail.com>
Co-authored-by: Jessie Young <jessieyoung@gitlab.com>

* This is a common roll out approach but was not reflectedin the isuse
  template

Unquarantine wiki e2e specs

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167480



Merged-by: Tiffany Rea <trea@gitlab.com>
Approved-by: Tiffany Rea <trea@gitlab.com>
Co-authored-by: Desiree Chevalier <dchevalier@gitlab.com>

Bump duo-workflow-executor version to v0.0.9

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167256



Merged-by: Jessie Young <jessieyoung@gitlab.com>
Approved-by: Jessie Young <jessieyoung@gitlab.com>
Co-authored-by: Andrew Fontaine <afontaine@gitlab.com>
Co-authored-by: Dylan Griffith <dyl.griffith@gmail.com>

This corresponds to the tagged version we just created in
https://gitlab.com/gitlab-org/duo-workflow/duo-workflow-executor/-/pipelines/1472831822

Resolve "Allow testing AI features after the cut_off date on Gitlab.com staging environment"

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/165312



Merged-by: Alejandro Rodríguez <alejandro@gitlab.com>
Approved-by: Sam Figueroa <sfigueroa@gitlab.com>
Approved-by: Alejandro Rodríguez <alejandro@gitlab.com>
Reviewed-by: Alejandro Rodríguez <alejandro@gitlab.com>
Reviewed-by: Matthias Käppler <mkaeppler@gitlab.com>
Co-authored-by: Nikola Milojevic <nmilojevic@gitlab.com>

- Add specs
- The feature flag is only accessible for Self-Signed on Staging and for dev and testing environments.

Remove redundant pipeline spec

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167373



Merged-by: Chloe Liu <yliu@gitlab.com>
Approved-by: Richard Chong <rchong@gitlab.com>
Approved-by: Chloe Liu <yliu@gitlab.com>
Co-authored-by: treagitlab <trea@gitlab.com>

Move more troubleshooting to main GitLab repo

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167493



Merged-by: Phillip Wells <pwells@gitlab.com>
Approved-by: Phillip Wells <pwells@gitlab.com>
Reviewed-by: Phillip Wells <pwells@gitlab.com>
Co-authored-by: Amy Qualls <aqualls@gitlab.com>

Transfer this information over from the external repo, adapting it to
the processes and features of the GitLab main documentation.

Validate Geo queues exist before queue draining checks

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/166795



Merged-by: Douglas Barbosa Alexandre <dbalexandre@gmail.com>
Approved-by: Sylvester Chin <schin@gitlab.com>
Approved-by: Douglas Barbosa Alexandre <dbalexandre@gmail.com>
Reviewed-by: Michael Kozono <mkozono@gitlab.com>
Co-authored-by: Mike Kozono <mkozono@gitlab.com>

Update dependency @gitlab/ui to v94.4.2

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167406



Merged-by: Paul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
Approved-by: Paul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
Co-authored-by: Paul Gascou-Vaillancourt <paul.gascvail@gmail.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>

Add `work_item_types.correct_id` column

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/166548



Merged-by: Mario Celi <mcelicalderon@gitlab.com>
Approved-by: Fabien Catteau <fcatteau@gitlab.com>
Approved-by: Dylan Griffith <dyl.griffith@gmail.com>
Approved-by: Nicolas Dular <ndular@gitlab.com>
Approved-by: Fred Reinink <freinink@gitlab.com>
Reviewed-by: Mario Celi <mcelicalderon@gitlab.com>
Reviewed-by: Fred Reinink <freinink@gitlab.com>

Edits to namespaces doc

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167496



Merged-by: Amy Qualls <aqualls@gitlab.com>
Approved-by: Amy Qualls <aqualls@gitlab.com>
Co-authored-by: Emily Sahlani <esahlani@gitlab.com>