Skip to content
代码片段 群组 项目
未验证 提交 ba67bc39 编辑于 作者: Thong Kuah's avatar Thong Kuah 提交者: GitLab
浏览文件

Merge branch 'revert-3ed47186' into 'master'

E2E test: remove view_merge_requests_spec from quarantine

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167276



Merged-by: default avatarThong Kuah <tkuah@gitlab.com>
Approved-by: default avatarTarun Khandelwal <tkhandelwal@gitlab.com>
Approved-by: default avatarThong Kuah <tkuah@gitlab.com>
Co-authored-by: default avatarJay McCure <jmccure@gitlab.com>
No related branches found
No related tags found
无相关合并请求
......@@ -4,17 +4,13 @@
module QA
RSpec.describe 'Create' do
describe 'Merge Requests', product_group: :code_review,
quarantine: {
issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/483173',
type: :investigating
} do
describe 'Merge Requests', product_group: :code_review do
let(:address) { Runtime::Address.new(:gitlab, '') }
context 'with a malformed URL' do
let(:path) { %(/-/merge_requests?sort=created_date&state=<th:t=\"%24{dfb}%23foreach) }
it 'returns 400', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/426509' do
it 'returns 400 or 302', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/426509' do
# Ruby's URI module automatically encodes query parameters:
# https://github.com/ruby/uri/blob/f4999b61daa40f2c99fdc7159e2c85c036b22c67/lib/uri/generic.rb#L849
#
......@@ -28,7 +24,9 @@ module QA
request = Net::HTTP::Get.new(path)
response = http.request(request)
expect(response.code.to_i).to eq(400)
# URL normalization in live environments can result in a 302
# https://gitlab.com/gitlab-org/gitlab/-/issues/483173#note_2126564107
expect(response.code.to_i).to eq(400).or eq(302)
end
end
end
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册