Chad Woolley 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

- Use correct group
- Rename category role to remote_development_be

- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120964

This prevents errors like:

[!] Invalid `Dangerfile` file: undefined method `present?' for
Danger gem might fix the issue. Your Danger version: 8.6.1, latest
Danger version: 9.3.0

For all new added migrations, the timestamp is checked against current
date and if it's older than three weeks, a warning is displayed in the
Danger message.

New CI tables that reference large tables should be
should be partitioned from the start.

- Skip database warnings
- Skip product intelligence review
- Skip data team warnings

Also remove these file from RuboCop TODOs

In order to add a suggestion you now need to:
1. Create a suggestion and specs
2. Add suggestion class to SUGGESTIONS constant
3. There is no step 3

When making an update or change to the GraphQL API,
the exiting, updated or new frontend components must remain -
backwards-compatible with the existing version of the GraphQL API.

MR authors and reviewers should be warned when they are changing
both frontend and backend GraphQL code.

Add a comment to MRs targeting stable branches
on canonical when the package-and-test job fails

The execution of package-and-test pipeline is required on merge request
targeting stable branches as a way to guarantee the changes introduced
are compliant from the Quality side. This is not necessary for
documentation changes or for merge request fixing flaky failures, so in
this case it's fine to skip the Danger message.

This commit updates the stable branch checks to skip the
package-and-test message on trivial merge requests with documentation
changes only or with fixes for flaky failures.

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2839

Danger checks include a QA one to verify if a QA selector was modified,
and in this case, encourage the execution of the package-and-test
pipeline. Stable branches automatically trigger the package-and-test
pipeilne to guarantee changes are compliant from the Quality side.

Because of the above, this commit removes the QA check from stable
branches.

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2839

Currently, the 'QA package-and-test' section in Danger appears to be
part of the Reviewer Roulette (or the previous Danger section). This
commit splits the QA into a dedicated Danger section.

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2839

At the moment, merge requests prepared in canonical are either:

* Preparation branches created by release managers
* Backport requests approved.

In both cases, the `Pick into x.x` is not necessary. This commit removes
a unuseful message from Danger.

Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2839

Danger bot comments on merge request with
a note linking to documentation when there is a change
of sidekiq worker arguments

- Fail Danger on stable branches with pipeline::expidite
- Add message detailing what to do on package-and-test
  failures on stable branch MRs
- Check package-and-test status and fail if it has not
  started running

This reverts merge request !111616

Signed-off-by: Rémy Coutable <remy@rymai.me>

See https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1294

Signed-off-by: Rémy Coutable <remy@rymai.me>

Pavel Shutsin 创作于 2 years ago ，João Cunha 提交于 2 years ago

No user facing changes here. Only refactoring
for future queries improvements.

Changelog: changed

See https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1294

Show a danger warning if BOT_USER_TYPES was changed

Danger will fail on canonical when targeting a stable branch and
- labeled with feature
- not labeled with bug
- targets a branch outside the maintenance policy

This reverts commit 6496911bac582f474b43c057d50277eace2b01b9.

Merge branch 'update-security-with-canonical-changes' into 'master'

See merge request gitlab-org/security/gitlab!2944

Changelog: security

This MR adds warning if changed scope might potentially affect metrics