In case of `have_gitlab_http_status(-1)` we've seen an
`RuboCop::Runner::InfiniteCorrectionLoop` error after upgrading RuboCop.

This commits side-steps this problem by checking if replacement is not
identical to the previous source version.

Since migrations for EE models don't have factories in CE we need to
skip this cop in foss-only CI.

This commit also simplifies the implementation and improves the
performances be caching files operations.

Signed-off-by: Nailia Iskhakova <niskhakova@gitlab.com>

Using `change_column_null` migration helper can cause issues if it's
used for a high-traffic table as it requires locking the whole table.

Enforce `safe_format` for externalized strings with interpolations and
`.html_safe`.

  # bad
  _('string %{open}foo%{close}').html_safe % { open: '<b>'.html_safe, close: '</b>'.html_safe }
  format(_('string %{open}foo%{close}').html_safe, open: '<b>'.html_safe, close: '</b>'.html_safe)

  # good
  safe_format(_('string %{open}foo%{close}'), tag_pair(tag.b, :open, :close)
  # also good no `html_safe`
  format(_('string %{var} number'), var: var)

- add bad format and enforce pattern.

- add rubocop to lint on use of Current.organization outside
  of approved app layers.
- see https://gitlab.com/gitlab-org/gitlab/-/issues/442751 for
  details

```
      # # bad
      # class SomeService
      #   def execute
      #     do_something_with(Current.organization)
      #   end
      # end
      #
      # # good
      # class SomeController < ApplicationController
      #   def create
      #     response = SomeService.new(organization: Current.organization).execute
      #   end
      # end
      #
      # class SomeService
      #   def initialize(organization:)
      #     @organization = organization
      #   end
      #
      #   def execute
      #     do_something_with(@organization)
      #   end
      # end
```

- This can cause issues as seen in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142303#note_1781915037
  Where rails will start enumerating until that date hits.
  That makes it more likely to hit a merge conflict with other migrations.

The BackgroundMigration/DictionaryFile relies upon the contents
of the files in db/docs/batched_background_migrations/ as well as
the Ruby source file of the background migration.

Currently, the Rucocop results cache will not be updated if the
contents of the docs folder changes, which leads to false positives
and negatives.

This change includes the contents of the docs folder in the cache
checksum, so any changes in that directory will bust the result cache.

Changelog: added

* When `limit:` is not supported
* When table method is unknown

when encountering a table name stored in a constant.

This avoids a rubocop crash.

In https://docs.gitlab.com/ee/development/secure_coding_guidelines.html#token-prefixes
we mandate that tokens are prefixed, so that they can be detected by
secret detection if leaked. Now that many of our tokens have prefixes
we should enforce this for new additions.

Proactively including a prefix increases efficiency: developers don't
need to go back and add a prefix later, there's no worries about
needing to rotate existing tokens later, no need for feature flagged
rollout, etc.

The rubocop has been disabled for existing violations with either a
wontfix comment, or a TODO with issue URL comment. The rationale for
these decisions is at
https://gitlab.com/gitlab-org/gitlab/-/issues/439007#note_1740969806

Resolves https://gitlab.com/gitlab-org/gitlab/-/issues/439007

Signed-off-by: Rémy Coutable <remy@rymai.me>

Fix some typos

Put this cop in "grace period" to allow offenses for this cop in MR pipelines.

The page at https://docs.gitlab.com/ee/development/uploads.html no
longer exists, with upload docs having been moved into
https://gitlab.com/gitlab-org/gitlab/-/tree/master/doc/development/uploads.

This MR updates the Rubocop guidance to point to the new location.

Stan Hu 创作于 1 year ago ，Lin Jen-Shin 提交于 1 year ago

This commit fixes two types of Rubocop failures seen only with Ruby 3.2:

* Style/ArgumentsForwarding: As explained in
  https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/ArgumentsForwarding,
  in Ruby 3.2, anonymous args/kwargs forwarding has been added. This cop can
  be disabled by setting `UseAnonymousForwarding: false`.

* Lint/RedundantRequireStatement: As explained in
  https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Lint/RedundantRequireStatement,
  `require 'set'` is no longer needed in Ruby 3.2. But since we still
  need to support Ruby 3.1 and earlier, disable this cop on `require 'set'`
  lines.

Relates to
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140815#note_1712305597

Ban use of License in ApplicationSetting model to avoid cyclical dependency

Changelog: other
EE: true

See https://gitlab.com/gitlab-org/gitlab/-/issues/435940#note_1703307479

We should flag the usage of pluck without a proper limit
to avoid database performance degradation.

https://gitlab.com/gitlab-com/gl-infra/production/-/issues/17168

Changelog: changed

Update documentation

Using a number is causing problems for milestones like `15.10` as this
gets converted to 15.1 when loaded via YAML. Therefore we must use a
string for the milestone. We are already using strings for milestone in
the db/docs/*.yml files that correspond to tables.

The migration helper's current version is v2.2.

- Add a new rubocop to validate the `introduced_by_url`
  url

Changelog: added
Relates to: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/137970

Adds database migration and model definitions necessary for the model registry project setting

Changelog: added
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138399

Changelog: added

* Before the name "GitLab Duo" existed, we called Duo Chat "Tanuki Bot".
  As a result, there is a lot of code in gitlab-org/gitlab that references
  this old name.
* The code here was using the old name and is no longer used
* https://gitlab.com/gitlab-org/gitlab/-/issues/431311
* https://gitlab.com/gitlab-org/gitlab/-/issues/431310

- this method was never intended to be called outside of the module,
  but has been. So we'll add it here to encourage proper use
  as documented in https://docs.gitlab.com/ee/development/ee_features.html#saas-only-feature

Inspired by the ActiveRecord migration classes

Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/421591

Follow-up for
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/132111

* Remove `Gitlab::RuggedInstrumentation`
* Remove `Peek::Views::Rugged`
* Remove lint-rugged script
* Adjust tests and documentation

Changelog: removed

- move the check to the left a bit and allow developer
  to detect the issue quicker before danger.

These methods don't have retry in their implementation
and require it from outside.