When a file is just moved around it appears in the changed files list
but the diff is empty so we are skipping it.

This adds a new Dangerfile to do some Tailwind-related reporting.
Currently, we check whether the diff potentially contains interpolated
CSS utils. We might extend this rule to report additional info about CSS
utils usages.

We are using PNG instead of SVGs for compatibility with email
notifications.

Catch JSON parser error

This commit resolves the following warnings:
  gitlab/danger/saas_feature/Dangerfile:3:
    warning: already initialized constant Danger::Dangerfile::SEE_DOC
  gitlab/danger/feature_flag/Dangerfile:3:
    warning: previous definition of SEE_DOC was here

Ideally, the code should go into danger plugins to side-step any
namespace issues.

Add specs for ci template check tooling

Fix the formatting and file path with changes.category method

Add check! spec and fix a bug in existing code

Link to documentation page to provide in-depth information about
Reviewer Roulette.

- todo files should not be added to. They are meant for
  eventually resolving, not as a forever list of exceptions.

The checks here are superseded by the Pajamas Adoption Scanner,
implemented in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/141368 and
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142704.

Part of https://gitlab.com/gitlab-org/gitlab/-/issues/367738.

- similar to update, destroy, etc, this method should require
  database review

Update the links in code and autogenerated docs

- from feedback

Also improve clarify messeage posted to run e2e test pipeline

- removed during initial deployment for backfilling, see
  https://gitlab.com/gitlab-org/gitlab/-/merge_requests/133236#note_1600494778

Solutions and Development docs do not need reviews
from Technical Writers, but MRs with edits in these
sections should follow specialized directions.

Danger defines its own `fail` method which caused false positives and
forced inline disables.

When removing files, contributors might forget to remove the related
rubocop todos. To avoid that, this new Danger plugin will add comments
on MRs on deleted files that still have related rubocop todos.

Changelog: added

This check detects usage of `change_column_default` in migrations,
and adds a comment to the changed lines, indicating the need to
explicitly declare this column as changing default.

Changelog: changed

- errantly added warning that should only be for feature flags
- see https://gitlab.com/gitlab-org/gitlab/-/merge_requests/133236

Doug Stull 创作于 1 year ago ，Lin Jen-Shin 提交于 1 year ago

- needed for extra verification

Doug Stull 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

- added guidance and context suggestions.

This check detects the use of `remove_column` or
`cleanup_concurrent_column_rename` and adds a
comment to the changed lines, indicating the need
for ignoring the columns in the proper model

Changelog: changed

- Mention group
- Label support

charlie ablett 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

- Mention group
- Label support

This change removes `data-testid` warnings when tests have changed.

The warnings are meant to prevent breakage when production code changes
and the tests have not yet passed, not the other way around.

- sometimes roulette suggests a reviewer and by the time
  the author of the MR is ready to review, they are busy.
  This can be due to their limit on number of reviews they
  have assigned at once. We should add some verbiage to help
  guide MR authors to observe this.