Skip to content
GitLab
菜单
为什么选择 GitLab
定价
联系销售
探索
为什么选择 GitLab
定价
联系销售
探索
登录
获取免费试用
主导航
搜索或转到…
项目
GitLab
管理
动态
成员
标记
计划
议题
议题看板
里程碑
迭代
需求
代码
合并请求
仓库
分支
提交
标签
仓库图
比较修订版本
代码片段
锁定的文件
构建
流水线
作业
流水线计划
测试用例
产物
部署
发布
Package registry
容器镜像库
模型注册表
运维
环境
Terraform 模块
监控
事件
服务台
分析
价值流分析
贡献者分析
CI/CD 分析
仓库分析
代码评审分析
议题分析
洞察
模型实验
效能分析
帮助
帮助
支持
GitLab 文档
比较 GitLab 各版本
社区论坛
为极狐GitLab 提交贡献
提交反馈
隐私声明
快捷键
?
新增功能
4
代码片段
群组
项目
显示更多面包屑
gitlab-cn
GitLab
提交
d879f3f1
提交
d879f3f1
编辑于
1 year ago
作者:
Marcel Amirault
提交者:
Rémy Coutable
1 year ago
浏览文件
操作
下载
补丁
差异文件
Update danger for architecture docs
上级
6f68c2dc
No related branches found
No related tags found
无相关合并请求
变更
2
隐藏空白变更内容
行内
左右并排
显示
2 个更改的文件
danger/architecture/Dangerfile
+1
-1
1 个添加, 1 个删除
danger/architecture/Dangerfile
danger/documentation/Dangerfile
+15
-10
15 个添加, 10 个删除
danger/documentation/Dangerfile
有
16 个添加
和
11 个删除
danger/architecture/Dangerfile
+
1
−
1
浏览文件 @
d879f3f1
...
...
@@ -15,7 +15,7 @@ BLUEPRINT_LONG_MESSAGE = <<~MSG
#{
BLUEPRINT_SHORT_MESSAGE
}
F
ollowing files,
that may
require the additional review, have been changed:
The f
ollowing files,
which might
require the additional review, have been changed:
#{
helper
.
markdown_list
(
blueprint_changes
.
to_set
)
}
MSG
...
...
此差异已折叠。
点击以展开。
danger/documentation/Dangerfile
+
15
−
10
浏览文件 @
d879f3f1
...
...
@@ -13,8 +13,9 @@ docs_paths_to_review = helper.changes_by_category[:docs]
# Some docs do not need a review from a Technical Writer.
# In these cases, we'll output a message specific to the section.
sections_with_no_tw_review
=
{
'doc/solutions'
=>
[],
'doc/development'
=>
[]
'doc/architecture'
=>
[],
'doc/development'
=>
[],
'doc/solutions'
=>
[]
}.
freeze
# One exception to the exceptions above: Technical Writing docs should get a TW review.
...
...
@@ -36,12 +37,12 @@ def add_labels(labels)
helper
.
labels_to_add
.
concat
(
%w[documentation type::maintenance maintenance::refactor]
+
labels
)
end
SOLUTIONS
_MESSAGE
=
<<~
MSG
This MR contains docs in the /
solutions directory and should be reviewed by a Solutions Architect approver
. You do not need tech writer review.
ANY_MAINTAINER_CAN_MERGE
_MESSAGE
=
<<~
MSG
This MR contains docs in the /
%<directory>s directory, but any Maintainer (other than the author) can merge
. You do not need tech writer review.
MSG
DEVELOPMENT
_MESSAGE
=
<<~
MSG
This MR contains docs in the /d
evelopment directory. Any Maintainer, other than the author, can merge
. You do not need tech writer review.
SOLUTIONS
_MESSAGE
=
<<~
MSG
This MR contains docs in the /d
oc/solutions directory and should be reviewed by a Solutions Architect approver
. You do not need tech writer review.
MSG
# For regular pages, prompt for a TW review
...
...
@@ -76,14 +77,18 @@ MSG
# Output messages
warn
(
DOCUMENTATION_UPDATE_MISSING
)
if
docs_paths_to_review
.
empty?
&&
feature_mr?
if
sections_with_no_tw_review
[
"doc/solutions"
].
any?
add_labels
(
SOLUTIONS_LABELS
)
message
(
SOLUTIONS_MESSAGE
)
if
sections_with_no_tw_review
[
"doc/architecture"
].
any?
message
(
format
(
ANY_MAINTAINER_CAN_MERGE_MESSAGE
,
directory:
'doc/architecture'
))
end
if
sections_with_no_tw_review
[
"doc/development"
].
any?
add_labels
(
DEVELOPMENT_LABELS
)
message
(
DEVELOPMENT_MESSAGE
)
message
(
format
(
ANY_MAINTAINER_CAN_MERGE_MESSAGE
,
directory:
'doc/development'
))
end
if
sections_with_no_tw_review
[
"doc/solutions"
].
any?
add_labels
(
SOLUTIONS_LABELS
)
message
(
SOLUTIONS_MESSAGE
)
end
unless
docs_paths_to_review
.
empty?
...
...
此差异已折叠。
点击以展开。
预览
0%
加载中
请重试
或
添加新附件
.
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
保存评论
取消
想要评论请
注册
或
登录