The `@gitlab/vue-prefer-dollar-scopedslots` rule was enabled by default
in `@gitlab/eslint-plugin@15.0.0` (see the [changelog][1]), and we
already depend on 16.0.0, so this can be removed.

Part of
https://gitlab.com/gitlab-org/frontend/eslint-plugin/-/issues/54.

[1]: https://gitlab.com/gitlab-org/frontend/eslint-plugin/-/blob/main/CHANGELOG.md#1500-2022-07-29

- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/92775

This enables the @gitlab/vue-prefer-dollar-scopedslots rule, fixes the
simplest cases, and ignores the rest.

The simplest type of violation is in renderless components which just
render their default slots. These are fully migrated.

The other types are more subtle, and will need to be migrated separately
later.

The main subtlety is that these two expressions aren't equivalent:

    Boolean(this.$slots.foo)

    Boolean(this.$scopedSlots.foo)

The former evaluates to `false` if either the `foo` slot isn't provided,
or if the provided `foo` slot has no content.

The latter only evaluates to `false` if the `foo` slot is not provided.

The simplest way to make these equivalent would be to call the slot
function in the second case:

    Boolean(this.$scopedSlots.foo())

But, depending on where this code lives, it may be called too often, or
worse, have side effects.

The best way to migrate each of these will need to be worked out
case-by-case.

Part of https://gitlab.com/groups/gitlab-org/-/epics/8367.

Dynamic imports with non-literal expressions for the path can cause
problems in the build process, so we disallow it in regular code.
In specs, there is no build process, so the lint rule need not apply.

See https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/2322 for
why it's disallowed in regular code.

It's a common pattern in Jest to rewrite imports with mocks.

This enables the unicorn/prefer-dom-node-dataset ESLint rule to prevent
using attributes APIs when manipulating data- attributes.

Revert "Merge branch '344000-add-typedefs-for-all-occurences-of-client-graphql-operations' into 'master'"

This reverts merge request !90125

- added missing type definitions for @client operations

This reverts merge request !87730

In
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/85948#note_956238056
it was discovered that we don't actually successfully lint these paths
anyway.

The reason is that it's not a simple resolve alias, which the
`import/no-unresolved` ESLint rule relies upon to look up paths. We
instead use `NormalModuleReplacementPlugin` to rewrite the path when in
FOSS, which that rule does not take into account.

This means that, with `FOSS_ONLY=1`, the resolved path of
`app/assets/javascripts/vue_shared/components/empty_component.js` is not
actually checked.

Since webpack will throw at build time if the path doesn't resolve,
we're protected from typos, so this edge case isn't that important.

Another interesting finding that doesn't quite make sense:
`eslint-module-utils`, which `import/no-unresolved` relies on, only
added support for `import()` calls in v2.6.1 (see
https://github.com/import-js/eslint-plugin-import/pull/2026 and
https://github.com/import-js/eslint-plugin-import/blob/main/utils/CHANGELOG.md#v261---2021-05-13).
See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/85948 for more
discussion about this.

This enables the unicorn/prefer-dom-node-dataset ESLint rule to prevent
using attributes APIs when manipulating data- attributes.

This adds a script to let ESLint dump the full GraphQL including Apollo
definitions.

This reverts merge request !86576

This enables the unicorn/prefer-dom-node-dataset ESLint rule to prevent
using attributes APIs when manipulating data- attributes.

- We choose to allow this for some props like "class", "style", and
  VueRouter's "to". Also v-bind which expects an object and is
  matched by `^$`.
- There's some trivial fixes possible, but to keep this review trivial
  we opt for just adding the eslint-disable and eslint-enable for
  existing violations

This upstream rule does not seem complete, so we're disabling it for
now. See https://gitlab.com/gitlab-org/gitlab/-/issues/360551 for more
details.

Revert "Merge branch '343999-fix-codebase-to-ensure-the-uniqueness-of-graphql-fragment-names' into 'master'"

This reverts merge request !85383

Natalia Tepluhina 创作于 2 years ago ，Vitaly Slobodin 提交于 2 years ago

- removed some unused fragments
- disabled linter for ee-else-ce fragments
- fixed fragment names for everything else

The `GlSkeletonLoading` component was deprecated in favour of
`GlSkeletonLoader` as part of
https://gitlab.com/groups/gitlab-org/-/epics/4301.

This makes sure that only the `GlDeprecateSkeletonLoading` import name
can be used, to remove any ambiguity about whether or not it's
deprecated.

Part of https://gitlab.com/gitlab-org/gitlab/-/issues/357001.

This does not replace some instances of `setImmediate` in helpers and
test environment configuration files, as these are well-contained, and
can be rewritten later, if need be. The addition of the lint rule should
prevent more usages of `setImmediate` appearing.

This is the final part of
https://gitlab.com/gitlab-org/gitlab/-/issues/344247.

The exception is `this.$nextTick()`, which is allowed because a component
definition/implementation may legitimately call its _own_ method. This
rule is about preventing test code from calling that instance method.

Addresses https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/47.

* add lint against setData
* add eslint-ignore for existing cases

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/346320

This reverts commit aec8fc7a, reversing
changes made to ec9a1f48.

Allow using MirajeJS to mock API requests
in Storybook. Improves the yarn storybook:start
command to prompt the user about generating
the fixtures needed by MirajeJS.

Some violations have been fixed, and others have been ignored for now
when the fix would either be too large or impact performance.

Fixed contributors slot syntax

Fixed slot syntax in ci cd analytics

Fixed slot scope in charts and discussion

Fixed slot syntax in paginated list spec

Fixed slot syntax in resizeable chart spec

Fixed slot syntax in note and issuable form

Fixed members and milestones slot syntax

Fixed slots in discussion-notes

Fixes slot syntax in time series

Noteables slots fixes

Terraform slots syntax fixed

Fixed time series

Fixed slots in analytics

Added modal stub

Fixed rules slot

Fixed burnup and burndown chart

Fixed cluster agents slots

Added eslint config

Fixed related items tree

Fixed slots in grouped metrics

Fixed slots in unit tests

Fixed ready to merge spec

Fixed ci_cd_anaytics spec

Fixed terraform list spec

Added stubbed GlTab to cluster agent spec

Stubbed NoteableNote in specs

Stubbed GlModal in dashboard actions test

Fixed issuable form spec

Fixed discussion notes spec

Fixed time series spec

Fixed fork_form spec

Updated snapshot for analytics

Fixed commit edit spec

- upgrade storybook packages
- add comments to webpack config

Adds Storybook dependencies, config,
and a story for todo_button.vue.

Deploys to GitLab pages.