This commit adds a new RuboCop rule `Gitlab/NoFindInWorkers` to prevent
the use of `.find` in workers. It also enabled "grace period" and generated TODOs.

Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Now that 'audit events' is sentence-cased in the UI, let's make the
docs and other ancillary assets match.

Let's clean up the rest of these and bring them to sentence case.

Add a graphql API to return the multimatches in a single file.
So that frontend can display the multimatches in a single file
at one place. API will raie an error if performed other than for Zoekt.

Changelog: added
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/155984
EE: true

This reverts merge request !158822

Changelog: changed

Add a graphql API to return the multimatches in a single file.
So that frontend can display the multimatches in a single file
at one place. API will raie an error if performed other than for Zoekt.

Changelog: added
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/155984
EE: true

This reverts commit 14a195c8, reversing
changes made to 21dc9de3.

Add a graphql API to return the multimatches in a single file.
So that frontend can display the multimatches in a single file
at one place. API will raie an error if performed other than for Zoekt.

Changelog: added
MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/155984
EE: true

Style/Lambda offenses fixed across 64 files

Changelog: other
EE: true

We're using the housekeeper gem here to generate the `.rubocop_todo`
files and create an MR.

Run `bundle exec gitlab-housekeeper -d -k Keeps::GenerateRubocopTodos`
to test out the changes locally.

When the `Exclude` todo list for a cop is empty the following error was
thrown:

```
undefined method `grep' for nil:NilClass
gitlab/rubocop/formatter/todo_formatter.rb:95:in `block in create_todos_retaining_exclusions'
```

Because here the `Exclude` key is mapped to `nil` and therefore the
default of `[]` isn't returned by the `fetch` method.

To reproduce the issue on the master branch create this file
`.rubocop_todo/migration/avoid_finalize_background_migration.yml` with
the following contents:

```yml
---
Migration/AvoidFinalizeBackgroundMigration:
  Exclude:
```

Then run `bundle exec rake rubocop:todo:generate`, the above error will
be thrown.

On this branch, the error will not be thrown and the same has been
covered in the specs.

Instead of using a double negative @splattael suggested matching on
all params, ehn permitting when params is used safely.

With that we could simplify the node pattern while making the cop rule
faster and perhaps more secure. There's no special case made for methods
like page, per, puts, has_key, etc.

The downside is the number of rubocop exceptions when from 225 to 379.

- add check for `prepare_async_index`
- add more tables to the list with forbidden tables
- update message on offense

Changelog: changed

Changelog: other

Changelog: changed

Fix outstanding cop conflicts
Make feature_flag metadat name key required

This migration marks the 20230530500000 MigrateProjectsToSeparateIndex Advanced search migration as obsolete.

This MR will still need changes to remove references to the migration in the code.
At the moment the `gitlab-housekeeper` is not always capable of removing all references so you must check the
diff and pipeline failures to confirm if there are any issues.
It is the responsibility of the assignee (picked from ~"group::global search") to push those changes to this branch.

You can read more about the process for marking Advanced search migrations as obsolete in
https://docs.gitlab.com/ee/development/search/advanced_search_migration_styleguide.html#deleting-advanced-search-migrations-in-a-major-version-upgrade.

As part of our process we want to ensure all Advanced search migrations have had at least one
[required stop](https://docs.gitlab.com/ee/development/database/required_stops.html)
to process the migration. Therefore we can mark any Advanced search migrations added before the
last required stop as obsolete.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::MarkOldAdvancedSearchMigrationsAsObsolete keep.

To provide feedback on your experience with `gitlab-housekeeper` please comment in
<https://gitlab.com/gitlab-org/gitlab/-/issues/442003>.

Changelog: other
EE: true

- See https://gitlab.com/gitlab-org/gitlab/-/issues/456132

Last milestone we moved the call to FeatureFlags from YamlProcessor to
Ci::Config. This commit moves the class to match.

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/457172

Changelog: other

Changelog: other

Signed-off-by: Rémy Coutable <remy@rymai.me>

Co-authored-by: Madelein van Niekerk <mvanniekerk@gitlab.com>

In Rake, `namespace` blocks are eagerly loaded so RuboCop needs to flag
the use of `require` as well.

In case of `have_gitlab_http_status(-1)` we've seen an
`RuboCop::Runner::InfiniteCorrectionLoop` error after upgrading RuboCop.

This commits side-steps this problem by checking if replacement is not
identical to the previous source version.

Since migrations for EE models don't have factories in CE we need to
skip this cop in foss-only CI.

This commit also simplifies the implementation and improves the
performances be caching files operations.

Signed-off-by: Nailia Iskhakova <niskhakova@gitlab.com>

- Update advice given to current practice of using data-testid vs the
  deprecated qa-selector

- Refs:
  https://gitlab.com/gitlab-org/quality/quality-engineering/team-tasks/-/issues/1735

Changelog: changed

Using `change_column_null` migration helper can cause issues if it's
used for a high-traffic table as it requires locking the whole table.

Enforce `safe_format` for externalized strings with interpolations and
`.html_safe`.

  # bad
  _('string %{open}foo%{close}').html_safe % { open: '<b>'.html_safe, close: '</b>'.html_safe }
  format(_('string %{open}foo%{close}').html_safe, open: '<b>'.html_safe, close: '</b>'.html_safe)

  # good
  safe_format(_('string %{open}foo%{close}'), tag_pair(tag.b, :open, :close)
  # also good no `html_safe`
  format(_('string %{var} number'), var: var)

- add bad format and enforce pattern.

- add rubocop to lint on use of Current.organization outside
  of approved app layers.
- see https://gitlab.com/gitlab-org/gitlab/-/issues/442751 for
  details

```
      # # bad
      # class SomeService
      #   def execute
      #     do_something_with(Current.organization)
      #   end
      # end
      #
      # # good
      # class SomeController < ApplicationController
      #   def create
      #     response = SomeService.new(organization: Current.organization).execute
      #   end
      # end
      #
      # class SomeService
      #   def initialize(organization:)
      #     @organization = organization
      #   end
      #
      #   def execute
      #     do_something_with(@organization)
      #   end
      # end
```

- This can cause issues as seen in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142303#note_1781915037
  Where rails will start enumerating until that date hits.
  That makes it more likely to hit a merge conflict with other migrations.