The GraphQL reference page is called that in many other places,
including in the left hand navigation menu item for the page.

Signed-off-by: Andrew Smith <espadav8@gmail.com>

Create a more coherent message. Fix typo. Put sentences together into
coherent paragraphs, and call out the warning more clearly. Also, add
an "improve this message" link. (Make it easier for the next person.)

Auto-corrected via:
  rubocop -a --only Style/RedundantFreeze scripts spec tooling qa

Chad Woolley 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

- Use correct group
- Rename category role to remote_development_be

Signed-off-by: Rémy Coutable <remy@rymai.me>

Auto-corrected via:

  rubocop -a --only Performance/RegexpMatch ...

Auto-corrections manually reviewed and verified.

The performance of generating translations was greatly increased, which
means we can run it before pushing. This should save some unnecessary
broken pipelines.

- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120964

For all new added migrations, the timestamp is checked against current
date and if it's older than three weeks, a warning is displayed in the
Danger message.

Signed-off-by: Rémy Coutable <remy@rymai.me>

New CI tables that reference large tables should be
should be partitioned from the start.

Product Intelligence would like to review MRs which removes
metrics or other files that related to Product Intelligence.

The package-and-test-ee configuration was modified to suceed even with
test failures, this makes the failures less noticeable and requires
adjusting in the tooling side.

This commit:
* Updates the name of the package-and-test to specifically search for
  'package-and-test'
* Makes a Danger warn message about the package-and-test to always be
  sent (it used to only be sent if the status was different than
success)

David Dieulivol 创作于 1 year ago ，Jennifer Li 提交于 1 year ago

We need to reuse the methods from Mappings::Base class
outside of the Mappings module, so we extract the content
of that class to a module that can be included anywhere.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Only about 10% of our rb, haml and erb files seem to contain
externalized strings. We can add a simple guard that checks whether a
file contains `_(` and only parse it, if it does. This leads to a
massive performance improvement.

We currently use `GettextI18nRails::HamlParser` which is using `hamlit`
to convert `haml` to ruby and then `RubyGettextExtractor` (also part of
the `gettext_i18n_rails` gem) to extract externalized strings from the
converted ruby code. This however seems to be slower than the
`GetText::RubyParser` from the `gettext` gem. The performance difference
comes from `ruby_parser` vs `ripper`. The tool also seems to find more
strings, that the previous parser wasn't able to find.

We currently scan ee/spec for externalized strings, which brings up a
few false-positives. These false positives create an unnecessary burden
for translators and increase our scan time quite a bit (about 19% of our
rb/erb/haml files are found inside ee/spec). On my machine this reduces
the execution time from 29.4s to 21.5s when running on one core only.

Fixed two specs which used confusing placeholder names in strings.

- Skip database warnings
- Skip product intelligence review
- Skip data team warnings

Also remove these file from RuboCop TODOs

In order to add a suggestion you now need to:
1. Create a suggestion and specs
2. Add suggestion class to SUGGESTIONS constant
3. There is no step 3

Also move the specs.

Also move the specs.

Move the specs too!

This suggestion base class can be used to implement specific
suggestions.