Skip to content
代码片段 群组 项目
未验证 提交 e3bbf853 编辑于 作者: Dan Davison's avatar Dan Davison 提交者: GitLab
浏览文件

Merge branch 'jmd/e2e-expand-breadbcrumbs-for-text-check' into 'master'

E2E: Always expand breadcrumbs prior to checking for text

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168412



Merged-by: default avatarDan Davison <ddavison@gitlab.com>
Approved-by: default avatarSofia Vistas <svistas@gitlab.com>
Approved-by: default avatarDan Davison <ddavison@gitlab.com>
Co-authored-by: default avatarJohn McDonnell <jmcdonnell@gitlab.com>
No related branches found
No related tags found
无相关合并请求
...@@ -15,6 +15,12 @@ def self.included(base) ...@@ -15,6 +15,12 @@ def self.included(base)
end end
def has_breadcrumb?(text) def has_breadcrumb?(text)
# In some situations the length of the breadcrumbs may lead to it being condensed. For these situations
# open the dropdown toggle which should allow us to see the all components of the breadcrumb.
if has_no_element?('breadcrumb-links', text: text, wait: 0)
within_element('breadcrumb-links') { click_element('base-dropdown-toggle') }
end
has_element?('breadcrumb-links', text: text) has_element?('breadcrumb-links', text: text)
end end
end end
......
...@@ -31,11 +31,7 @@ module QA ...@@ -31,11 +31,7 @@ module QA
Page::Project::Menu.perform(&:click_project) Page::Project::Menu.perform(&:click_project)
Page::Project::Show.perform do |project| Page::Project::Show.perform do |project|
# TODO breadcrumb test should be updated. expect(project).to have_breadcrumb(target_group.path)
# I'm commenting it out for now. I will create a follow-up issue to fix this.
# https://gitlab.com/gitlab-org/gitlab/-/issues/497758#note_2145018495
# expect(project).to have_breadcrumb(target_group.path)
expect(project).to have_readme_content(readme_content) expect(project).to have_readme_content(readme_content)
end end
end end
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册