Merge branch '434111-fix-zoekt-page-error' into 'master'

Fix zoekt pagination exception

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138899



Merged-by: Siddharth Dungarwal <sdungarwal@gitlab.com>
Approved-by: Madelein van Niekerk <mvanniekerk@gitlab.com>
Approved-by: Siddharth Dungarwal <sdungarwal@gitlab.com>
Co-authored-by: Dmitry Gruzd <dgruzd@gitlab.com>

ee/lib/gitlab/zoekt/search_results.rb

@@ -209,7 +209,7 @@ def zoekt_search_and_wrap(query, per_page:, page: 1, options: {}, preload_method
       end
 
       def yield_each_zoekt_search_result(response, preload_method, total_count)
-        return [[], total_count] if total_count == 0
+        return [[], total_count] if total_count == 0 || response.blank?
 
         project_ids = response.pluck(:project_id).uniq # rubocop:disable CodeReuse/ActiveRecord
         projects = Project.with_route.id_in(project_ids)

ee/spec/lib/gitlab/zoekt/search_results_spec.rb

@@ -59,6 +59,13 @@
       expect(results.blobs_count).to eq 5
     end
 
+    it 'returns empty result when request is out of page range' do
+      results = described_class.new(user, 'use.*egex', limit_project_ids, node_id: node_id)
+      blobs_page = results.objects('blobs', page: 256, per_page: 2)
+
+      expect(blobs_page).to be_empty
+    end
+
     it 'limits to the zoekt count limit' do
       stub_const("#{described_class}::ZOEKT_COUNT_LIMIT", 2)