Merge branch '412602-use-looping-instead-of-each_batch' into 'master'

Use loop with delete_all instead of EachBatch

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138800



Merged-by: Rutger Wessels <rwessels@gitlab.com>
Approved-by: Tyler Amos <tamos@gitlab.com>
Approved-by: Rutger Wessels <rwessels@gitlab.com>
Reviewed-by: Tyler Amos <tamos@gitlab.com>
Co-authored-by: Michał Zając <mzajac@gitlab.com>

ee/app/workers/vulnerabilities/remove_all_vulnerabilities_worker.rb

@@ -53,30 +53,31 @@ def perform(project_id)
 
     private
 
-    # rubocop:disable Style/SymbolProc -- for some reason, using &:delete_all fails with wrong number of arguments
     def drop_by_project_id(project_id)
       MODELS_TO_DROP_BY_PROJECT_ID.each do |model|
-        model
-          .by_projects(project_id)
-          .each_batch(of: BATCH_SIZE) { |b| b.delete_all }
+        loop do
+          deleted = model.by_projects(project_id).limit(BATCH_SIZE).delete_all
+          break if deleted == 0
+        end
       end
     end
 
     def drop_by_finding_id(finding_ids)
       MODELS_TO_DROP_BY_FINDING_ID.each do |model|
-        model
-          .by_finding_id(finding_ids)
-          .each_batch(of: BATCH_SIZE) { |b| b.delete_all }
+        loop do
+          deleted = model.by_finding_id(finding_ids).limit(BATCH_SIZE).delete_all
+          break if deleted == 0
+        end
       end
     end
 
     def drop_by_vulnerability_id(vulnerability_ids)
       MODELS_TO_DROP_BY_VULNERABILITY_ID.each do |model|
-        model
-          .by_vulnerability(vulnerability_ids)
-          .each_batch(of: BATCH_SIZE) { |b| b.delete_all }
+        loop do
+          deleted = model.by_vulnerability(vulnerability_ids).limit(BATCH_SIZE).delete_all
+          break if deleted == 0
+        end
       end
     end
-    # rubocop:enable Style/SymbolProc
   end
 end