Merge branch 'tchu-reindex-work-items-to-populate-notes' into 'master'

Reindex work items to index notes data

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/182950



Merged-by: Siddharth Dungarwal <sdungarwal@gitlab.com>
Approved-by: Arturo Herrero <arturo.herrero@gmail.com>
Approved-by: Siddharth Dungarwal <sdungarwal@gitlab.com>
Co-authored-by: Terri Chu <tchu@gitlab.com>

ee/elastic/docs/20250226143000_reindex_work_items_to_backfill_notes.yml

+---
+name: ReindexWorkItemsToBackfillNotes
+version: '20250226143000'
+description: Reindex all work items to backfill notes
+group: group::global search
+milestone: '17.10'
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/182950
+obsolete: false
+marked_obsolete_by_url: 
+marked_obsolete_in_milestone:
+skippable: true
+skip_condition: 'Only run on GitLab.com'
\ No newline at end of file

ee/elastic/migrate/20250226143000_reindex_work_items_to_backfill_notes.rb

+# frozen_string_literal: true
+
+class ReindexWorkItemsToBackfillNotes < Elastic::Migration
+  include Search::Elastic::MigrationReindexBasedOnSchemaVersion
+  extend ::Gitlab::Utils::Override
+
+  skip_if -> { !::Gitlab::Saas.feature_available?(:advanced_search) }
+
+  batched!
+  batch_size 9_000
+  throttle_delay 1.minute
+
+  DOCUMENT_TYPE = WorkItem
+  NEW_SCHEMA_VERSION = 25_09
+  UPDATE_BATCH_SIZE = 100
+
+  private
+
+  override :index_name
+  def index_name
+    Search::Elastic::Types::WorkItem.index_name
+  end
+end

ee/lib/search/elastic/references/work_item.rb

@@ -6,7 +6,7 @@ module References
       class WorkItem < Reference
         include Search::Elastic::Concerns::DatabaseReference
 
-        SCHEMA_VERSION = 25_08
+        SCHEMA_VERSION = 25_09
         NOTES_MAXIMUM_BYTES = 512.kilobytes
 
         override :serialize

ee/spec/elastic/migrate/20250226143000_reindex_work_items_to_backfill_notes_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+require File.expand_path('ee/elastic/migrate/20250226143000_reindex_work_items_to_backfill_notes.rb')
+
+RSpec.describe ReindexWorkItemsToBackfillNotes, :elastic_delete_by_query, :sidekiq_inline, feature_category: :global_search do
+  let(:version) { 20250226143000 }
+
+  describe 'skip_if setting' do
+    subject(:migration) { described_class.new(version) }
+
+    context 'when on Saas', :saas do
+      it { expect(migration.skip_migration?).to be false }
+    end
+
+    context 'when not on Saas' do
+      it { expect(migration.skip_migration?).to be true }
+    end
+  end
+
+  include_examples 'migration reindex based on schema_version' do
+    let(:index_name) { ::Search::Elastic::Types::WorkItem.index_name }
+    let(:objects) { create_list(:work_item, 3) }
+    let(:expected_throttle_delay) { 1.minute }
+    let(:expected_batch_size) { 9_000 }
+  end
+end