Merge branch '410726-trim-maven-dependency-proxy-form-input' into 'master'

Trims input fields in maven dependency proxy settings

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/141952



Merged-by: Ezekiel Kigbo <3397881-ekigbo@users.noreply.gitlab.com>
Approved-by: Thomas Randolph <trandolph@gitlab.com>
Approved-by: Ezekiel Kigbo <3397881-ekigbo@users.noreply.gitlab.com>
Reviewed-by: Ezekiel Kigbo <3397881-ekigbo@users.noreply.gitlab.com>
Reviewed-by: Rahul Chanila <rchanila@gitlab.com>
Co-authored-by: Rahul Chanila <rchanila@gitlab.com>

ee/app/assets/javascripts/packages_and_registries/settings/project/components/maven_form.vue

@@ -33,7 +33,7 @@ export default {
         id="maven-url"
         :value="value.mavenExternalRegistryUrl"
         width="xl"
-        @input="onModelChange($event, 'mavenExternalRegistryUrl')"
+        @input="onModelChange($event.trim(), 'mavenExternalRegistryUrl')"
       />
     </gl-form-group>
     <gl-form-group
@@ -45,7 +45,7 @@ export default {
         id="maven-username"
         :value="value.mavenExternalRegistryUsername"
         width="xl"
-        @input="onModelChange($event, 'mavenExternalRegistryUsername')"
+        @input="onModelChange($event.trim(), 'mavenExternalRegistryUsername')"
       />
     </gl-form-group>
     <gl-form-group

ee/spec/frontend/packages_and_registries/settings/project/components/maven_form_spec.js

@@ -32,11 +32,11 @@ describe('maven form', () => {
   });
 
   describe.each`
-    index | field                              | label         | description                               | value
-    ${0}  | ${'mavenExternalRegistryUrl'}      | ${'URL'}      | ${'Base URL of the external registry.'}   | ${mavenExternalRegistryUrl}
-    ${1}  | ${'mavenExternalRegistryUsername'} | ${'Username'} | ${'Username of the external registry.'}   | ${mavenExternalRegistryUsername}
-    ${2}  | ${'mavenExternalRegistryPassword'} | ${'Password'} | ${'Password for your external registry.'} | ${''}
-  `('$label', ({ index, field, description, label, value }) => {
+    index | field                              | label         | description                               | value                            | trimmed
+    ${0}  | ${'mavenExternalRegistryUrl'}      | ${'URL'}      | ${'Base URL of the external registry.'}   | ${mavenExternalRegistryUrl}      | ${true}
+    ${1}  | ${'mavenExternalRegistryUsername'} | ${'Username'} | ${'Username of the external registry.'}   | ${mavenExternalRegistryUsername} | ${true}
+    ${2}  | ${'mavenExternalRegistryPassword'} | ${'Password'} | ${'Password for your external registry.'} | ${''}                            | ${false}
+  `('$label', ({ index, field, description, label, value, trimmed }) => {
     let formGroup;
     let formInput;
 
@@ -56,8 +56,8 @@ describe('maven form', () => {
       expect(formInput.attributes('value')).toBe(value);
     });
 
-    it('emits input event', () => {
-      formInput.vm.$emit('input', 'new value');
+    it('emits trimmed input event', () => {
+      formInput.vm.$emit('input', trimmed ? '  new value  ' : 'new value');
 
       expect(wrapper.emitted('input')).toEqual([[{ ...defaultProps.value, [field]: 'new value' }]]);
     });