diff --git a/ee/app/assets/javascripts/packages_and_registries/settings/project/components/maven_form.vue b/ee/app/assets/javascripts/packages_and_registries/settings/project/components/maven_form.vue index 9f839daed5f8cd283ebc920520f1259fa97db26e..71690e1eb95e7bae644cf0c054f24528c095f627 100644 --- a/ee/app/assets/javascripts/packages_and_registries/settings/project/components/maven_form.vue +++ b/ee/app/assets/javascripts/packages_and_registries/settings/project/components/maven_form.vue @@ -33,7 +33,7 @@ export default { id="maven-url" :value="value.mavenExternalRegistryUrl" width="xl" - @input="onModelChange($event, 'mavenExternalRegistryUrl')" + @input="onModelChange($event.trim(), 'mavenExternalRegistryUrl')" /> </gl-form-group> <gl-form-group @@ -45,7 +45,7 @@ export default { id="maven-username" :value="value.mavenExternalRegistryUsername" width="xl" - @input="onModelChange($event, 'mavenExternalRegistryUsername')" + @input="onModelChange($event.trim(), 'mavenExternalRegistryUsername')" /> </gl-form-group> <gl-form-group diff --git a/ee/spec/frontend/packages_and_registries/settings/project/components/maven_form_spec.js b/ee/spec/frontend/packages_and_registries/settings/project/components/maven_form_spec.js index 05ad5a370d7eb320fcf0335f0f3f3cd95a67c643..adf58dbd49f2220141e168a62337fe3d08dfeed3 100644 --- a/ee/spec/frontend/packages_and_registries/settings/project/components/maven_form_spec.js +++ b/ee/spec/frontend/packages_and_registries/settings/project/components/maven_form_spec.js @@ -32,11 +32,11 @@ describe('maven form', () => { }); describe.each` - index | field | label | description | value - ${0} | ${'mavenExternalRegistryUrl'} | ${'URL'} | ${'Base URL of the external registry.'} | ${mavenExternalRegistryUrl} - ${1} | ${'mavenExternalRegistryUsername'} | ${'Username'} | ${'Username of the external registry.'} | ${mavenExternalRegistryUsername} - ${2} | ${'mavenExternalRegistryPassword'} | ${'Password'} | ${'Password for your external registry.'} | ${''} - `('$label', ({ index, field, description, label, value }) => { + index | field | label | description | value | trimmed + ${0} | ${'mavenExternalRegistryUrl'} | ${'URL'} | ${'Base URL of the external registry.'} | ${mavenExternalRegistryUrl} | ${true} + ${1} | ${'mavenExternalRegistryUsername'} | ${'Username'} | ${'Username of the external registry.'} | ${mavenExternalRegistryUsername} | ${true} + ${2} | ${'mavenExternalRegistryPassword'} | ${'Password'} | ${'Password for your external registry.'} | ${''} | ${false} + `('$label', ({ index, field, description, label, value, trimmed }) => { let formGroup; let formInput; @@ -56,8 +56,8 @@ describe('maven form', () => { expect(formInput.attributes('value')).toBe(value); }); - it('emits input event', () => { - formInput.vm.$emit('input', 'new value'); + it('emits trimmed input event', () => { + formInput.vm.$emit('input', trimmed ? ' new value ' : 'new value'); expect(wrapper.emitted('input')).toEqual([[{ ...defaultProps.value, [field]: 'new value' }]]); });