Skip to content
代码片段 群组 项目
提交 8d26b5a8 编辑于 作者: psjakubowska's avatar psjakubowska
浏览文件

Make sure aside has its implicit complementary role

Because of nesting inside a section tag, the aside lost
its implicit aria role. Moving it up the tree, closer to
main tag retains it role and fixes accessibility error.

Changelog: fixed
上级 82b1b45e
No related branches found
No related tags found
2 合并请求!3031Merge per-main-jh to main-jh by luzhiyuan,!3030Merge per-main-jh to main-jh
......@@ -455,6 +455,20 @@ export default {
<gl-loading-icon v-if="$apollo.loading" size="lg" />
<div v-else-if="!branchRule && !isPredefinedRule">{{ $options.i18n.noData }}</div>
<div v-else>
<access-levels-drawer
:is-open="isAllowedToMergeDrawerOpen || isAllowedToPushAndMergeDrawerOpen"
:roles="accessLevelsDrawerData.roles"
:users="accessLevelsDrawerData.users"
:groups="accessLevelsDrawerData.groups"
:deploy-keys="accessLevelsDrawerData.deployKeys"
:is-loading="isRuleUpdating"
:group-id="groupId"
:title="accessLevelsDrawerTitle"
:is-push-access-levels="isAllowedToPushAndMergeDrawerOpen"
@editRule="onEditAccessLevels"
@close="closeAccessLevelsDrawer"
/>
<crud-component :title="$options.i18n.ruleTarget" data-testid="rule-target-card">
<template #actions>
<gl-button
......@@ -523,20 +537,6 @@ export default {
@edit="openAllowedToPushAndMergeDrawer"
/>
<access-levels-drawer
:is-open="isAllowedToMergeDrawerOpen || isAllowedToPushAndMergeDrawerOpen"
:roles="accessLevelsDrawerData.roles"
:users="accessLevelsDrawerData.users"
:groups="accessLevelsDrawerData.groups"
:deploy-keys="accessLevelsDrawerData.deployKeys"
:is-loading="isRuleUpdating"
:group-id="groupId"
:title="accessLevelsDrawerTitle"
:is-push-access-levels="isAllowedToPushAndMergeDrawerOpen"
@editRule="onEditAccessLevels"
@close="closeAccessLevelsDrawer"
/>
<!-- Force push -->
<protection-toggle
v-if="hasPushAccessLevelSet"
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册