Skip to content
代码片段 群组 项目
未验证 提交 7578f62f 编辑于 作者: Suzanne Selhorn's avatar Suzanne Selhorn 提交者: GitLab
浏览文件

Merge branch 'reduce-async-cycles-in-review' into 'master'

Help reduce async MR review cycles by clarifying non-blocking

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/150474



Merged-by: default avatarSuzanne Selhorn <sselhorn@gitlab.com>
Approved-by: default avatarNicolas Dular <ndular@gitlab.com>
Approved-by: default avatarAhmed Hemdan <ahemdan@gitlab.com>
Approved-by: default avatarSashi Kumar Kumaresan <skumar@gitlab.com>
Approved-by: default avatarLin Jen-Shin <jen-shin@gitlab.com>
Approved-by: default avatarJaviera Tapia <jtapia@gitlab.com>
Approved-by: default avatarKassio Borges <kborges@gitlab.com>
Approved-by: default avatarBrett Walker <bwalker@gitlab.com>
Approved-by: default avatarJarka Košanová <jarka@gitlab.com>
Approved-by: default avatarEugenia Grieff <egrieff@gitlab.com>
Approved-by: default avatarJames Nutt <jnutt@gitlab.com>
Approved-by: default avatarTerri Chu <tchu@gitlab.com>
Approved-by: default avatarAllen Cook <acook@gitlab.com>
Approved-by: default avatarPedro Pombeiro <noreply@pedro.pombei.ro>
Approved-by: default avatarDouglas Barbosa Alexandre <dbalexandre@gmail.com>
Approved-by: default avatarFurkan Ayhan <furkanayhn@gmail.com>
Approved-by: default avatarStan Hu <stanhu@gmail.com>
Approved-by: default avatarAsh McKenzie <amckenzie@gitlab.com>
Approved-by: default avatarSylvester Chin <schin@gitlab.com>
Approved-by: default avatarMarc Shaw <mshaw@gitlab.com>
Approved-by: default avatarEugie Limpin <elimpin@gitlab.com>
Approved-by: default avatarMichael Becker <11881043-wandering_person@users.noreply.gitlab.com>
Approved-by: default avatarThong Kuah <tkuah@gitlab.com>
Approved-by: default avatarMatthias Käppler <mkaeppler@gitlab.com>
Approved-by: default avatarPatrick Bajao <ebajao@gitlab.com>
Approved-by: default avatarRémy Coutable <remy@rymai.me>
Approved-by: default avatarMohamed Hamda <mhamda@gitlab.com>
Approved-by: default avatarHalil Coban <hcoban@gitlab.com>
Approved-by: default avatarJan Provaznik <jprovaznik@gitlab.com>
Approved-by: default avatarVasilii Iakliushin <viakliushin@gitlab.com>
Reviewed-by: default avatarDrew Blessing <drew@gitlab.com>
Co-authored-by: default avatarDoug Stull <dstull@gitlab.com>
No related branches found
No related tags found
无相关合并请求
......@@ -582,7 +582,12 @@ experience, refactors the existing code). Then:
- Consider using the [Conventional Comment format](https://conventionalcomments.org#format) to
convey your intent.
- For non-mandatory suggestions, decorate with (non-blocking) so the author knows they can
optionally resolve within the merge request or follow-up at a later stage.
optionally resolve within the merge request or follow-up at a later stage. When the only suggestions are
non-blocking, move the MR onto the next stage to reduce async cycles. When you are a first round
reviewer, pass to a maintainer to review. When you are the final approving maintainer,
generate follow-ups from the non-blocking suggestions and merge or set auto-merge.
The author then has the option to either cancel the auto-merge by implementing the non-blocking suggestions,
they provide a follow-up MR after the MR got merged, or decide to not implement the suggestions.
- There's a [Chrome/Firefox add-on](https://gitlab.com/conventionalcomments/conventional-comments-button) which you can use to apply [Conventional Comment](https://conventionalcomments.org/) prefixes.
- Ensure there are no open dependencies. Check [linked issues](../user/project/issues/related_issues.md) for blockers. Clarify with the authors
if necessary. If blocked by one or more open MRs, set an [MR dependency](../user/project/merge_requests/dependencies.md).
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册