Skip to content
代码片段 群组 项目
未验证 提交 d51cfce8 编辑于 作者: Doug Stull's avatar Doug Stull 提交者: GitLab
浏览文件

Help reduce async MR review cycles by clarifying non-blocking

- We find sometimes that first level reviewers and maintainers
  are unclear how to handle non-blocking suggestions. A lot of
  times a maintainer will make a non-blocking comment and pass
  it back for another async cycle to the MR author instead of
  setting it to merge. When there are only non-blocking
  suggestions, this can be inefficient. The aim of this change
  is to clear that up and further enable first level reviewers
  and maintainers to reduce those async cycles and empower
  creation of follow-up issues.
上级 5d00d195
No related branches found
No related tags found
无相关合并请求
...@@ -582,7 +582,12 @@ experience, refactors the existing code). Then: ...@@ -582,7 +582,12 @@ experience, refactors the existing code). Then:
- Consider using the [Conventional Comment format](https://conventionalcomments.org#format) to - Consider using the [Conventional Comment format](https://conventionalcomments.org#format) to
convey your intent. convey your intent.
- For non-mandatory suggestions, decorate with (non-blocking) so the author knows they can - For non-mandatory suggestions, decorate with (non-blocking) so the author knows they can
optionally resolve within the merge request or follow-up at a later stage. optionally resolve within the merge request or follow-up at a later stage. When the only suggestions are
non-blocking, move the MR onto the next stage to reduce async cycles. When you are a first round
reviewer, pass to a maintainer to review. When you are the final approving maintainer,
generate follow-ups from the non-blocking suggestions and merge or set auto-merge.
The author then has the option to either cancel the auto-merge by implementing the non-blocking suggestions,
they provide a follow-up MR after the MR got merged, or decide to not implement the suggestions.
- There's a [Chrome/Firefox add-on](https://gitlab.com/conventionalcomments/conventional-comments-button) which you can use to apply [Conventional Comment](https://conventionalcomments.org/) prefixes. - There's a [Chrome/Firefox add-on](https://gitlab.com/conventionalcomments/conventional-comments-button) which you can use to apply [Conventional Comment](https://conventionalcomments.org/) prefixes.
- Ensure there are no open dependencies. Check [linked issues](../user/project/issues/related_issues.md) for blockers. Clarify with the authors - Ensure there are no open dependencies. Check [linked issues](../user/project/issues/related_issues.md) for blockers. Clarify with the authors
if necessary. If blocked by one or more open MRs, set an [MR dependency](../user/project/merge_requests/dependencies.md). if necessary. If blocked by one or more open MRs, set an [MR dependency](../user/project/merge_requests/dependencies.md).
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册