Merge branch 'chore/431475-refactor-repository-moves' into 'master'

Do not finish_replication until the new storage is tracked

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/158462



Merged-by: Vasilii Iakliushin <viakliushin@gitlab.com>
Approved-by: Joseph Wambua <jjoshua@gitlab.com>
Approved-by: Vasilii Iakliushin <viakliushin@gitlab.com>
Co-authored-by: Joe Woodward <j@joewoodward.me>

app/services/concerns/update_repository_storage_methods.rb

@@ -33,12 +33,12 @@ def execute
       mirror_repositories
     end
 
-    repository_storage_move.finish_replication!
-
     repository_storage_move.transaction do
       track_repository(destination_storage_name)
     end
 
+    repository_storage_move.finish_replication!
+
     remove_old_paths unless same_filesystem?
 
     repository_storage_move.finish_cleanup!