Skip to content
代码片段 群组 项目
提交 11fff9b3 编辑于 作者: Joe Woodward's avatar Joe Woodward 提交者: Joe Woodward
浏览文件

Do not finish_replication until the new storage is tracked

When we move the repository storage we were calling
`repository_storage_move.finish_replication!` before we called
`track_repository(destination_storage_name)`.

`track_repository` is telling the group, project, or snippet to use the
new storage location.

When we call `repository_storage_move.finish_replication!` we are
setting the repository to writable again in the state machine event with
`storage_move.container.set_repository_writable!`. This means users can
begin pushing again, however, if they push before the new storage is
tracked they will push commits to the old storage and that would then be
untracked once the new storage is tracked causing a loss of information.

The risks of this happening are fairly low as moving storage is a manual
task which shouldn't be triggered often and the gap between making the
repo writable and tracking the correct storage should be very small.
上级 36d1d4a7
No related branches found
No related tags found
加载中
加载中
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册