Enable optimise GitHub import attachments feature

https://gitlab.com/gitlab-org/gitlab/-/issues/436400
https://gitlab.com/gitlab-org/gitlab/-/issues/436433

Changelog: other

config/feature_flags/gitlab_com_derisk/github_importer_attachments.yml

----
-name: github_importer_attachments
-feature_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/436400
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140524
-rollout_issue_url: https://gitlab.com/gitlab-com/gl-infra/production/-/issues/17318
-milestone: '16.8'
-group: group::import and integrate
-type: gitlab_com_derisk
-default_enabled: false

lib/gitlab/github_import/importer/attachments/base_importer.rb

@@ -52,8 +52,6 @@ def object_representation(object)
           end
 
           def has_attachments?(object)
-            return true if Feature.disabled?(:github_importer_attachments, project, type: :gitlab_com_derisk)
-
             object_representation(object).has_attachments?
           end
         end

spec/lib/gitlab/github_import/importer/attachments/issues_importer_spec.rb

@@ -41,20 +41,6 @@
       importer.sequential_import
     end
 
-    context 'when flag is disabled' do
-      before do
-        stub_feature_flags(github_importer_attachments: false)
-      end
-
-      it 'executes importer for both issues' do
-        expect_next_instances_of(Gitlab::GithubImport::Importer::NoteAttachmentsImporter, 2) do |importer|
-          expect(importer).to receive(:execute)
-        end
-
-        importer.sequential_import
-      end
-    end
-
     context 'when issue has already been processed' do
       before do
         importer.mark_as_imported(issue_with_attachment)

spec/lib/gitlab/github_import/importer/attachments/merge_requests_importer_spec.rb

@@ -42,20 +42,6 @@
       importer.sequential_import
     end
 
-    context 'when flag is disabled' do
-      before do
-        stub_feature_flags(github_importer_attachments: false)
-      end
-
-      it 'executes importer for both merge requests' do
-        expect_next_instances_of(Gitlab::GithubImport::Importer::NoteAttachmentsImporter, 2) do |importer|
-          expect(importer).to receive(:execute)
-        end
-
-        importer.sequential_import
-      end
-    end
-
     context 'when merge request has already been processed' do
       before do
         importer.mark_as_imported(mr_with_attachment)

spec/lib/gitlab/github_import/importer/attachments/notes_importer_spec.rb

@@ -52,20 +52,6 @@
       importer.sequential_import
     end
 
-    context 'when flag is disabled' do
-      before do
-        stub_feature_flags(github_importer_attachments: false)
-      end
-
-      it 'executes importer for both user notes' do
-        expect_next_instances_of(Gitlab::GithubImport::Importer::NoteAttachmentsImporter, 2) do |importer|
-          expect(importer).to receive(:execute)
-        end
-
-        importer.sequential_import
-      end
-    end
-
     context 'when note has already been processed' do
       before do
         importer.mark_as_imported(note_with_attachment)

spec/lib/gitlab/github_import/importer/attachments/releases_importer_spec.rb

@@ -41,20 +41,6 @@
       importer.sequential_import
     end
 
-    context 'when flag is disabled' do
-      before do
-        stub_feature_flags(github_importer_attachments: false)
-      end
-
-      it 'executes importer for both releases' do
-        expect_next_instances_of(Gitlab::GithubImport::Importer::NoteAttachmentsImporter, 2) do |importer|
-          expect(importer).to receive(:execute)
-        end
-
-        importer.sequential_import
-      end
-    end
-
     context 'when release has already been processed' do
       before do
         importer.mark_as_imported(release_with_attachment)