Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Remove redundant error code definitions

Reject bad characters in source code

We're including psa/crypto_values.h, which defines the necessary error
codes. Remove redundant definitions, which hurt because they need to be
styled in exactly the same way (same presence/absence of spaces between
tokens).

This completes the fix of https://github.com/Mbed-TLS/mbedtls/issues/6875

.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

TLS 1.3: EarlyData: Workaround anti replay fail from GnuTLS

Use OPENSSL everywhere, not OPENSSL_CMD

Make generate_errors.pl handle directory names containing spaces when opening files

Don't restyle some PSA macros

Fix IAR warning

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

Add ChangeLog entry documenting bugfix.

Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>

Remove uses of mbedtls_ecp_curve_info in TLS (with USE_PSA)

Was explaining why we didn't use the OPENSSL name, but we are using it
now...

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>

Document/test dependencies on ECP & Bignum

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>

Modify generate_errors.pl such that it can now handle
opening files where the file path includes a directory
name containing spaces.

Raised in issue #6879. Fix provided by
@tom-cosgrove-arm in aforementioned issue.

Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>

Signed-off-by: Valerio Setti <vsetti@baylibre.com>

Signed-off-by: Valerio Setti <vsetti@baylibre.com>

Signed-off-by: Valerio Setti <vsetti@baylibre.com>

Signed-off-by: Valerio Setti <vsetti@baylibre.com>

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>

Per gnutls anti replay issue, it needs millionsecond time delay for
improve the fail rate.

From test result of #6712, this can improve the fail rate from 4%
to 92%.

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>

This reverts commit 4e83173b.

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

Fix test function derive_key_exercise()

Reject "weird" characters in text files, especially control characters that
might be escape sequences or that might cause other text to appear garbled
(as in https://trojansource.codes/

).

Also reject byte sequences that aren't valid UTF-8.

Accept only ASCII (except most control characters), letters, some non-ASCII
punctuation and some mathematical and technical symbols. This covers
everything that's currently present in Mbed TLS ( §áèéëñóöüłŽ–—’“”…≥).

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

TLS 1.3: Upstream misc fix from prototype

Check for Uncrustify errors in `code_style.py`

Signed-off-by: David Horstmann <david.horstmann@arm.com>

Signed-off-by: David Horstmann <david.horstmann@arm.com>

Move the *INDENT-ON* annotation to the end of the file so that
uncrustify does not restyle the later sections (since it introduces a
risk of future problems).

Signed-off-by: David Horstmann <david.horstmann@arm.com>

Signed-off-by: Valerio Setti <vsetti@baylibre.com>

Signed-off-by: Valerio Setti <vsetti@baylibre.com>

Some preprocessor macro definitions must have a specific expansion so that
the same macro name can be defined in different products. The definition of
having the same expansion (per the C language specification) means the same
sequence of tokens, and also the same absence/presence of spacing between
tokens.

Two macros are also defined in headers in the PSA Compliance test suite, so
the test suite would fail to build if we changed the definitions. Preserve
those definitions. Technically this is a bug in the test suite, since having
extra spaces (or even a completely different constant expression with the
same value) would still be compliant. Bug reported as
https://github.com/ARM-software/psa-arch-tests/issues/337



Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Some preprocessor macro definitions must have a specific expansion so that
the same macro name can be defined in different products. The definition of
having the same expansion (per the C language specification) means the same
sequence of tokens, and also the same absence/presence of spacing between
tokens.

For PSA error code definitions, the specific expansion is mandated by the
PSA Status code specification and the PSA Crypto API specification. In
particular, there must not be a space between (psa_status_t) and the
numerical value (whereas K&R would put a space).

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Signed-off-by: David Horstmann <david.horstmann@arm.com>

The inline assembly defined in bn_mul.h confuses code style parsing,
causing code style correction to fail. Disable code style correction for
the whole section gated by "#if defined(MBEDTLS_HAVE_ASM)" to prevent
this.

Signed-off-by: David Horstmann <david.horstmann@arm.com>