Skip to content
代码片段 群组 项目
  1. 5月 05, 2022
  2. 5月 04, 2022
  3. 4月 14, 2022
  4. 4月 13, 2022
    • Matt Mitchell's avatar
      Merging internal commits for release/6.0 (#41156) · 0d1fbec8
      Matt Mitchell 创作于
      * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore
      
      * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore
      
      * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore
      
      * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-runtime
      
      * Merged PR 21649: [internal/release/6.0] Make UseUrls() override default hosting config
      
      ## Description
      
      Prior to this change, default config (typically loaded from `DOTNET_`/`ASPNET_` environment variables and command line arguments) could override the application-level configuration. This would prevent `GenericWebHostService` from seeing the latest configuration set by `UseUrls()` of `DOTNET_URLS`, `ASPNET_URLS` or `--urls` was set.
      
      Fixes #38185
      
      ## Customer Impact
      
      This is a big gotcha to customers using `WebApplicationBuilder` (which is used in all the ASP.NET Core 6 templates) who expect the following to work:
      
      ```C#
      var builder = WebApplication.CreateBuilder(args);
      builder.WebHost.UseUrls("http://*:8080");
      var app = builder.Build();
      app.Run();
      ```
      
      A comment on the issue suggesting we patch this has gotten 5 thumbs ups not counting mine.
      
      ## Regression?
      
      - [ ] Yes
      - [x] No
      
      ## Risk
      
      - [ ] High
      - [ ] Medium
      - [x] Low
      
      This is a small well tested change which only affects the loading of default config sources and those added via a `HostFactoryResolver` to host configuration. [Here’s the existing test](https://github.com/dotnet/aspnetcore/blob/0f6f649f1da658bbe37b8898df0c80c5affa9d2d/src/DefaultBuilder/test/Microsoft.AspNetCore.Tests/WebApplicationTests.cs#L883) showing that the expected configuration providers are still dispose.
      
      ## Verification
      
      - [x] Manual (required)
      - [x] Automated
      
      ## Packaging changes reviewed?
      
      - [ ] Yes
      - [ ] No
      - [x] N/A
      
      * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-runtime
      
      * Merge from github release/6.0
      
      * [internal/release/6.0] Update dependencies from dnceng/internal/dotnet-efcore dnceng/internal/dotnet-runtime
      
       - Set to private runtime
      
      * Merged PR 21869: Correct `--architecture` in `fpm` commands
      
      # {PR title}
      
      Correct `--architecture` in `fpm` commands
      
      ## Description
      
      Update `fpm` commands to use a supported `--architecture` value. As-is, the x64 .rpm files we produce are incompatible w/ installation on an x64 machine. Problem found during servicing version flow.
      
      ## Customer Impact
      
      Unable to build dotnet-installer-ci-official w/ current .rpm files from dotnet-aspnetcore repo.
      
      ## Regression?
      
      - [x] Yes
      - [ ] No
      
      This is a build regression since 6.0.3. It will also impact our 'main' branch.
      
      ## Risk
      
      - [ ] High
      - [ ] Medium
      - [x] Low
      
      Have verified the chosen values for the command line using available online documentation. Since we know the current .rpm files are busted, things can only get better :smiley:
      
      ## Verification
      
      - [x] Manual (required)
      - [ ] Automated
      
      I am locally building this branch and will use `rpmlint` in a `docker` container to verify the goodness of the produced package.
      
      ## Packaging changes reviewed?
      
      - [ ] Yes
      - [ ] No
      - [ ] N/A
      
      Not sure how to answer this because the change is to an internal setting of the RPM installer. If others agree it's the right change, it's been reviewed :smiley:
      
      
      
      ----
      
      ## When servicing release/2.1
      
      - [ ] Make necessary changes in eng/PatchConfig.props
      
      * Merged PR 21931: Revert "[release/6.0] Build ProjectTemplates in Source-Build (#40650)" (#40805)
      
      # {PR title}
      
      Summary of the changes (Less than 80 chars)
      
      ## Description
      
      {Detail}
      
      Fixes #{bug number} (in this specific format)
      
      ## Customer Impact
      
      {Justification}
      
      ## Regression?
      
      - [ ] Yes
      - [ ] No
      
      [If yes, specify the version the behavior has regressed from]
      
      ## Risk
      
      - [ ] High
      - [ ] Medium
      - [ ] Low
      
      [Justify the selection above]
      
      ## Verification
      
      - [ ] Manual (required)
      - [ ] Automated
      
      ## Packaging changes reviewed?
      
      - [ ] Yes
      - [ ] No
      - [ ] N/A
      
      ----
      
      ## When servicing release/2.1
      
      - [ ] Make necessary changes in eng/PatchConfig.props
      
      Revert "[release/6.0] Build ProjectTemplates in Source-Build (#40650)" (#40805)
      
      This reverts commit 7c2000d3.
      
      Co-authored-by: default avatardotnet-bot <dotnet-bot@microsoft.com>
      Co-authored-by: default avatarDotNet Bot <dn-bot@microsoft.com>
      Co-authored-by: default avatarStephen Halter <shalter@microsoft.com>
      Co-authored-by: default avatarmmitche <mmitche@microsoft.com>
      Co-authored-by: default avatarDoug Bunting (AAPT) <dougbu@microsoft.com>
      0d1fbec8
    • Sean Reeser's avatar
  5. 4月 12, 2022
  6. 4月 07, 2022
  7. 4月 06, 2022
  8. 3月 23, 2022
    • Matt Mitchell's avatar
      Merged PR 21931: Revert "[release/6.0] Build ProjectTemplates in Source-Build (#40650)" (#40805) · f9ae0f5d
      Matt Mitchell 创作于
      # {PR title}
      
      Summary of the changes (Less than 80 chars)
      
      ## Description
      
      {Detail}
      
      Fixes #{bug number} (in this specific format)
      
      ## Customer Impact
      
      {Justification}
      
      ## Regression?
      
      - [ ] Yes
      - [ ] No
      
      [If yes, specify the version the behavior has regressed from]
      
      ## Risk
      
      - [ ] High
      - [ ] Medium
      - [ ] Low
      
      [Justify the selection above]
      
      ## Verification
      
      - [ ] Manual (required)
      - [ ] Automated
      
      ## Packaging changes reviewed?
      
      - [ ] Yes
      - [ ] No
      - [ ] N/A
      
      ----
      
      ## When servicing release/2.1
      
      - [ ] Make necessary changes in eng/PatchConfig.props
      
      Revert "[release/6.0] Build ProjectTemplates in Source-Build (#40650)" (#40805)
      
      This reverts commit 7c2000d3.
  9. 3月 22, 2022
  10. 3月 18, 2022
    • Doug Bunting (AAPT)'s avatar
      Merged PR 21869: Correct `--architecture` in `fpm` commands · 578ba6d8
      Doug Bunting (AAPT) 创作于
      # {PR title}
      
      Correct `--architecture` in `fpm` commands
      
      ## Description
      
      Update `fpm` commands to use a supported `--architecture` value. As-is, the x64 .rpm files we produce are incompatible w/ installation on an x64 machine. Problem found during servicing version flow.
      
      ## Customer Impact
      
      Unable to build dotnet-installer-ci-official w/ current .rpm files from dotnet-aspnetcore repo.
      
      ## Regression?
      
      - [x] Yes
      - [ ] No
      
      This is a build regression since 6.0.3. It will also impact our 'main' branch.
      
      ## Risk
      
      - [ ] High
      - [ ] Medium
      - [x] Low
      
      Have verified the chosen values for the command line using available online documentation. Since we know the current .rpm files are busted, things can only get better :smiley:
      
      ## Verification
      
      - [x] Manual (required)
      - [ ] Automated
      
      I am locally building this branch and will use `rpmlint` in a `docker` container to verify the goodness of the produced package.
      
      ## Packaging changes reviewed?
      
      - [ ] Yes
      - [ ] No
      - [ ] N/A
      
      Not sure how to answer this because the change is to an internal setting of the RPM installer. If others agree it's the right change, it's been reviewed :smiley:
      
      ----
      
      ## When servicing release/2.1
      
      - [ ] Make necessary changes in eng/PatchConfig.props
      578ba6d8
  11. 3月 16, 2022
    • Matt Mitchell's avatar
      Merged PR 21744: Merge from github release/6.0 · ce90c81c
      Matt Mitchell 创作于
      # {PR title}
      
      Summary of the changes (Less than 80 chars)
      
      ## Description
      
      {Detail}
      
      Fixes #{bug number} (in this specific format)
      
      ## Customer Impact
      
      {Justification}
      
      ## Regression?
      
      - [ ] Yes
      - [ ] No
      
      [If yes, specify the version the behavior has regressed from]
      
      ## Risk
      
      - [ ] High
      - [ ] Medium
      - [ ] Low
      
      [Justify the selection above]
      
      ## Verification
      
      - [ ] Manual (required)
      - [ ] Automated
      
      ## Packaging changes reviewed?
      
      - [ ] Yes
      - [ ] No
      - [ ] N/A
      
      ----
      
      ## When servicing release/2.1
      
      - [ ] Make necessary changes in eng/PatchConfig.props
      
      Merge from github release/6.0
      ce90c81c
  12. 3月 15, 2022
  13. 3月 12, 2022
    • Javier Calvarro Nelson's avatar
      [Blazor] Fix race condition when caching for a type of... · d13b4eb3
      Javier Calvarro Nelson 创作于
      [Blazor] Fix race condition when caching for a type of QueryParameterValueSupplier (#40636) (#40663)
      
      ## Description
      
      We were using a regular dictionary on an internal cache that can be accessed concurrently.
      
      #40595
      
      ## Customer Impact
      
      If two or more threads try to populate the cache concurrently, it can cause the app to fail.
      
      ## Regression?
      
      - [ ] Yes
      - [X] No
      
      [If yes, specify the version the behavior has regressed from]
      
      ## Risk
      
      - [ ] High
      - [ ] Medium
      - [X] Low
      
      It's switching the underlying dictionary type used.
      
      ## Verification
      
      - [ ] Manual (required)
      - [X] Automated
      
      We have extensive E2E and unit tests for this behavior.
      
      ## Packaging changes reviewed?
      
      - [ ] Yes
      - [ ] No
      - [X] N/A
      
      Co-authored-by: default avatarMayuki Sawatari <mayuki+github@misuzilla.org>
      d13b4eb3
    • William Godbe's avatar
      [release/6.0] Build .rpm packages for linux arm64 (#40504) · 9876244c
      William Godbe 创作于
      
      * [release/6.0] Build .rpm packages for linux arm64
      
      * Update Build.props
      
      * Update Directory.Build.props
      
      * Update Directory.Build.targets
      
      * Update Rpm.Runtime.rpmproj
      
      * Update Rpm.TargetingPack.rpmproj
      
      * Avoid duplicate targeting-pack RPM Build
      - if an RPM containing platform-neutral executables is platform-neutral, this should be enough
      
      * !fixup! Change Linux ARM64 job, not ARM one
      
      * Correct RPM arch name, include in targeting pack
      
      * Revert "Avoid duplicate targeting-pack RPM Build"
      
      This reverts commit 7bebff5b
      
      * Rename x64 RPM to "x64"
      
      Co-authored-by: default avatarDoug Bunting <6431421+dougbu@users.noreply.github.com>
      9876244c
  14. 3月 11, 2022
  15. 3月 10, 2022
加载中