- 9月 12, 2024
-
-
由 auto-submit[bot] 创作于
Reverts: flutter/flutter#155052 Initiated by: zanderso Reason for reverting: The tree is red on this change: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737044980814837569/+/u/run_flutter_gallery_ios__compile/stdout. Original PR Author: cbracken Reviewed By: {christopherfujino, bdero} This change reverts the following previous change: Tells our iOS bots to use the provisioning profile stored in the flutter_internal/mac/mobileprovision CIPD packages tagged `version:to_2025`. This CIPD package contains an updated provisioning profile which supports both the current development signing certificate expiring in October 2024, and the updated signing cert expiring in August 2025. Also removes the CIPD dependency for devicelab tasks. On devicelab bots, the cert and provisioning profile are deployed via Salt, not via CIPD. We only need this dependency on the Chromium bots. CIPD packages can be seen at: https://chrome-infra-packages.appspot.com/p/flutter_internal/mac/mobileprovision Required for: https://g-issues.chromium.org/issues/366034566 Issue: https://github.com/flutter/flutter/issues/152888
-
由 Chris Bracken 创作于
Tells our iOS bots to use the provisioning profile stored in the flutter_internal/mac/mobileprovision CIPD packages tagged `version:to_2025`. This CIPD package contains an updated provisioning profile which supports both the current development signing certificate expiring in October 2024, and the updated signing cert expiring in August 2025. Also removes the CIPD dependency for devicelab tasks. On devicelab bots, the cert and provisioning profile are deployed via Salt, not via CIPD. We only need this dependency on the Chromium bots. CIPD packages can be seen at: https://chrome-infra-packages.appspot.com/p/flutter_internal/mac/mobileprovision Required for: https://g-issues.chromium.org/issues/366034566 Issue: https://github.com/flutter/flutter/issues/152888
-
由 Nate Wilson 创作于
This pull request follows up on [a PR from 4 months ago](https://github.com/flutter/flutter/pull/147432) that aimed to reduce the number of `Container` objects in the framework. I feel like now's a good time to wrap it up! (especially since I've gained a grasp of how "rebase" vs. "merge commit" can [affect test results](https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#using-git) ð) <br> resolves #147431
-
由 Matan Lurey 创作于
**This is a WIP**, and the only reason it is not a draft PR is so that Flutter (Skia) Gold is executed. --- Closes https://github.com/flutter/flutter/issues/148269. Work towards https://github.com/flutter/flutter/issues/148269.
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/ade8ef293bc6...ee5adf6d2ee1 2024-09-11 magder@google.com Zip and upload Xcode xcresults on scenario test failure (flutter/engine#55093) 2024-09-11 jonahwilliams@google.com [Impeller] hash less text stuff per frame for text rendering. (flutter/engine#55060) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 Loïc Sharma 创作于
### Problem Enabling the Swift Package Manager feature caused post-submit tests to fail on Mac x64 hosts: <details> <summary>Example error...</summary> https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20rrect_blur_perf_ios__timeline_summary/575/overview ``` ⦠... flutter --verbose assemble ... -dIosArchs=x86_64 ... profile_unpack_ios Target profile_unpack_ios failed: Exception: Binary ... build/ios/Profile-iphoneos/Flutter.framework/Flutter does not contain x86_64. Running lipo -info: Non-fat file: ... build/ios/Profile-iphoneos/Flutter.framework/Flutter is architecture: arm64 #0 UnpackIOS._thinFramework (package:flutter_tools/src/build_system/targets/ios.dart:351:7) <asynchronous suspension> #1 UnpackIOS.build (package:flutter_tools/src/build_system/targets/ios.dart:298:5) <asynchronous suspension> ... ``` </details> ### Reproduction On a mac x64 host: 1. Switch to the latest master channel: `flutter channel master ; flutter upgrade` 1. Disable the Swift Package Manager feature: `flutter config --no-enable-swift-package-manager` 2. Create a Flutter project 2. [Edit the Xcode project manually to add the prepare pre-action](https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-app-developers#step-2-add-run-prepare-flutter-framework-script-pre-action) 3. Run `flutter run` (`flutter build ios` does not reproduce this issue). ### Background Previously, the Flutter framework was unpacked in the Xcode target's build. Unfortunately, this happens after Swift packages are built; this prevented Swift packages from using the Flutter framework. To fix this, we added an Xcode pre-action that unpacks the Flutter framework _before_ Swift Package Manager builds packages. The Xcode target still runs the Flutter framework unpack step, but this step no-ops if the unpack step has the exact same inputs. ```mermaid flowchart LR A[flutter run -d iphone] --> B(Build Xcode project) B --> C(Xcode 'prepare framework' pre-action) B --> G[Build Swift packages] B --> D(Build 'Runner' target) C --> E[Unpack Flutter framework #1] D --> F[" Unpack Flutter framework #2 (No-ops if inputs are same as #1) "] ``` https://github.com/flutter/flutter/pull/150052 added an optimization that made it more likely the second unpack step no-ops by fixing a case where the target architecture input could be different: > When using SwiftPM, we use `flutter assemble` in an Xcode Pre-action to run the `debug_unpack_macos` (or profile/release) target. This target is also later used in a Run Script build phase. Depending on `ARCHS` build setting, the Flutter/FlutterMacOS binary is thinned. In the Run Script build phase, `ARCHS` is filtered to the active arch. However, in the Pre-action it doesn't always filter to the active arch. As a workaround, assume arm64 if the [`NATIVE_ARCH`](https://developer.apple.com/documentation/xcode/build-settings-reference/#NATIVEARCH) is arm, otherwise assume x86_64. This optimization is only applied if [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157) is `YES`. > [!IMPORTANT] > [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157)'s name is misleading. It specifies whether the product includes only object code for the native architecture. > > A value of `YES` means the product includes only code for the native architecture ([NATIVE_ARCH](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW59)). > > A value of `NO` means the product includes code for the architectures specified in [ARCHS (Architectures)](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW62). ### Problem `buildXcodeProject` incorrectly always sets `ONLY_ACTIVE_ARCH` to `YES` if the Xcode built is for a single architecture: https://github.com/flutter/flutter/blob/6abef222514e8039bde5c47ab7864abbc4caf7e8/packages/flutter_tools/lib/src/ios/mac.dart#L353-L361 This is incorrect! If the host architecture is `x64` but the target architecture is `arm64`, [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157) should be `NO`. This caused the prepare pre-action to incorrectly use x64 as the target architecture for arm64 devices on an x64 host, which in turn caused builds to fail if Swift Package Manager was enabled. ### Solution This change updates `buildXcodeProject` to set `ONLY_ACTIVE_ARCH` correctly. This change also updates the prepare pre-action's to be more conservative in applying the optimization that filters the target architecture. This ensures that the build still works (but without the optimization) if `ONLY_ACTIVE_ARCH` is incorrectly set. Follow-up PR: https://github.com/flutter/flutter/pull/154649 This unblocks: https://github.com/flutter/flutter/issues/151567 ### DeviceLab test This problem reproduces if you `flutter run` to an iPhone Arm64 device from an x64 mac host with the Swift Package Manager feature enabled. I ran an affected DeviceLab test to verify the fix works as expected: Description | CI test | Result -- | -- | -- SwiftPM enabled without this fix: https://github.com/flutter/flutter/pull/154750 | [Link](https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_ios%20rrect_blur_perf_ios__timeline_summary/7/overview) | â SwiftPM enabled with this fix: https://github.com/flutter/flutter/pull/154749 | [Link](https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_ios%20rrect_blur_perf_ios__timeline_summary/8/overview) | â
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/packages/compare/bb53e5d536ae...4c18648650ae 2024-09-11 10687576+bparrishMines@users.noreply.github.com Adds internal wrapper for Android native `ContentProgressProvider` (flutter/packages#7461) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/4eb729b7a5c4...ade8ef293bc6 2024-09-11 skia-flutter-autoroll@skia.org Roll Skia from 44b4a40178cc to fb0b2eb61b65 (1 revision) (flutter/engine#55104) 2024-09-11 reidbaker@google.com Add back FlutterViewTest.java (flutter/engine#55048) 2024-09-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8XJTJm4D4Go1dBaTi... to fKNT8lbGh8JzxjE6m... (flutter/engine#55103) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 8XJTJm4D4Go1 to fKNT8lbGh8Jz If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 Kishan Rathore 创作于
fix: Dropdown menu trying to access highlight element which doesn't exist when search and filters both are enabled (#151969) DropdownMenu throws RangeError when both filter and search are enabled because when we search for elements, we have some highlighted element, but if there is no element to highlight it tries to access 0th element is the filtered entries, but entries are empty. Fixes #151878
-
由 Flutter GitHub Bot 创作于
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux build_tests_3_5" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_3_5%22). This test can be marked as unflaky.
-
由 abdalmonem 创作于
This PR add the ability to change buttons of 'SegmentedButton' directionality (In the vertical and horizontal axis) to be 'vertical' or 'horizontal' instead of just horizontally position by adding "direction" argument. `direction: Axis.horizontal` : ![Simulator Screenshot - iPhone 15 - 2024-06-26 at 13 37 26](https://github.com/flutter/flutter/assets/9139030/4936b7f8-246b-41ae-ac1c-7c75bc2d4f2d) `direction: Axis.vertical` : ![Simulator Screenshot - iPhone 15 - 2024-06-26 at 13 43 07](https://github.com/flutter/flutter/assets/9139030/5aecf229-34d8-4608-a0f7-aee5c130257f) Notice: in this example i used: `style: ButtonStyle( shape: MaterialStateProperty.all<RoundedRectangleBorder>( const RoundedRectangleBorder( borderRadius: BorderRadius.zero, ), ), ) ` To change the Radius of `SegmentedButton`, and the default shape will be like: ![Simulator Screenshot - iPhone 15 - 2024-06-26 at 13 51 46](https://github.com/flutter/flutter/assets/9139030/24833153-02c8-4f5c-8c50-5a0effa19e9e) I keep it as it is right now, cause its not the main purpose of this BR. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* Fixes: #150416
-
由 Flutter GitHub Bot 创作于
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux build_tests_5_5" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_5_5%22). This test can be marked as unflaky.
-
由 Lau Ching Jun 创作于
Following https://dart-review.googlesource.com/c/sdk/+/383901
-
由 gaaclarke 创作于
This migrates the last failing test for https://github.com/flutter/engine/pull/54981. In order to effectively resolve that test I had to make `equalsIgnoringHashCodes` more usable by printing out the line that differs instead of just a huge blob of "expected" vs "actual. ## example Here's the output after the change. ### test ``` test('equalsIgnoringHashCodes - wrong line', () { expect( '1\n2\n3\n4\n5\n6\n7\n8\n9\n10', equalsIgnoringHashCodes('1\n2\n3\n4\n5\n6\na\n8\n9\n10'), ); }); ``` ### output ``` Expected: normalized value matches '1\n' '2\n' '3\n' '4\n' '5\n' '6\n' 'a\n' '8\n' '9\n' '10' Actual: '1\n' '2\n' '3\n' '4\n' '5\n' '6\n' '7\n' '8\n' '9\n' '10' Which: Lines 7 differed, expected: 'a' but got '7' ```
-
由 Flutter GitHub Bot 创作于
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux build_tests_1_5" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_1_5%22). This test can be marked as unflaky.
-
由 Flutter GitHub Bot 创作于
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux build_tests_2_5" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_tests_2_5%22). This test can be marked as unflaky.
-
由 Shashwat Pathak 创作于
This PR modifies the warning message regarding Java compatibility to make it consistent with the Flutter style guide. **Current message looks like this** ``` [RECOMMENDED] If so, to keep the default AGP version 8.1.0, make sure to download a compatible Java version (Java 17 <= compatible Java version < Java 21). You may configure this compatible Java version by running: `flutter config --jdk-dir=<JDK_DIRECTORY>` Note that this is a global configuration for Flutter. Alternatively, to continue using your configured Java version, update the AGP version specified in the following files to a compatible AGP version (minimum compatible AGP version: 7.0) as necessary: - /home/user/project/testproj/android/build.gradle See https://developer.android.com/build/releases/gradle-plugin for details on compatible Java/AGP versions. ``` **After Modification** ``` To keep the default AGP version 8.1.0, download a compatible Java version (Java 17 <= compatible Java version < Java 21). Configure this Java version globally for Flutter by running: flutter config --jdk-dir=<JDK_DIRECTORY> Alternatively, to continue using your current Java version, update the AGP version in the following file(s) to a compatible version (minimum AGP version: 7.0): /home/user/project/testproj/android/build.gradle For details on compatible Java and AGP versions, see https://developer.android.com/build/releases/gradle-plugin ``` Fixes #152460
-
- 9月 11, 2024
-
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/54757dab9462...4eb729b7a5c4 2024-09-11 skia-flutter-autoroll@skia.org Roll Skia from 320dccf1a32d to 44b4a40178cc (1 revision) (flutter/engine#55101) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 Gray Mackall 创作于
Used the wrong syntax, whoops ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Gray Mackall <mackall@google.com>
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/0a14c519ea4f...54757dab9462 2024-09-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 072945e0b457 to a438066d634f (1 revision) (flutter/engine#55100) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/35a3171b72c5...0a14c519ea4f 2024-09-11 skia-flutter-autoroll@skia.org Roll Skia from 7a4bd062b193 to 320dccf1a32d (2 revisions) (flutter/engine#55099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/b9c0b96c3316...35a3171b72c5 2024-09-11 skia-flutter-autoroll@skia.org Roll Skia from a7ddd4d2c6bb to 7a4bd062b193 (1 revision) (flutter/engine#55098) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/52eeea075767...b9c0b96c3316 2024-09-11 skia-flutter-autoroll@skia.org Roll Skia from 618beab475b6 to a7ddd4d2c6bb (1 revision) (flutter/engine#55096) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/a26075f9b1e6...52eeea075767 2024-09-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 22d8331d882e to 072945e0b457 (1 revision) (flutter/engine#55097) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/60c15bc0f40e...a26075f9b1e6 2024-09-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 741512e72e92 to 22d8331d882e (1 revision) (flutter/engine#55094) 2024-09-10 matanlurey@users.noreply.github.com Move `flutter_frontend_server` and tweak `run_tests.py` to allow env variables. (flutter/engine#55089) 2024-09-10 jonahwilliams@google.com [Impeller] fix comment on savelayer utils. (flutter/engine#55049) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 1760de26fb83 to 618beab475b6 (2 revisions) (flutter/engine#55088) 2024-09-10 jonahwilliams@google.com [Impeller] Fix memory leak I introduced by fixing memory leak. (flutter/engine#55087) 2024-09-10 matanlurey@users.noreply.github.com Remove the last `--disable-dart-dev` in the engine. (flutter/engine#55086) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 Matan Lurey 创作于
Closes https://github.com/flutter/flutter/issues/154596. It's less clear to me if your goal was to migrate _all_ of these btw: https://github.com/search?q=org%3Aflutter+%22mobile-web-app-capable%22&type=code
-
由 engine-flutter-autoroll 创作于
https://github.com/flutter/engine/compare/8a038a6f7099...60c15bc0f40e 2024-09-10 58529443+srujzs@users.noreply.github.com Update package:web to use new path and latest revision (flutter/engine#55085) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 82d2e4033333 to 1760de26fb83 (8 revisions) (flutter/engine#55084) 2024-09-10 matanlurey@users.noreply.github.com Move more of the tests in the engine to `package:test` (flutter/engine#55083) 2024-09-10 matanlurey@users.noreply.github.com Redirect `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53717) 2024-09-10 jonahwilliams@google.com [Impeller] reland experimental canvas. (flutter/engine#55047) 2024-09-10 magder@google.com Fix 'dart --enable-asserts' typo in license check script (flutter/engine#55082) 2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from af7460619b2b to 741512e72e92 (1 revision) (flutter/engine#55080) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 4815ec808aa5 to 82d2e4033333 (8 revisions) (flutter/engine#55079) 2024-09-10 rmacnak@google.com Roll buildroot to f85c3be4bf808add6ba867b8ff7943fd235b7b5e. (flutter/engine#55051) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 5dc067350ab5 to 4815ec808aa5 (2 revisions) (flutter/engine#55074) 2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from d59138eb6ec2 to af7460619b2b (1 revision) (flutter/engine#55073) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from c62380453c72 to 5dc067350ab5 (1 revision) (flutter/engine#55072) 2024-09-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kIWQ460iagZLxVRPc... to 8XJTJm4D4Go1dBaTi... (flutter/engine#55071) 2024-09-10 skia-flutter-autoroll@skia.org Roll Skia from 9bea95918e69 to c62380453c72 (1 revision) (flutter/engine#55070) 2024-09-10 skia-flutter-autoroll@skia.org Roll Dart SDK from a60078a23978 to d59138eb6ec2 (2 revisions) (flutter/engine#55068) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kIWQ460iagZL to 8XJTJm4D4Go1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
由 John McDole 创作于
I missed awaiting a future. Probably should have a lint for unawaited futures...
-
由 gaaclarke 创作于
issue: https://github.com/flutter/flutter/issues/127855 This is a forward fix to help https://github.com/flutter/engine/pull/54981 land. It makes the following changes: 1) Removes hardcoded `Color.toString()` assumptions in asserts 1) Switches some lerp tests to use numbers that are more friendly to uint8_t and floating point numbers 1) implements custom matchers for color 1) removes word wrapping for some asserts since it makes them fragile to changes in `Color.toString()` invocations ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
-
由 Andrew Kolos 创作于
~~Fixes~~ Discovered in https://github.com/flutter/flutter/issues/153776. To my knowledge, `Resource temporarily unavailable` when trying to run a process means that some required resource is at capacity. There may be too many processes active, not enough available ports, or some sort of blocking cache is full, etc. Feel free to independently research and see if you come to the same conclusion. Then, it seems safe to catch and handle this within the tool's `ErrorHandlingProcessManager` abstraction, as Flutter cannot realistically do anything to prevent this issue.
-
由 Mairramer 创作于
Fixes #153889 an issue where nodes were being removed incorrectly when using `AnimationStyle.noAnimation `or the animation duration was zero seconds, which previously caused the application to freeze due to hidden state updates. By skipping the animation and updating active nodes immediately in these cases, we avoid these issues and ensure smooth and accurate management of node states.
-
由 Matan Lurey 创作于
Work towards https://github.com/flutter/flutter/issues/154268.
-
由 Gray Mackall 创作于
This option was deprecated (/removed?) in the time since the test was originally disabled. See https://github.com/flutter/flutter/issues/109712, https://github.com/flutter/flutter/pull/109714
-
由 flutter-pub-roller-bot 创作于
This PR was generated by `flutter update-packages --force-upgrade`.
-
由 Qun Cheng 创作于
This PR is to improve `CupertinoSlidingSegmentedControl` fidelity and add a new property `setEnabled` so that segments can be disabled now. Fidelity update includes: * small change on default thumb radius (Based on iOS 17 Figma file) * separator height (Based on the comparison with SegmentedControl example in Xcode) * segment min padding (Based on iOS 17 Figma file) * thumb scale alignment (Based on the comparison with SegmentedControl example in Xcode). If the thumb is on the first or last position in SegmentedControl, the alignment should be `Alignment.leftCenter` and `Alignment.rightCenter` respectively, assuming the text direction is left to right. For segments in middle, they should have center alignment as previously. * TextStyle update (Based on both the Figma file and the Xcode example) * Clipped thumb shadow if the shadow is outside of the segmented control (Based on the Xcode example) * Fixed the overall size shaking issue during segment switching on macOS and iOS <details><summary>Alignment update demo</summary> https://github.com/user-attachments/assets/6de3986f-6810-4dc4-8688-f87120557d89 </details> <details><summary>Comparison before and after</summary> Before: ![Screenshot 2024-08-08 at 1 42 57â¯PM](https://github.com/user-attachments/assets/fe2e49a8-4bbd-4d54-9aba-1f47ab9bd9d9) After: ![Screenshot 2024-08-08 at 1 43 50â¯PM](https://github.com/user-attachments/assets/d3292f74-8d04-40ed-ae72-bf2e9b1751a4) </details> <details><summary>Shaking issue</summary> Before: https://github.com/user-attachments/assets/910d1271-75ea-4cec-8666-24090f9d4fb0 After: https://github.com/user-attachments/assets/bc5ae3e1-600d-49a6-95d9-b1f5d1bd9f6d </details> The `disabledChildren` feature can be used to disable segments. The default disabled color comes from the inspection in the Xcode example. <details><summary>Disabled feature demos</summary> Disabled segment cannot be highlighted: https://github.com/user-attachments/assets/70339364-23d5-41c7-b071-c7abe92abd62 `groupValue` can still be highlighted programmatically if it is disabled. ![Screenshot 2024-09-04 at 5 45 25â¯PM](https://github.com/user-attachments/assets/99d37903-3605-475f-b87a-ae118a23e94d) </details>
-
由 flutter-pub-roller-bot 创作于
This PR was generated by `flutter update-packages --force-upgrade`.
-
由 Andrew Kolos 创作于
Fixes https://github.com/flutter/flutter/issues/154857. Does so by: * adding `await chromiumLauncher.connect(chrome, false);` before the `close` call to make sure we enter[ the block ](https://github.com/flutter/flutter/blob/9cd2fc90af406a5ae798a6e099f3fca3eebd0da0/packages/flutter_tools/lib/src/web/chrome.dart#L521-L535)that actually tries to close chromium * adding an `onGetTab` callback to `FakeChromeConnectionWithTab`, which the test now uses to throw a StateError upon `getTab` getting called. ## How I verified this change 1. Change `Chromium.close` from using the safer `getChromeTabGuarded` function to using the previous method of calling `ChromeConnection.getTab` directly. Do so by applying this diff: ```diff diff --git a/packages/flutter_tools/lib/src/web/chrome.dart b/packages/flutter_tools/lib/src/web/chrome.dart index c9a5fdab81..81bc246ff9 100644 --- a/packages/flutter_tools/lib/src/web/chrome.dart +++ b/packages/flutter_tools/lib/src/web/chrome.dart @@ -520,7 +520,7 @@ class Chromium { Duration sigtermDelay = Duration.zero; if (_hasValidChromeConnection) { try { - final ChromeTab? tab = await getChromeTabGuarded(chromeConnection, + final ChromeTab? tab = await chromeConnection.getTab( (_) => true, retryFor: const Duration(seconds: 1)); if (tab != null) { final WipConnection wipConnection = await tab.connect(); ``` 2. Then, run the test, which should correctly fail: ``` dart test test/web.shard/chrome_test.dart --name="chrome.close can recover if getTab throws a StateError"` ``` 3. Revert the change from step 1 and run again. The test should now pass.
-
由 Justin McCandless 创作于
SearchBar and SearchAnchor can now control their context menu. They both received new contextMenuBuilder parameters. See the docs for EditableText.contextMenuBuilder for how to use this, including how to use the native context menu on iOS and to control the browser's context menu on web.
-