Skip to content
GitLab
菜单
为什么选择 GitLab
定价
联系销售
探索
为什么选择 GitLab
定价
联系销售
探索
登录
获取免费试用
主导航
搜索或转到…
项目
R
roslyn
管理
动态
成员
标记
计划
议题
议题看板
里程碑
Wiki
代码
合并请求
仓库
分支
提交
标签
仓库图
比较修订版本
代码片段
构建
流水线
作业
流水线计划
产物
部署
发布
软件包库
容器镜像库
模型注册表
运维
环境
Terraform 模块
监控
事件
服务台
分析
价值流分析
贡献者分析
CI/CD 分析
仓库分析
模型实验
帮助
帮助
支持
GitLab 文档
比较 GitLab 各版本
社区论坛
为极狐GitLab 提交贡献
提交反馈
隐私声明
快捷键
?
新增功能
4
代码片段
群组
项目
Show more breadcrumbs
麦壳饼
roslyn
提交
419ee237
未验证
提交
419ee237
编辑于
1年前
作者:
Tomáš Matoušek
提交者:
GitHub
1年前
浏览文件
操作
下载
补丁
差异文件
EnC: Stop reporting CS7101 on runtime that supports generic updates (#68601)
上级
d7a60bba
No related branches found
分支 包含提交
No related tags found
标签 包含提交
无相关合并请求
变更
1
隐藏空白变更内容
行内
左右并排
显示
1 个更改的文件
src/Features/Core/Portable/EditAndContinue/EditSession.cs
+13
-1
13 个添加, 1 个删除
src/Features/Core/Portable/EditAndContinue/EditSession.cs
有
13 个添加
和
1 个删除
src/Features/Core/Portable/EditAndContinue/EditSession.cs
+
13
−
1
浏览文件 @
419ee237
...
...
@@ -990,6 +990,18 @@ async ValueTask LogDocumentChangesAsync(int? generation, CancellationToken cance
// project must support compilations since it supports EnC
Contract
.
ThrowIfNull
(
newCompilation
);
// The compiler only uses this predicate to determine if CS7101: "Member 'X' added during the current debug session
// can only be accessed from within its declaring assembly 'Lib'" should be reported.
// Prior to .NET 8 Preview 4 the runtime failed to apply such edits.
// This was fixed in Preview 4 along with support for generics. If we see a generic capability we can disable reporting
// this compiler error. Otherwise, we leave the check as is in order to detect at least some runtime failures on .NET Framework.
// Note that the analysis in the compiler detecting the circumstances under which the runtime fails
// to apply the change has both false positives (flagged generic updates that shouldn't be flagged) and negatives
// (didn't flag cases like https://github.com/dotnet/roslyn/issues/68293).
var
capabilities
=
await
Capabilities
.
GetValueAsync
(
cancellationToken
).
ConfigureAwait
(
false
);
var
isAddedSymbolPredicate
=
capabilities
.
HasFlag
(
EditAndContinueCapabilities
.
GenericAddMethodToExistingType
)
?
static
_
=>
false
:
(
Func
<
ISymbol
,
bool
>)
projectChanges
.
AddedSymbols
.
Contains
;
EmitDifferenceResult
emitResult
;
// The lock protects underlying baseline readers from being disposed while emitting delta.
...
...
@@ -1001,7 +1013,7 @@ async ValueTask LogDocumentChangesAsync(int? generation, CancellationToken cance
emitResult
=
newCompilation
.
EmitDifference
(
projectBaseline
.
EmitBaseline
,
projectChanges
.
SemanticEdits
,
projectChanges
.
AddedSymbol
s
.
Contains
,
is
AddedSymbol
Predicate
,
metadataStream
,
ilStream
,
pdbStream
,
...
...
This diff is collapsed.
点击以展开。
预览
0%
加载中
请重试
或
添加新附件
.
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
保存评论
取消
想要评论请
注册
或
登录